Received: by 10.192.165.148 with SMTP id m20csp4111471imm; Tue, 8 May 2018 03:10:34 -0700 (PDT) X-Google-Smtp-Source: AB8JxZo89XtTe+rtovSkBh9cQg8TdDrZJnK0AdRdzYi/cZ/MY56N0zsmDP2XbB44JvlpiMZwoL9L X-Received: by 2002:a17:902:9349:: with SMTP id g9-v6mr38934099plp.375.1525774234789; Tue, 08 May 2018 03:10:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525774234; cv=none; d=google.com; s=arc-20160816; b=qZedKg46hl87lzsJrKE2WlbwpUACNfK+mdPmZmyjjx+zAvMQe9ldUgKhoeCosBNgZi +uKtkiInGwnDNloA1jbPjZp0dsOqn9Oq2kki4bv/bzGKIBqxQiyM2SDmNXuGUpptm+lF av7942Q9DcZr3oNkTztS8KtMPuxoOuuM6s0KbeO/khv4bBDEwV9M0BTzdEfQe+uayWS1 uPw7SiGTr07gcV9ZRZAAkyJ0Bs3HHOK7fB7qJXTCb7ULlptowWXwprn5BvUZfya03eo0 LQFVY+0F0FmqsaX0hFn7iVd8+uJU+jlbyRX4VWqf2/ZrLrY+t1EsLi0D7qWsVzf2sKKR Flzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=jnCApuJq13E1c9LJRfBLxOUYR52fxzVLeRTyoXIaanc=; b=aRSc74+5rUwWTYPH4tgyxfWJM3ra2mZDBWT5ETS/sJMz33idiskqbIrA9HLAD+6Vi+ WIeausDHK97p/+81lSwo6MMg143p6DPc6sRAC4yOrVubekLHH92is11dJOZ7HTpzQiPQ lHOXozXOHgodCeiFyR8ffkybScoauD91PHjpJJPqlCC9mPUiJSMDqzw1AKPFNjEqwijP bGVMKvzqlXwGkkUezcbCKz9229N7HMexnoR7ycFxwalHpVWJP+9LC34/YaDhVf9gxqNg DFVWX80syhYwj2FaLizv9/NLLLjOMrZXwYZXXfLAqDFpUWi7YgJz9ZO0nLABChueIKN5 1ovA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=cn8NHdcF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e68-v6si23402411plb.566.2018.05.08.03.10.20; Tue, 08 May 2018 03:10:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=cn8NHdcF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754554AbeEHKI7 (ORCPT + 99 others); Tue, 8 May 2018 06:08:59 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:45431 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754223AbeEHKI4 (ORCPT ); Tue, 8 May 2018 06:08:56 -0400 Received: by mail-lf0-f66.google.com with SMTP id y14-v6so44634721lfy.12; Tue, 08 May 2018 03:08:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=jnCApuJq13E1c9LJRfBLxOUYR52fxzVLeRTyoXIaanc=; b=cn8NHdcFyrmVKj75kOZpLMTmPLEimXhoN2SKHq/Qtp5NXBagbKecm1DB5gKKh0sdIf hctOoFqlgXs7FsmTnmL/CBmBzfRVOMp0JP9BzIkGzjLtKrgtGw2lvCI6Sm2OWVAhdDVw J0hH9Qp2ncrzMtpv9lWSR4zgpKYlCF+WMWfBBYZTN6BFCEnL3qh8NvxPGB657W4JIaWp Wah/g516yGnQzlQ9UHF+3+qLfD6qsm9CV2ZOWVHYdWnexUT08FSxsuTRDuGlHLQfwB7/ Z0dNqfzZlpxDJylVWHODDds7fdaRLw+6ZhG1y6qQWXnVx7eQQKx94vBg35TkNXJ4AICM iCtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=jnCApuJq13E1c9LJRfBLxOUYR52fxzVLeRTyoXIaanc=; b=BqZMdy1BMbt6bjQtbxahYWXea+j4a4ly7jpnAkZJ30Z67sC+VWwOQQoDIumtAQWF87 YUgrA/t2FOGz/Twwe11Kc1/jFZnooJgV0BDRsYRTLS0FA5JTciKhsBFDJbnF4X6+icYA fpfYILOaWggWDLmggSnN5JvZ5+/xXmlBTB0b3DF4Ir1ZAN50CDdkQQJ7ZVJ66+I1ZauZ jk16vk3gsLU/Wg7WWhv8pkXjV5RxuSN5WLcepCJxcT+qeb9cXpOzoA8NffJ0bQCG87TL 0xtLv7iuLRNnuzQTaQ5X6laIwSk5M0+z/htRF/Of6cnlDcSciMSncmS7RZcKsVK4lNRK yJsQ== X-Gm-Message-State: ALQs6tBKVgUEnGau0qklglNf9eQ8rKELwN/8RKdOPz+x2yY/MPy2fQuM cvUoP6hd+TQhSxs6BG/7itwNa/XM X-Received: by 2002:a19:9389:: with SMTP id w9-v6mr25065201lfk.75.1525774134686; Tue, 08 May 2018 03:08:54 -0700 (PDT) Received: from xi.terra (c-8bb2e655.07-184-6d6c6d4.cust.bredbandsbolaget.se. [85.230.178.139]) by smtp.gmail.com with ESMTPSA id l124-v6sm1656734lfg.62.2018.05.08.03.08.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 May 2018 03:08:53 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.90_1) (envelope-from ) id 1fFzYB-0007qG-Jn; Tue, 08 May 2018 12:08:52 +0200 Date: Tue, 8 May 2018 12:08:51 +0200 From: Johan Hovold To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Greg Kroah-Hartman , Jiri Slaby , Johan Hovold , Jacek Anaszewski , Pavel Machek , linux-serial@vger.kernel.org, linux-leds@vger.kernel.org, linux-can@vger.kernel.org, kernel@pengutronix.de, One Thousand Gnomes , Florian Fainelli , Mathieu Poirier , linux-kernel@vger.kernel.org, Robin Murphy , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 3/3] tty: implement led triggers Message-ID: <20180508100851.GY2285@localhost> References: <20180508100543.12559-1-u.kleine-koenig@pengutronix.de> <20180508100543.12559-4-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180508100543.12559-4-u.kleine-koenig@pengutronix.de> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 08, 2018 at 12:05:43PM +0200, Uwe Kleine-K?nig wrote: > The rx trigger fires when data is pushed to the ldisc by the driver. This > is a bit later than the actual receiving of data but has the nice benefit > that it doesn't need adaption for each driver and isn't in the hot path. > > Similarly the tx trigger fires when data was copied from userspace and is > given to the ldisc. > > Signed-off-by: Uwe Kleine-K?nig > --- > arch/arm/boot/dts/imx25-logitech-baby.dts | 192 ++++++++++++++++++++++ Looks like you included more than intended in this patch. > drivers/tty/Kconfig | 7 + > drivers/tty/tty_buffer.c | 2 + > drivers/tty/tty_io.c | 3 + > drivers/tty/tty_port.c | 32 +++- > include/linux/tty.h | 22 +++ > 6 files changed, 256 insertions(+), 2 deletions(-) > create mode 100644 arch/arm/boot/dts/imx25-logitech-baby.dts Johan