Received: by 10.192.165.148 with SMTP id m20csp4179635imm; Tue, 8 May 2018 04:26:26 -0700 (PDT) X-Google-Smtp-Source: AB8JxZo+92U9aeUY/QqFcymoRbVorpCCXpe2YGCOcek1l9CG7gNpZ3iyzpRltNA9CtPUActVq8DO X-Received: by 2002:a65:5504:: with SMTP id f4-v6mr17919015pgr.177.1525778786370; Tue, 08 May 2018 04:26:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525778786; cv=none; d=google.com; s=arc-20160816; b=q3Q4HHIYscES/0EJ6R6+8eWv+7KqhK7tmrfQuOiufDcUmNxEAYL7YLe0ii7+Iy52+Y 9dz0E5mMPS3jvVXfzMNYXtCKTALDaXmx3girZd/tegZedhnDDQ5XaPP8Amux13w3k4qZ jBbCw4t1RLtPFA7lAHKaYATS073yAd7uobfaO7ElKtuFNUFwdU2Mvwcid5+b6SDEsfqn FhaKqx9cSR6gRiKMpwUV3QVuF/YVcjujrfyeeMwtbfpCp0zyrF88e3dMc8TR+pbBonhf wNQx2pky6ZMV6q2/AITw+lloSo8Bok3libOfeYy1r3+Xb++ZYlVk27JJvn8uQiAEDqvy 6rgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=K2xut+jbiipsPj6OG35Z8B1S+gSpVZTrybCTMOgFw+c=; b=Agv5gMxcNomj7cKjMDIrO1189++2bLnMczVLBP/FF0yyKvGNItHC+Db5iKs8wWXwcb Fw2xKb6Yz3Wn9ExIji0WICAt6wDFkyW1npnGbM6loviWb6zhKiMjmQsE8P/DaRnB9lAv myDpJJCZtpf4aEG46hsE6EHjG6DWNtOUspow1FpnHRXK/aORKShL8FCg7aRwbwTTNoXG Ab6atB5jXtnGB/pRoykvJTYygik6Kr4x7X5vKfbLManeIHKnsPqyzNrZhSrNwNbzW/T5 HFTt3k94YIZRkrREsnDgbVC24ta6GBR935kV8UcGH3tnIPGlcZXtKDP6/N7x55pX0Iwk tXsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@armlinux.org.uk header.s=pandora-2014 header.b=hfq6jPCl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y67-v6si19161553pgb.35.2018.05.08.04.26.12; Tue, 08 May 2018 04:26:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@armlinux.org.uk header.s=pandora-2014 header.b=hfq6jPCl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932139AbeEHLZa (ORCPT + 99 others); Tue, 8 May 2018 07:25:30 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:51346 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932105AbeEHLZ2 (ORCPT ); Tue, 8 May 2018 07:25:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2014; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=K2xut+jbiipsPj6OG35Z8B1S+gSpVZTrybCTMOgFw+c=; b=hfq6jPClaWRhAZC+8RvHwahuH 5Gf1uDgCYlFfn2/WNTf76EHfs0j4x8d5wDU3jObc+Ptqc/pE3wWHB1zQKbocnX5a49/bxoGuiOdXi frp16bVpFJ4gM7gi7jvQPdgn/ybZ+SYq29KuxvCfEWLCASmZwnFlZkjOAknfLvnUYGu7g=; Received: from n2100.armlinux.org.uk ([fd8f:7570:feb6:1:214:fdff:fe10:4f86]:55370) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) (envelope-from ) id 1fG0k9-0006WB-Hb; Tue, 08 May 2018 12:25:17 +0100 Received: from linux by n2100.armlinux.org.uk with local (Exim 4.90_1) (envelope-from ) id 1fG0k1-0006Yx-UI; Tue, 08 May 2018 12:25:10 +0100 Date: Tue, 8 May 2018 12:25:03 +0100 From: Russell King - ARM Linux To: Masami Hiramatsu Cc: Wang Nan , Will Deacon , Jon Medhurst , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, David Long , stable@vger.kernel.org Subject: Re: [BUGFIX PATCH v3 0/4] arm: kprobes: Fix to prohibit probing on unsafe functions Message-ID: <20180508112503.GD16141@n2100.armlinux.org.uk> References: <152540727123.29650.13679359124038587629.stgit@devbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152540727123.29650.13679359124038587629.stgit@devbox> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 04, 2018 at 01:14:31PM +0900, Masami Hiramatsu wrote: > Hi, > > This is the 3rd version of bugfix series for kprobes on arm. > This series fixes 4 different issues which I found. > > - Fix to use smp_processor_id() after disabling preemption. > - Prohibit probing on optimized_callback() for avoiding > recursive probe. > - Prohibit kprobes on do_undefinstr() by same reason. > - Prohibit kprobes on get_user() by same reason. > > >From v2, I included another 2 bugfixes (1/4 and 2/4) > which are not merged yet, and added "Cc: stable@vger.kernel.org", > since there are obvious bugs. Please submit them to the patch system, thanks. > > Thanks, > > --- > > Masami Hiramatsu (4): > arm: kprobes: Fix to use get_kprobe_ctlblk after irq-disabed > arm: kprobes: Prohibit probing on optimized_callback > arm: kprobes: Prohibit kprobes on do_undefinstr > arm: kprobes: Prohibit kprobes on get_user functions > > > arch/arm/include/asm/assembler.h | 10 ++++++++++ > arch/arm/kernel/traps.c | 5 ++++- > arch/arm/lib/getuser.S | 10 ++++++++++ > arch/arm/probes/kprobes/opt-arm.c | 4 +++- > 4 files changed, 27 insertions(+), 2 deletions(-) > > -- > Masami Hiramatsu (Linaro) -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up