Received: by 10.192.165.148 with SMTP id m20csp4200218imm; Tue, 8 May 2018 04:49:20 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrR8U0YgpI39YOToSx9eo7F/xZH93cAHnH6nDSkJAPo0AIs656kFh7N/7OKQI8cO/tCG5Ia X-Received: by 2002:a17:902:8ec4:: with SMTP id x4-v6mr40672529plo.370.1525780160725; Tue, 08 May 2018 04:49:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525780160; cv=none; d=google.com; s=arc-20160816; b=jhjWBINi8iZuX4Q9wfncRWuGibb9Jze9iPmdN+yHPrp0Fv9qjb4HYp1c8cydg8cuhs EZtbQ8bbPnvDEysRgZMj4ovIeJnEMTfyHnU681193GzEPdYQKHn3PCceehogJBuQafi9 TRgCAj5OZjm8hyRNi/mXMEGnt3K2ZsgnZT0V507YIm0XAcj1mO1VWXm6BfatHTbux5po gGNNMNxGFuidjZEQbnuyUKdsecKxRI6WvJJN2O05XqPJsiaKpLr32DyaKnHuB5i5Qh0o BzvTyRgnpvAr3u6U7Tg1MjmaI7iTbuLHJcefdlOqWOF1F3pMYymYjZb5gRV5/EOSeGDo 9D5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date:dkim-signature:arc-authentication-results; bh=WUFcn7qinCgJk93wuo9xJs1o1R0vrLhLHfk91a9HRBI=; b=eeL+UdpNwvYbGxXcymp9zZh//1hbkK3pez1bwp+UUkuoEyUpF0HnmghQWGoS9yXpTz PcvXbOoQP7QduG1ayJF2qConKae5fayzLA6mz0eAx75DUId3/AKt2M2H0EOno8Gj/DMj eMCxLmip3TWP2AeFlTtuCsZUPB8LBZpr01pY0AAOp625IEEfFh5j1NKg/9wFh4XBJmiP au8ATlfvJkwyx9kUscVm0uVfMoyp6Gia1wqSuxh3D7RuOIBYxlIsq+1oYjfVI4YHlyAn BZ/OidYpf+MQiteJWyFBchKNGI+UYciLxA6oRQROYMMAJBt0/OIch9bnpUo/c2Yo08GM 2NnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uUSHsX31; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f4-v6si22997618plr.111.2018.05.08.04.49.06; Tue, 08 May 2018 04:49:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uUSHsX31; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754371AbeEHLsx (ORCPT + 99 others); Tue, 8 May 2018 07:48:53 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:39195 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753368AbeEHLsu (ORCPT ); Tue, 8 May 2018 07:48:50 -0400 Received: by mail-pf0-f194.google.com with SMTP id a22so9754533pfn.6; Tue, 08 May 2018 04:48:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WUFcn7qinCgJk93wuo9xJs1o1R0vrLhLHfk91a9HRBI=; b=uUSHsX31crvwFXEXhxntu/H4bU25Jil9ShTqcsZAWXxO0MEgr0IBy6Yh6gqeLU73yB WhM+XZmyHuWQba97eyHSK5GPbLxlWjDlBzNYZBxdNOaRRzIiWz69iO//bCeSIl71hCw+ 8kFro1/xYOi/UD6R4SN0JMRwhZFTnEtmQf+eH0b0JUzRmU28WAS7pbjh4wyh2Yn+se1V yDnF/HuRe1ySE4r3yNPuFWvjkn6HtXMZ9P1RDQXE4lr/DU3kDI/iJUXVirRJiK8Qtrpu MRxSkTuTZf+NfzJ28I48cEMYFvRfAV+wOw7D6QD3yd+/9V4g8rH06bou3K0XVyB7yWgS l6Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=WUFcn7qinCgJk93wuo9xJs1o1R0vrLhLHfk91a9HRBI=; b=Gll+VBzSxZ5ll5lVSMZluMwArVoA5paTCo7RR7uoUdR4awNfHMsSCEJbrAAlRcbCFL +i/2d00DomR6n3AmjioyBOSGmR68CFkN5TVkkZjj03IsyU5EZPVz9LsL5nYzugSWDs3D 952RSfCKcAc5t9hDjGIzC637jGZWJa+evFd26waRMJd3FT1Cqe9tbYhrn/bwIaXVFmp5 J9O8y1JZBc1xz6in3l82vQMaVoesKTZbdv0s84yvSx0b0YBX7ERgiRXI/p1QxufHbDIv b8VAQuUYM+/VSmnUa5u5eRORmE0hjhpaVy0sPoJhKfqFO2Ahn34KN+4YwysHsgZ3aRNJ wmWg== X-Gm-Message-State: ALQs6tAC1qx+kANG6zn25DC1OOH0BoLaH3PEMaVxOkTBZqsd/vs/Vabx Wl4kSAq8cGERMgZgE246bijMIqdu X-Received: by 2002:a63:7e4e:: with SMTP id o14-v6mr32045948pgn.18.1525780130126; Tue, 08 May 2018 04:48:50 -0700 (PDT) Received: from localhost (om126204193044.6.openmobile.ne.jp. [126.204.193.44]) by smtp.gmail.com with ESMTPSA id k24sm21276098pff.118.2018.05.08.04.48.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 May 2018 04:48:49 -0700 (PDT) Date: Tue, 8 May 2018 20:48:45 +0900 From: Wei Yang To: Baoquan He Cc: Wei Yang , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, robh+dt@kernel.org, dan.j.williams@intel.com, nicolas.pitre@linaro.org, josh@joshtriplett.org, Patrik Jakobsson , David Airlie , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Dmitry Torokhov , Frank Rowand , Keith Busch , Jonathan Derrick , Lorenzo Pieralisi , Bjorn Helgaas , Thomas Gleixner , Brijesh Singh , =?iso-8859-1?B?Suly9G1l?= Glisse , Borislav Petkov , Tom Lendacky , Greg Kroah-Hartman , Yaowei Bai , devel@linuxdriverproject.org, linux-input@vger.kernel.org, linux-nvdimm@lists.01.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v3 1/3] resource: Use list_head to link sibling resource Message-ID: <20180508114845.GA19459@WeideMacBook-Pro.local> Reply-To: Wei Yang References: <20180419001848.3041-1-bhe@redhat.com> <20180419001848.3041-2-bhe@redhat.com> <20180426011837.GA79340@WeideMacBook-Pro.local> <20180507011429.GG30581@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180507011429.GG30581@MiWiFi-R3L-srv> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 07, 2018 at 09:14:29AM +0800, Baoquan He wrote: >Hi Wei Yang, > >On 04/26/18 at 09:18am, Wei Yang wrote: >> On Thu, Apr 19, 2018 at 08:18:46AM +0800, Baoquan He wrote: >> >The struct resource uses singly linked list to link siblings. It's not >> >easy to do reverse iteration on sibling list. So replace it with list_head. >> > >> >> Hi, Baoquan >> >> Besides changing the data structure, I have another proposal to do the reverse >> iteration. Which means it would not affect other users, if you just want a >> reverse iteration. >> >> BTW, I don't think Andrew suggest to use linked-list directly. What he wants >> is a better solution to your first proposal in >> https://patchwork.kernel.org/patch/10300819/. >> >> Below is my proposal of resource reverse iteration without changing current >> design. > >I got your mail and read it, then interrupted by other thing and forgot >replying, sorry. > >I am fine with your code change. As I said before, I have tried to change >code per reviewers' comment, then let reviewers decide which way is >better. Please feel free to post formal patches and joining discussion >about this issue. Yep, while I don't have a real requirement to add the reverse version, so what is the proper way to send a patch? A patch reply to this thread is ok? > >Thanks >Baoquan >