Received: by 10.192.165.148 with SMTP id m20csp4224159imm; Tue, 8 May 2018 05:12:04 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrtBlELqXiuSFQNdidl5utsYjN+81KGtGFH0g6uC5gKj6WDvg+O0ETijgWwbMnub0Lxcbiv X-Received: by 10.98.133.15 with SMTP id u15mr39554703pfd.160.1525781524933; Tue, 08 May 2018 05:12:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525781524; cv=none; d=google.com; s=arc-20160816; b=v/dfw6paNByK9NF5TEdqCi+kmjGuBZf9jQy9GJGIgH2cM/hZ11FEHegh99fcTJjQL9 x6cZXRo6jFHBv6wsILGIsbC8oZ0rQ89g6Rn0E/K8WVEX0AJWOIDyrqIfh1PdnA+b/c99 eWRXE6KcOLr4ii4a5is5FQkQaEGdTWefWGFDjOTm+7CTIeALFqz606xS4KDyhAWCQRMX 4vVOrHgr7R8fJQh3v9EseypnnVQvLcOHhbgXKBw6drckuYmU05J2oxQe7HCB5USdHNqI SQKuud68ee6XFPjEiqSBa/3zjoFDiedch6sXuq2HjsFlzDdyLTsqi0UQGhNlGQ5SpPpt hx8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=HLe2FVVAIerf7nxqbA7s0XW/zDsrJCf5LkNQ1GS3jSo=; b=Lzbe2bOt1gMyuDJoDdh2o7IOMJnUjdFuaYr1jIAZfv+kQz4QD0BjTKWhL0hLS7i0NK pkglAAHc0whGiSoXyi0YNLuZcH4voOjl58iAlEgwseKAsCG3etxh/dcPgwTu3ZZ+JYTh 6nqrYrVU5Qq+rG5mYYkMaK57E4Q5PnOusJRlHa9WufDXkQokdHlbNyVZXWRBxjmHKd1n f+32mBjaX//WnlIV1D60YqowVI+1RHiZjuYg/skBiy9nCZ/QRNigGHOJTN6Lv6BgMvF5 2wKJ8AmgiNypSKxgF6bhTTxK201JDi1YcEMgIsYoBOCdZT0u8e2CTJgtoa0YkS3O2z8x amPw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l67si24400097pfg.326.2018.05.08.05.11.50; Tue, 08 May 2018 05:12:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754516AbeEHMLb (ORCPT + 99 others); Tue, 8 May 2018 08:11:31 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:57128 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752191AbeEHML3 (ORCPT ); Tue, 8 May 2018 08:11:29 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6E7D9EB6E5; Tue, 8 May 2018 12:11:28 +0000 (UTC) Received: from localhost (ovpn-8-16.pek2.redhat.com [10.72.8.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9B251AFD4E; Tue, 8 May 2018 12:11:26 +0000 (UTC) Date: Tue, 8 May 2018 20:11:23 +0800 From: Baoquan He To: Wei Yang Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, robh+dt@kernel.org, dan.j.williams@intel.com, nicolas.pitre@linaro.org, josh@joshtriplett.org, Patrik Jakobsson , David Airlie , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Dmitry Torokhov , Frank Rowand , Keith Busch , Jonathan Derrick , Lorenzo Pieralisi , Bjorn Helgaas , Thomas Gleixner , Brijesh Singh , =?iso-8859-1?B?Suly9G1l?= Glisse , Borislav Petkov , Tom Lendacky , Greg Kroah-Hartman , Yaowei Bai , devel@linuxdriverproject.org, linux-input@vger.kernel.org, linux-nvdimm@lists.01.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v3 1/3] resource: Use list_head to link sibling resource Message-ID: <20180508121123.GI30581@MiWiFi-R3L-srv> References: <20180419001848.3041-1-bhe@redhat.com> <20180419001848.3041-2-bhe@redhat.com> <20180426011837.GA79340@WeideMacBook-Pro.local> <20180507011429.GG30581@MiWiFi-R3L-srv> <20180508114845.GA19459@WeideMacBook-Pro.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180508114845.GA19459@WeideMacBook-Pro.local> User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Tue, 08 May 2018 12:11:28 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Tue, 08 May 2018 12:11:28 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'bhe@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/08/18 at 08:48pm, Wei Yang wrote: > On Mon, May 07, 2018 at 09:14:29AM +0800, Baoquan He wrote: > >Hi Wei Yang, > > > >On 04/26/18 at 09:18am, Wei Yang wrote: > >> On Thu, Apr 19, 2018 at 08:18:46AM +0800, Baoquan He wrote: > >> >The struct resource uses singly linked list to link siblings. It's not > >> >easy to do reverse iteration on sibling list. So replace it with list_head. > >> > > >> > >> Hi, Baoquan > >> > >> Besides changing the data structure, I have another proposal to do the reverse > >> iteration. Which means it would not affect other users, if you just want a > >> reverse iteration. > >> > >> BTW, I don't think Andrew suggest to use linked-list directly. What he wants > >> is a better solution to your first proposal in > >> https://patchwork.kernel.org/patch/10300819/. > >> > >> Below is my proposal of resource reverse iteration without changing current > >> design. > > > >I got your mail and read it, then interrupted by other thing and forgot > >replying, sorry. > > > >I am fine with your code change. As I said before, I have tried to change > >code per reviewers' comment, then let reviewers decide which way is > >better. Please feel free to post formal patches and joining discussion > >about this issue. > > Yep, while I don't have a real requirement to add the reverse version, so what > is the proper way to send a patch? > > A patch reply to this thread is ok? I am not sure either. Since my patches are still under reviewing. And you have pasted your patch. It depends on maintainers, mainly Andrew and other reviewers who have concerns.