Received: by 10.192.165.148 with SMTP id m20csp4500207imm; Tue, 8 May 2018 09:23:13 -0700 (PDT) X-Google-Smtp-Source: AB8JxZq/mhihYErA8jgcgE3utUJ/Ybghx6TTUprNVMtkalC2T2bD+SKWnpkKTu8m+UdOeXe/ypCu X-Received: by 10.98.150.150 with SMTP id s22mr40096037pfk.191.1525796593631; Tue, 08 May 2018 09:23:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525796593; cv=none; d=google.com; s=arc-20160816; b=dxwFeCKTncna+okqNgPdBxKAzSNoprYRS4LF72QVG1pwBvdn08lG5cFZ+JQwDDpyC9 PisJuthgZHHj6AEwzIbD4963t1zxzfxa+h7Mq4q12+tDMBuRG6gdBLDYOGeMN7JSlQPo LVrhu+juvMnoNgc+1T0t1R3VFgxPJZaG6GDVP5XdR0dwD2Ce7s3AamODv03v40tuwFmT iVUm/r1r5MAUiojGlwRvdM8bA44oRtABrNdHSQkHjprgNOIQsspWEVlX+eUOqGjyhfuW IXnFCZ37nTb/JWi9UDZTk1Yo+FanqtMS08eFBSXZDAuS9Df/bdtXGFK/pUuyZy5ihpHs TFJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=gNJNvCH6IWHCWnwWvsvtlzFQ8FSgTn5BUaEjmBMHFRs=; b=yRGe2l8u7fl4L4A1cmMKe2fFqGZISbCKaGaXb7x95sfVNL5WvJTV11wylkGXTICaxo RQTNNQbB/S7Fu4ib5Kg6jrmiCdi/+rvoo2pO2xfkUkf1oaNTQxakq903hvA5wodIjw52 f44Dh5oJSsBdu2zAXP5sDPvxLIkbUw8gAN7SWYkp1HHZse2ySFrPnmXBjS/FThp63Waa MbyO9HxVevV+PEda8dVpmyf377pWIQQn+rM91QuTLFUUsxRIRRqUfgD+koZ9l/WGAZe5 NWenLDN3pB8WWzSOUAbiEVlfZGTyqQHbAiJgblwNf91JUrMVDdFoxDaYAdAVMePInSzs E6ug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r5-v6si8828259pls.227.2018.05.08.09.22.58; Tue, 08 May 2018 09:23:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932773AbeEHQVz (ORCPT + 99 others); Tue, 8 May 2018 12:21:55 -0400 Received: from smtp2.provo.novell.com ([137.65.250.81]:55160 "EHLO smtp2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755527AbeEHQVy (ORCPT ); Tue, 8 May 2018 12:21:54 -0400 Received: from localhost.localdomain (prv-ext-foundry1int.gns.novell.com [137.65.251.240]) by smtp2.provo.novell.com with ESMTP (TLS encrypted); Tue, 08 May 2018 10:21:45 -0600 From: Davidlohr Bueso To: davem@davemloft.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dave@stgolabs.net, Davidlohr Bueso Subject: [PATCH 3/6] net: Update [e/in]gress_needed static key to modern api Date: Tue, 8 May 2018 09:07:00 -0700 Message-Id: <20180508160703.8125-4-dave@stgolabs.net> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180508160703.8125-1-dave@stgolabs.net> References: <20180508160703.8125-1-dave@stgolabs.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No changes in semantics -- key init is false; replace static_key_slow_inc|dec with static_branch_inc|dec static_key_false with static_branch_unlikely Added a '_key' suffix to both ingress_needed and egress_needed, for better self documentation. Signed-off-by: Davidlohr Bueso --- net/core/dev.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 019cb1fc1dde..64483afb7b90 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -1755,33 +1755,33 @@ int call_netdevice_notifiers(unsigned long val, struct net_device *dev) EXPORT_SYMBOL(call_netdevice_notifiers); #ifdef CONFIG_NET_INGRESS -static struct static_key ingress_needed __read_mostly; +static DEFINE_STATIC_KEY_FALSE(ingress_needed_key); void net_inc_ingress_queue(void) { - static_key_slow_inc(&ingress_needed); + static_branch_inc(&ingress_needed_key); } EXPORT_SYMBOL_GPL(net_inc_ingress_queue); void net_dec_ingress_queue(void) { - static_key_slow_dec(&ingress_needed); + static_branch_dec(&ingress_needed_key); } EXPORT_SYMBOL_GPL(net_dec_ingress_queue); #endif #ifdef CONFIG_NET_EGRESS -static struct static_key egress_needed __read_mostly; +static DEFINE_STATIC_KEY_FALSE(egress_needed_key); void net_inc_egress_queue(void) { - static_key_slow_inc(&egress_needed); + static_branch_inc(&egress_needed_key); } EXPORT_SYMBOL_GPL(net_inc_egress_queue); void net_dec_egress_queue(void) { - static_key_slow_dec(&egress_needed); + static_branch_dec(&egress_needed_key); } EXPORT_SYMBOL_GPL(net_dec_egress_queue); #endif @@ -3514,7 +3514,7 @@ static int __dev_queue_xmit(struct sk_buff *skb, void *accel_priv) #ifdef CONFIG_NET_CLS_ACT skb->tc_at_ingress = 0; # ifdef CONFIG_NET_EGRESS - if (static_key_false(&egress_needed)) { + if (static_branch_unlikely(&egress_needed_key)) { skb = sch_handle_egress(skb, &rc, dev); if (!skb) goto out; @@ -4548,7 +4548,7 @@ static int __netif_receive_skb_core(struct sk_buff *skb, bool pfmemalloc) skip_taps: #ifdef CONFIG_NET_INGRESS - if (static_key_false(&ingress_needed)) { + if (static_branch_unlikely(&ingress_needed_key)) { skb = sch_handle_ingress(skb, &pt_prev, &ret, orig_dev); if (!skb) goto out; -- 2.13.6