Received: by 10.192.165.148 with SMTP id m20csp4500772imm; Tue, 8 May 2018 09:23:48 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrq+NIqrotw0/8VFUcnJBjK5BQb64jUB8N2+5IRwgXe6aKQjYoD8FjFTGGfEa4zKZ6ZgDOB X-Received: by 2002:a17:902:8d8d:: with SMTP id v13-v6mr27102673plo.362.1525796628311; Tue, 08 May 2018 09:23:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525796628; cv=none; d=google.com; s=arc-20160816; b=0XT+gRfWIpTf9fEbFuLYOnQMLIXagBJQhRsqWe1Kg46HC5gZUGqe3QbBa9Lx4uwp1g MHiGbXXQ2yTXGabCzKFDv4kkzQNvQi3hH9Raxa8He8GVjM0Eut3spXECD0qTidL5Ssah CKCKPjAKTJ0YV3M1pbq4HVbaY9Hn64edLqUAPiNGPl5n7YrW+3ktJDuZhyesvBduH7DD NuNg0bpu16yqqjyhKEulND2sLbOuVGmXf8VL/0ekAYevM4m4OXg6YXJIuyNU6tS9l09S zFo7ivbtBgI0NuiH5Gmvp8vVDEGasdL5dl6+4qokhlnuI97Cr2AHTVIQkbWgeq4ipXKl HSSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=nWK2ySmkpIH7VArJMgM8UlL111r/EZ18KDPc/g0OFDU=; b=iSfDerIE8F1ATSfhYR6qLdGvcvGh/uKknO/UWBuoLLmu4zrNuD5NPoTMmvcEa+hKl8 z8nutQqMzOMcrRApGLeNmawnkHHtTYTUVkp1hixkW7nVLMOZgwkEoyANh36zPdaAbrcK cPkSiymqavcpFwY6FWHjBnc/x3NzCiaMf77AT+BY3q9X3bmR5f0ytUCYNK/q7md+fLEx F2eR0m5vEfXiY6lQFuauPz+FrxXar3SWm0PC3Jf8msGEVGm8Tp+A1ab9SjvXR0fkjIn1 G7jyrHh7X7um0IhzdnJv5XhCN8hqUdUTokAdkXXR7cnV/BpO0Rg9DzkG1+bbolClUF5o lNbg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y8si24797711pfd.47.2018.05.08.09.23.33; Tue, 08 May 2018 09:23:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933050AbeEHQW7 (ORCPT + 99 others); Tue, 8 May 2018 12:22:59 -0400 Received: from smtp2.provo.novell.com ([137.65.250.81]:43027 "EHLO smtp2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755501AbeEHQVy (ORCPT ); Tue, 8 May 2018 12:21:54 -0400 Received: from localhost.localdomain (prv-ext-foundry1int.gns.novell.com [137.65.251.240]) by smtp2.provo.novell.com with ESMTP (TLS encrypted); Tue, 08 May 2018 10:21:43 -0600 From: Davidlohr Bueso To: davem@davemloft.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dave@stgolabs.net, Davidlohr Bueso Subject: [PATCH 2/6] net/sock: Update memalloc_socks static key to modern api Date: Tue, 8 May 2018 09:06:59 -0700 Message-Id: <20180508160703.8125-3-dave@stgolabs.net> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180508160703.8125-1-dave@stgolabs.net> References: <20180508160703.8125-1-dave@stgolabs.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No changes in refcount semantics -- key init is false; replace static_key_slow_inc|dec with static_branch_inc|dec static_key_false with static_branch_unlikely Added a '_key' suffix to memalloc_socks, for better self documentation. Signed-off-by: Davidlohr Bueso --- include/net/sock.h | 4 ++-- net/core/sock.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/net/sock.h b/include/net/sock.h index 3c568b36ee36..4f7c584e9765 100644 --- a/include/net/sock.h +++ b/include/net/sock.h @@ -808,10 +808,10 @@ static inline bool sock_flag(const struct sock *sk, enum sock_flags flag) } #ifdef CONFIG_NET -extern struct static_key memalloc_socks; +DECLARE_STATIC_KEY_FALSE(memalloc_socks_key); static inline int sk_memalloc_socks(void) { - return static_key_false(&memalloc_socks); + return static_branch_unlikely(&memalloc_socks_key); } #else diff --git a/net/core/sock.c b/net/core/sock.c index e7d8b6c955c6..042cfc612660 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -327,8 +327,8 @@ EXPORT_SYMBOL(sysctl_optmem_max); int sysctl_tstamp_allow_data __read_mostly = 1; -struct static_key memalloc_socks = STATIC_KEY_INIT_FALSE; -EXPORT_SYMBOL_GPL(memalloc_socks); +DEFINE_STATIC_KEY_FALSE(memalloc_socks_key); +EXPORT_SYMBOL_GPL(memalloc_socks_key); /** * sk_set_memalloc - sets %SOCK_MEMALLOC @@ -342,7 +342,7 @@ void sk_set_memalloc(struct sock *sk) { sock_set_flag(sk, SOCK_MEMALLOC); sk->sk_allocation |= __GFP_MEMALLOC; - static_key_slow_inc(&memalloc_socks); + static_branch_inc(&memalloc_socks_key); } EXPORT_SYMBOL_GPL(sk_set_memalloc); @@ -350,7 +350,7 @@ void sk_clear_memalloc(struct sock *sk) { sock_reset_flag(sk, SOCK_MEMALLOC); sk->sk_allocation &= ~__GFP_MEMALLOC; - static_key_slow_dec(&memalloc_socks); + static_branch_dec(&memalloc_socks_key); /* * SOCK_MEMALLOC is allowed to ignore rmem limits to ensure forward -- 2.13.6