Received: by 10.192.165.148 with SMTP id m20csp4511100imm; Tue, 8 May 2018 09:33:12 -0700 (PDT) X-Google-Smtp-Source: AB8JxZp8e/yu192fmqaPsqrdjtRmP2Ihoaj5NdiHDjybWFstyYm4siTU8a/EdMxK5D0rdwADUTBZ X-Received: by 10.98.193.3 with SMTP id i3mr3227212pfg.148.1525797192750; Tue, 08 May 2018 09:33:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525797192; cv=none; d=google.com; s=arc-20160816; b=jLrwndmUaWFPzY7JmgqdVQg0UQUiXJCBm34TAfe1NGmoB5NxZVjgGToVTFcsRL6d/A yNNr5ZHUwAEu5Mg4vS2IhPcMMuE72mLQo2ow5zvI4BqUJTKwfFTRppZKKv3iYLaFNahB ICFXjH3dZYM7hwGGGFq1eEHgLEzr1oKU4dT2LrU27HIUQWQlXD+/TnNRiM7eht3bWewJ IhxE3oZDdQuzmULUrDtpsdkkMjagIFjc8zH1fYmGUdykxFaSVlr/J2oXZdF51y4+4980 +vHkqRgPYIw1h0MpnFqwWVkbj6xaLgP/Kbpyh6gNZTPS4lI0pyOjBcYawmePVUKyTJZD q6zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=v9AxrmOi1qUhZAPJPlgvxyurP0Nc/P7UtHT6sAo/sNk=; b=Ix4bnfSU4I6FJiEA7znQ8YiDdVykb6Q+JLkwFMovH38L+Z1n1S4D+cSlq2UizPrF5q 3Auj/zj+YGxKZ2sak67iy4T5vptMQWXz6Ffv7g5xBtiOkOvoC0xiG6Q7bvps2IXihXKO g3CbXR30NP7Y+uCA+rxw6MvZJJxjRcDgCbb2tu/VGuxmV4BwcfJ8f/KmHJgkAI50qmhe qPQQDaQkKR7WZ8uKAzQe92+9es7LGhWlJxihNB329+KTpBcS+qVxnGYH+4GVpm0IkMk2 o0bTIMbVr/VJJ2leVzvsrBmzbAh3cqM9yut6vj7OwgVP0YQGXv+kFE+2HhUa+pdjnpKd F9KQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MiBrgFjN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q16-v6si12660675pgc.635.2018.05.08.09.32.58; Tue, 08 May 2018 09:33:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MiBrgFjN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933131AbeEHQa7 (ORCPT + 99 others); Tue, 8 May 2018 12:30:59 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:33831 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932584AbeEHQa5 (ORCPT ); Tue, 8 May 2018 12:30:57 -0400 Received: by mail-pf0-f196.google.com with SMTP id a14so24234870pfi.1 for ; Tue, 08 May 2018 09:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=v9AxrmOi1qUhZAPJPlgvxyurP0Nc/P7UtHT6sAo/sNk=; b=MiBrgFjN4520lFey8+owL0tTZ1wdoTszGoGu+Lf5O8oCPaXXH7qmBp+5xEoR6WSH8r afAhYJ/Vw6E2QquOAKwHkxKP8cFZOX8UYl9zPCmnrCgkvu+NjxywgfgdybXkBPak8bHe xFASb0m6NlCPK/mfT6U6UE/mK5jn2bKehOz8IJvLU7zca4KIRLHMI095yV9TXnIBkdcS LVGBBsgvyMCMrF8ut8au2Pa/Oca2Iuakx4LNpZH3V6+cVeOTAwAk0NMWD6eM/sbbNz6p uDarWKyOjRHVtI8nfJgo+6YjsWd1Byt4dI5rAg1ziUswGF6pCGX79fjTANqhdPqUe+c8 cP1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=v9AxrmOi1qUhZAPJPlgvxyurP0Nc/P7UtHT6sAo/sNk=; b=SXMkZzpD1e+r49LPXtayEW+8D6uMCiDf2Jn2LDAcvtYylBI6A2giOSGIgyQdoFIgvR Whn3vcfWQcO0SVvoloYq3qMqL2HuL0d7Tf4+lXHZwzlzFv/jxTtmrflGpRKHtr4pcrx1 kva9h36SWakLam6diVfbZy9pOtyhz9QbVkajpUkx5+UA9ag7QNnli/KQomjJsRzOInyY lAD1MbYEBKXoia8e7l34ATUTAu7FQv2PshcE7McKD6i2skvPKEd0tAuiDbwTFFYAtig2 c9AxRAZ74Wntl0s3VBCyXiFRLz72xjQ9ynD245i8EyjcRgDlQuHok+pSUkbTni1FwHjG 0OGg== X-Gm-Message-State: ALQs6tBPTTGOIAXyc+sqMWaXyb44QfO2mV8xtAx4oq+CRcSm3qHyeIP+ ci8VwK0D18rkoFBkJxd9ZlBhunCY6ak= X-Received: by 2002:a63:5ec5:: with SMTP id s188-v6mr33220011pgb.21.1525797057225; Tue, 08 May 2018 09:30:57 -0700 (PDT) Received: from nihaal-Latitude-E6410 ([157.51.164.9]) by smtp.gmail.com with ESMTPSA id x5-v6sm34582809pgv.15.2018.05.08.09.30.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 May 2018 09:30:56 -0700 (PDT) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: christian.gromm@microchip.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Abdun Nihaal Subject: [PATCH] staging: most: video: remove debugging code Date: Tue, 8 May 2018 22:00:40 +0530 Message-Id: <20180508163040.27616-1-abdun.nihaal@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch removes debugging code in video.c that causes the following checkpatch warning: WARNING: Prefer using '\"%s...\", __func__' to using function's name in a string Signed-off-by: Abdun Nihaal --- drivers/staging/most/video/video.c | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c index 9d7e747519d9..fc374711fcc0 100644 --- a/drivers/staging/most/video/video.c +++ b/drivers/staging/most/video/video.c @@ -73,8 +73,6 @@ static int comp_vdev_open(struct file *filp) struct most_video_dev *mdev = video_drvdata(filp); struct comp_fh *fh; - v4l2_info(&mdev->v4l2_dev, "comp_vdev_open()\n"); - switch (vdev->vfl_type) { case VFL_TYPE_GRABBER: break; @@ -122,8 +120,6 @@ static int comp_vdev_close(struct file *filp) struct most_video_dev *mdev = fh->mdev; struct mbo *mbo, *tmp; - v4l2_info(&mdev->v4l2_dev, "comp_vdev_close()\n"); - /* * We need to put MBOs back before we call most_stop_channel() * to deallocate MBOs. @@ -250,8 +246,6 @@ static int vidioc_querycap(struct file *file, void *priv, struct comp_fh *fh = priv; struct most_video_dev *mdev = fh->mdev; - v4l2_info(&mdev->v4l2_dev, "vidioc_querycap()\n"); - strlcpy(cap->driver, "v4l2_component", sizeof(cap->driver)); strlcpy(cap->card, "MOST", sizeof(cap->card)); snprintf(cap->bus_info, sizeof(cap->bus_info), @@ -270,8 +264,6 @@ static int vidioc_enum_fmt_vid_cap(struct file *file, void *priv, struct comp_fh *fh = priv; struct most_video_dev *mdev = fh->mdev; - v4l2_info(&mdev->v4l2_dev, "vidioc_enum_fmt_vid_cap() %d\n", f->index); - if (f->index) return -EINVAL; @@ -289,8 +281,6 @@ static int vidioc_g_fmt_vid_cap(struct file *file, void *priv, struct comp_fh *fh = priv; struct most_video_dev *mdev = fh->mdev; - v4l2_info(&mdev->v4l2_dev, "vidioc_g_fmt_vid_cap()\n"); - comp_set_format_struct(f); return 0; } @@ -318,8 +308,6 @@ static int vidioc_g_std(struct file *file, void *priv, v4l2_std_id *norm) struct comp_fh *fh = priv; struct most_video_dev *mdev = fh->mdev; - v4l2_info(&mdev->v4l2_dev, "vidioc_g_std()\n"); - *norm = V4L2_STD_UNKNOWN; return 0; } @@ -355,8 +343,6 @@ static int vidioc_s_input(struct file *file, void *priv, unsigned int index) struct comp_fh *fh = priv; struct most_video_dev *mdev = fh->mdev; - v4l2_info(&mdev->v4l2_dev, "vidioc_s_input(%d)\n", index); - if (index >= V4L2_CMP_MAX_INPUT) return -EINVAL; mdev->ctrl_input = index; @@ -435,8 +421,6 @@ static int comp_register_videodev(struct most_video_dev *mdev) { int ret; - v4l2_info(&mdev->v4l2_dev, "comp_register_videodev()\n"); - init_waitqueue_head(&mdev->wait_data); /* allocate and fill v4l2 video struct */ @@ -465,8 +449,6 @@ static int comp_register_videodev(struct most_video_dev *mdev) static void comp_unregister_videodev(struct most_video_dev *mdev) { - v4l2_info(&mdev->v4l2_dev, "comp_unregister_videodev()\n"); - video_unregister_device(mdev->vdev); } @@ -485,8 +467,6 @@ static int comp_probe_channel(struct most_interface *iface, int channel_idx, int ret; struct most_video_dev *mdev = get_comp_dev(iface, channel_idx); - pr_info("comp_probe_channel(%s)\n", name); - if (mdev) { pr_err("channel already linked\n"); return -EEXIST; @@ -531,7 +511,6 @@ static int comp_probe_channel(struct most_interface *iface, int channel_idx, spin_lock_irq(&list_lock); list_add(&mdev->list, &video_devices); spin_unlock_irq(&list_lock); - v4l2_info(&mdev->v4l2_dev, "comp_probe_channel() done\n"); return 0; err_unreg: @@ -550,8 +529,6 @@ static int comp_disconnect_channel(struct most_interface *iface, return -ENOENT; } - v4l2_info(&mdev->v4l2_dev, "comp_disconnect_channel()\n"); - spin_lock_irq(&list_lock); list_del(&mdev->list); spin_unlock_irq(&list_lock); -- 2.17.0