Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180508145611.49072-4-giulio.benetti@micronovasrl.com>
References: <20180508145611.49072-1-giulio.benetti@micronovasrl.com> <20180508145611.49072-4-giulio.benetti@micronovasrl.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Tue, 8 May 2018 12:44:12 -0500
Message-ID: <CAL_JsqKb9aLxjQbOc1PFRQhbVL2a3Ti2oJ8Gm8Ojn0a39LxajA@mail.gmail.com>
Subject: Re: [PATCH 4/4] rtc: ds1307: add frequency-test property to check
 calibration on m41txx
To:     Giulio Benetti <giulio.benetti@micronovasrl.com>
Cc:     Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Mark Rutland <mark.rutland@arm.com>,
        "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" 
        <linux-rtc@vger.kernel.org>, devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, May 8, 2018 at 9:56 AM, Giulio Benetti
<giulio.benetti@micronovasrl.com> wrote:
> On m41txx you can enable open-drain OUT pin to check if calibration is ok.
> Enabling OUT pin with frequency-test bool property, OUT pin will tick
> 512 times faster than 1s tick base.
>
> Enable FT bit on CONTROL register if calibration is active.

A DT is (or should be) a pretty static thing, so I don't think this
belongs. A kernel command line option (via module params) or a
sysfs/debugfs file would make more sense IMO.

Rob