Received: by 10.192.165.148 with SMTP id m20csp4686785imm; Tue, 8 May 2018 12:31:34 -0700 (PDT) X-Google-Smtp-Source: AB8JxZonEwy97a8cIYW78e6rLa4cPZd1NLeuoS7O4Ek1TFzkGK7uJE7LnjrLk1ZQv8A7j5k7YU2u X-Received: by 2002:a65:6301:: with SMTP id g1-v6mr34086083pgv.307.1525807894134; Tue, 08 May 2018 12:31:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525807894; cv=none; d=google.com; s=arc-20160816; b=KHJZkqVaAFgAv5zSCQ3ta/4YaY8Emwetg137eVucniqM0p4xffcuPLcSozUV8dJVWb lPKQdIwqnA7WAglBBcl8S0VMvSwi/PLxOkPbPSYAyCsp69OLRHK7QhP+6UuaLbYTZtjW 5znhM/lriMQUJJ2Pv5VZmKfb/S4TuFu9xoJysOfRLKdooUnjQGaCpgZRLRsq0FgwiBnW j+/f2/IGnmHoGS4MZMY9jRqFnT9IGybtlYREYdGKMLlEhPlE5E1lIguW92WLm7Zwl2lD eHW6bkDzRMvDKELqT1gNTjqqhblHgSnXwkjcQqgQ0uAtK+td1Gqr3gSBzpiRmtxwOCkf 9Lag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=Z5jTOfD0FfZw/KBahVDyYRy7Th0avOVtmAp5e1QnJz8=; b=PAVAzDGkDE/jsSwqo7EofJw5MoAgDwqNvdYPabshRxw9LPQvEMV1nXS/sJTh9rJ0hD MX/0cPeoCDtGlK9y6lnnfOSwwoMIfDQrG6XJ+jAnMufCqCX2xCvVQH+woNddGJ/WFHke q89ObeqYvLvRbKtjz5N4PHZzJIa9lEi0zjAsHYlDxMU9RnqE4mXvLUCfbNIY5n0cUEqp JQx0Wu0/ul2aXCokij/GCgTpzErXZ/Np8MZ3T1WB2WbjNg/Q6oYZBZdoi8n3JtkhL/3N gsskKfcfC9hbyFnJV4o7zegPuF0D7byZryWdtEvgFKrshWkWSmJEQb3ijBUUfc6YONq9 rVhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Z+KOEbJE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a23si6171133pfe.364.2018.05.08.12.31.19; Tue, 08 May 2018 12:31:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Z+KOEbJE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755413AbeEHTZg (ORCPT + 99 others); Tue, 8 May 2018 15:25:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:37576 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751579AbeEHTZf (ORCPT ); Tue, 8 May 2018 15:25:35 -0400 Received: from localhost (unknown [69.71.5.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 94BDF2183D; Tue, 8 May 2018 19:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1525807534; bh=Wmz6nwFuwq3af2s1XU1ZVPv27ojwb/E7ayHo8zj0TvE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z+KOEbJEN5jT8pzcI6Xt44xJIzH69rS3cedwHFiJ0XWSfv+2BWKkViws3le4T013V mNd7OKQx5YWpUvpflBkxkDEnBdAtNq8HFxZEo1URWmt7bXY0lCuYXCZlyOcnfZVWZ+ 3HckSw+l09tmPU3EP6MBLnNoiapSRSJpKMZ1Pnwg= Date: Tue, 8 May 2018 14:25:32 -0500 From: Bjorn Helgaas To: Keith Busch Cc: Sinan Kaya , Oza Pawandeep , Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Wei Zhang , Timur Tabi , Alex Williamson Subject: Re: [PATCH v12 0/6] Address error and recovery for AER and DPC Message-ID: <20180508192532.GA79697@bhelgaas-glaptop.roam.corp.google.com> References: <1519837457-3596-1-git-send-email-poza@codeaurora.org> <20180311220337.GA194000@bhelgaas-glaptop.roam.corp.google.com> <04ade52e-d1ea-fe67-bb26-246621d159e6@codeaurora.org> <20180312142551.GB18494@localhost.localdomain> <20180312194236.GA12195@bhelgaas-glaptop.roam.corp.google.com> <20180312232626.GI18494@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180312232626.GI18494@localhost.localdomain> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 12, 2018 at 05:26:26PM -0600, Keith Busch wrote: > On Mon, Mar 12, 2018 at 02:47:30PM -0500, Bjorn Helgaas wrote: > > On Mon, Mar 12, 2018 at 08:25:51AM -0600, Keith Busch wrote: > > > Per spec, DPC is the recommended way for handling surprise removal > > > events and even recommends DPC capable slots *not* set 'Surprise' > > > in Slot Capabilities so that removals are always handled by DPC. This > > > service driver was developed with that use in mind. > > > > Thanks for this tip. The only thing I've found so far is the mention > > of Surprise Down triggering DPC in the last paragraph of sec 6.7.5. > > Are there other references I should look at? I haven't found the > > recommendation about not setting 'Surprise' in Slot Capabilities yet. > > No problem, it's in the "IMPLEMENTATION NOTE" at the end of 6.2.10.4, > "Avoid Disabled Link and Hot-Plug Surprise Use with DPC". > > Outside the spec, Microsemi as one of the PCI-SIG contributors and early > adopters of the capability published a white paper "Hot and Surprise > Plug Recommendations for Enterprise PCIe" providing guidance for OS > drivers using DPC. We originally developed to that guidance. The paper > unfortunately appears to be pay-walled now. :( Any chance you have a URL or contact info for this pay-walled white paper? Sounds like it might have useful information in it.