Received: by 10.192.165.148 with SMTP id m20csp4907822imm; Tue, 8 May 2018 17:15:09 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpc99KvzpOyaxPIsd/HDv87Z7pUBrq8KDJ88003KF+O535bDzLyD4XBxSIFJzQsHRqNNZu9 X-Received: by 2002:a63:65c4:: with SMTP id z187-v6mr26203728pgb.180.1525824908956; Tue, 08 May 2018 17:15:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525824908; cv=none; d=google.com; s=arc-20160816; b=u4WgyoRRYUHg94C0CVSTxpMLpTNVcB6RgZfEpl58+1ZftS6f+xlrMiNELOvSwuD7+J EpZyTH7ntwmPMkIQDyz6q51QgLCug9CgFp3twoieyq/JWLh5SiK+tG6b++2L4QAwuLNU I5dtq0lvHFPpKJdAiiGXoCTzjDfn69c0Q9WizFuaOfpbTtdvjCj2VZ1QnTvSEt+nFZXF lXFosM+ESPEaGfpvrjCvUwcxTHn38zlet1C14/SpLXfWnbgvQI3M/UfZ/AbY/L9+LLQd aPHXt2XgwCpy37oUdi3da4sfKMFhH9MLWW6JNG6UYRWbnNf6Kbem6dzBjz1egc/sFXbN hSOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=Mudm/GKY8vwJDr+Npjp7cMrA66aTMnTb3kZFny8jvkc=; b=cI/B6ggsH5MxLgeav/puDB4PhMmMIRLEZAzMPaOmM6cdVoWSli5b8313H2YwkUiIm9 SZTXhrbawaXe4uGD8ZS3HMPoGQjDRhFq4CMjxHcVCyr0eXlv/7aYBDz41Syf5dpWXMXd 6KbzvFQQF939Baf7FeVj2rCNF8rxly5CXpt7rjWvxDpxdtEv4XPV+PKy55vabFGVKWA7 DFfc6Vp9RdAOmYX2yfqXXsalfQJMgCu6d6AORRhXANHg0tjZsf1K9WXDSpa+teQdcPUE RQvvmBrj62yvUnVHd0Y8rYGMOn3bkAmUqXTksKEGRG5cJbAY/kqt4HlPc+jHInwAyCu8 6SEA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s16-v6si23982745plp.487.2018.05.08.17.14.54; Tue, 08 May 2018 17:15:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933305AbeEIAO2 (ORCPT + 99 others); Tue, 8 May 2018 20:14:28 -0400 Received: from anholt.net ([50.246.234.109]:53694 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933175AbeEIAO1 (ORCPT ); Tue, 8 May 2018 20:14:27 -0400 Received: from localhost (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id BB52110A0F6B; Tue, 8 May 2018 17:14:26 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at anholt.net Received: from anholt.net ([127.0.0.1]) by localhost (kingsolver.anholt.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Zzy-NzhAk2wq; Tue, 8 May 2018 17:14:25 -0700 (PDT) Received: from eliezer.anholt.net (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 8311B10A01F0; Tue, 8 May 2018 17:14:25 -0700 (PDT) Received: by eliezer.anholt.net (Postfix, from userid 1000) id 0AFD42FE2D89; Tue, 8 May 2018 17:14:25 -0700 (PDT) From: Eric Anholt To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Eric Anholt , Daniel Vetter , Sean Paul Subject: [PATCH] drm: Fix render node numbering regression from control node removal. Date: Tue, 8 May 2018 17:14:25 -0700 Message-Id: <20180509001425.12574-1-eric@anholt.net> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org drm_minor_alloc() does multiplication on this enum, so the removal ended up moving render nodes down from 128 base to 64. This caused Mesa's surfaceless backend to be unable to open the render nodes, since it was still looking up at 128. Signed-off-by: Eric Anholt Fixes: 0d49f303e8a7 ("drm: remove all control node code") Cc: Daniel Vetter Cc: Sean Paul --- include/drm/drm_file.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h index 99ab50cbab00..69b0a8b57502 100644 --- a/include/drm/drm_file.h +++ b/include/drm/drm_file.h @@ -49,6 +49,7 @@ struct device; enum drm_minor_type { DRM_MINOR_PRIMARY, + DRM_MINOR_CONTROL, DRM_MINOR_RENDER, }; -- 2.17.0