Received: by 10.192.165.148 with SMTP id m20csp4973299imm; Tue, 8 May 2018 18:57:53 -0700 (PDT) X-Google-Smtp-Source: AB8JxZp981+f2HPo6dJ63oAFGufje65dk7pnYOynJ51U8qkXb389n01FN++lbb8LT6GohAQgDDTv X-Received: by 2002:a17:902:24a5:: with SMTP id w34-v6mr44122545pla.328.1525831073054; Tue, 08 May 2018 18:57:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525831073; cv=none; d=google.com; s=arc-20160816; b=k9PBBHsimBIsR29VBZIRkgAlUhh22iY5RYppz0mxZ5hwaH3ho3qEoL6z5JKnDZggqM K8dPdTzpUclFzkMpQ74vwS8slV4Zk0JJM7tM5Hbnx4Q92eg6Ek/sa5Gp8hd+rdYoxPG4 M7zcWuDrxl3wtHiDxC4NSsrd2gL9KIgmvk4mhDLoI8/+lQ38pdJefRRY4DLHUNgJTouF Z4URx2xjCbG4JCRHkZ1fajf52thn/zWwFy5apXe2gX446Yh9ZfGr1E9yoQyNn7gf9AeF Wef/q+asciN5KEUslVZR+H25py5wgvHQcpBqg65oxiq0FNkoPLgdKyEHKLDUWo/z0TBF GlvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:arc-authentication-results; bh=rHZCvQdJnZ/dG+2KSk+ilPKjjTAQOSKUdy7Iunho8b4=; b=B1LXvk8Pp42qOI/OpdGYbfXJa5uF7D627fZtKQG/1q0YHWggl/pW4e8I/pK3rCM6zH mtj9Va2MaEOa6Voztcp4KWTdU+HwIsw/4Cvc6lBNhyjqZicVDmhHX0KvmJLSfA6isQr2 DMGrMmNA5yyFLNnyRgZmvpaW1rQv+MONE4IWnH/dxeUMN1A2EQCCD04jsfY/CnYE9Crf 1ns5YHRQss6OovvAPRcicY1p75yrxArYRsu6GCmpnKWjUyMdIOQhasIvySreK3RZE8fW wIklSMNTA8P/tEbnniYrNhHUBncnAEhG5ww3rHNxbp1vGbxLkNsAdfOPqUtubrQ+PHKS LChA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w73si20951257pfd.19.2018.05.08.18.57.38; Tue, 08 May 2018 18:57:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933499AbeEIB5K (ORCPT + 99 others); Tue, 8 May 2018 21:57:10 -0400 Received: from ozlabs.org ([203.11.71.1]:55427 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933185AbeEIB5J (ORCPT ); Tue, 8 May 2018 21:57:09 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 40gfcN3Nngz9s1w; Wed, 9 May 2018 11:57:08 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au From: Michael Ellerman To: Dave Hansen , linuxram@us.ibm.com Cc: mingo@redhat.com, linuxppc-dev@ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 8/8] mm/pkeys, x86, powerpc: Display pkey in smaps if arch supports pkeys In-Reply-To: References: <20180508145948.9492-1-mpe@ellerman.id.au> <20180508145948.9492-9-mpe@ellerman.id.au> Date: Wed, 09 May 2018 11:57:08 +1000 Message-ID: <87lgctzj4b.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dave Hansen writes: > On 05/08/2018 07:59 AM, Michael Ellerman wrote: >> Currently the architecture specific code is expected to display the >> protection keys in smap for a given vma. This can lead to redundant >> code and possibly to divergent formats in which the key gets >> displayed. >> >> This patch changes the implementation. It displays the pkey only if >> the architecture support pkeys, i.e arch_pkeys_enabled() returns true. > > > For this, along with 6/8 and 7/8: > > Reviewed-by: Dave Hansen Thanks for reviewing them all. cheers