Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263459AbTH0PVO (ORCPT ); Wed, 27 Aug 2003 11:21:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263453AbTH0PVO (ORCPT ); Wed, 27 Aug 2003 11:21:14 -0400 Received: from mail.gondor.com ([212.117.64.182]:2321 "EHLO moria.gondor.com") by vger.kernel.org with ESMTP id S263459AbTH0PVA (ORCPT ); Wed, 27 Aug 2003 11:21:00 -0400 Date: Wed, 27 Aug 2003 17:20:52 +0200 From: Jan Niehusmann To: Alan Cox Cc: Bartlomiej Zolnierkiewicz , Marcelo Tosatti , Linux Kernel Mailing List Subject: Re: Promise IDE patches Message-ID: <20030827152052.GB25198@gondor.com> References: <20030826223158.GA25047@gondor.com> <200308270054.27375.bzolnier@elka.pw.edu.pl> <1061996391.22825.39.camel@dhcp23.swansea.linux.org.uk> <20030827151227.GA25198@gondor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030827151227.GA25198@gondor.com> X-Request-PGP: http://gondor.com/key.asc User-Agent: Mutt/1.5.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 618 Lines: 15 On Wed, Aug 27, 2003 at 05:12:27PM +0200, Jan Niehusmann wrote: > What do you think about a check in __ide_do_rw_disk? calling > lba_28_rw_disk or chs_rw_disk when the block address doesn't fit in > 28bit is surely wrong and should return an error. Sorry - I didn't notice that this straight forward distinction is only possible in the CONFIG_IDE_TASKFILE_IO case. Jan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/