Received: by 10.192.165.148 with SMTP id m20csp5159027imm; Tue, 8 May 2018 23:47:23 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpnVM/eeVKs307z8p8SzrsSX/09I3xe0GzGDbRMcybLGT1g7mTRWK929gnRK63N2eG7EafR X-Received: by 2002:a65:5002:: with SMTP id f2-v6mr6175033pgo.232.1525848443631; Tue, 08 May 2018 23:47:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525848443; cv=none; d=google.com; s=arc-20160816; b=zeg/DHUHQukCdphdB8VgSmLM9Lr43tJisK3FEBa8q7/ND4NCpG3h68gRobuhIZguxc vR3Bgxs/WM+m9CfxkBieEpvZYkVvT5TWjHbUdzB1ya8Pk/mOTs7sigetj9cXxZ5ifglt F6k7TM/8I8g/FX60KUSbXBvegy/YigZ4GbO60+xUpwkX59zYWe1IsuxofoiAxRYrQukS HmzPMdnS2TzWHZVYbdVR1uexSjoYoRYtmtGm2gEd2ux5sYFSTXlxnOPlPPrk8iguPuhE 6CmE9QTpgqgjID0tXjOLWoc365rnxLpZivJVGEDBYJEgmxFe2S3BNOT+ebW4CqAJTU/K y+Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version:dkim-signature:dkim-signature :arc-authentication-results; bh=kCNHEbqwdeJJcMY1RZ/0wo1Pv6ZAxQ8NVuuljRreVT0=; b=raT0dqgW2FYmFLS3rPfxnfulSvu0DtK8FYjm5cDaqcpnOJFXf9lq0R/NFbzPwVyvLM wsCsPIwCIcFqMHnxgWdBbKRZbbc16ZOxLlBOraWu/02rqDMW6exFfsDl4ALLKcOBIRsW qUfd/D4s19Mnhk5KXECWiSF6sLGDL8hDoPOtmvROGWp4LPv6Lz44ytlRhyFnCFIEv5xL iqvFvvuKoVbsT/gH0iU7vAuOwz145M1xe8E2TyUpONxGaZY5P/8ik5Z/n8u536i27iZe cJI3CT7ey4QCa+dE+YUWxlsG4aBC9fjgjmpk6OD51PDieTWkEK++yKTEdrvzZo4EIQoy 2k1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=o5QyM85N; dkim=pass header.i=@codeaurora.org header.s=default header.b=eup8BpD8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p1si17768644pfe.158.2018.05.08.23.47.09; Tue, 08 May 2018 23:47:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=o5QyM85N; dkim=pass header.i=@codeaurora.org header.s=default header.b=eup8BpD8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756206AbeEIGqW (ORCPT + 99 others); Wed, 9 May 2018 02:46:22 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:45982 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755360AbeEIGqQ (ORCPT ); Wed, 9 May 2018 02:46:16 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 6FC5D601D9; Wed, 9 May 2018 06:46:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1525848376; bh=wiZ+NrM8vGjkeI9niIY99HG+Vdtr6sEqgfBppElVSNs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=o5QyM85N4ZNHIKH7hjvC5SD3R8FwImOdfa+mKaA9SqAU6xreNvrUi1Nu6RMAUnhLB LcaQr/snXhGkcGs1/+u2NNXKpWsd8VqKJ7Z1n09iK6EF0POVs5zbLj9pdwF9dL9oiS Pxu1GQRIc2qPLUW2O8dS8y/h2O00taC+sQ79VuD0= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id E459E601D9; Wed, 9 May 2018 06:46:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1525848375; bh=wiZ+NrM8vGjkeI9niIY99HG+Vdtr6sEqgfBppElVSNs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eup8BpD8p0rpGwsIWK0zm9bt7215eDR7tmnAbZQj0wY/r8fLzqp3AYHcVCFeUK4L8 mLtzsmmZYxBe+Lznm9wEhp9Mxu5VqdFirTsQojGjGwQ4i+mGOu2XWJ5mZTBfmyQETI W84EHs4jMuzKtYIyrXPq+aNLlgYOEFmWBOSvLD9E= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 09 May 2018 07:46:14 +0100 From: okaya@codeaurora.org To: Rajat Jain Cc: Bjorn Helgaas , Keith Busch , Vidya Sagar , Philippe Ombredanne , Kees Cook , "Gustavo A. R. Silva" , Ard Biesheuvel , Frederick Lawler , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, mayurkumar.patel@intel.com, rajatxjain@gmail.com Subject: Re: [PATCH] pci/aspm: Remove CONFIG_PCIEASPM_DEBUG In-Reply-To: <20180508230148.121852-1-rajatja@google.com> References: <20180508230148.121852-1-rajatja@google.com> Message-ID: <7cdf5fb27cc7650523892389db76e12d@codeaurora.org> X-Sender: okaya@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-05-09 00:01, Rajat Jain wrote: > Currently, the linux kernel disables ASPM when a device is > removed from the kernel. But it is not enabled again when > a new device is added on that slot even if it was originally > enabled (by the BIOS) when the system booted up (assuming > POLICY_DEFAULT). > > This was earlier discussed here: > https://www.spinics.net/lists/linux-pci/msg60212.html > > And some suggestions from Bjorn here: > https://www.spinics.net/lists/linux-pci/msg60541.html > > This patch picks up one of the suggestion, to remove the > CONFIG_PCIEASPM_DEBUG and thus make the code always > avilable. This provides control to userspace to control > ASPM on a per slot / device basis using sysfs interface. > > Signed-off-by: Rajat Jain Reviewed-by: Sinan Kaya > --- > drivers/pci/pci.h | 5 ----- > drivers/pci/pcie/Kconfig | 8 -------- > drivers/pci/pcie/aspm.c | 2 -- > 3 files changed, 15 deletions(-) > > diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h > index 023f7cf25bff..383d92a6b0fb 100644 > --- a/drivers/pci/pci.h > +++ b/drivers/pci/pci.h > @@ -365,13 +365,8 @@ static inline void > pcie_aspm_pm_state_change(struct pci_dev *pdev) { } > static inline void pcie_aspm_powersave_config_link(struct pci_dev > *pdev) { } > #endif > > -#ifdef CONFIG_PCIEASPM_DEBUG > void pcie_aspm_create_sysfs_dev_files(struct pci_dev *pdev); > void pcie_aspm_remove_sysfs_dev_files(struct pci_dev *pdev); > -#else > -static inline void pcie_aspm_create_sysfs_dev_files(struct pci_dev > *pdev) { } > -static inline void pcie_aspm_remove_sysfs_dev_files(struct pci_dev > *pdev) { } > -#endif > > #ifdef CONFIG_PCIE_PTM > void pci_ptm_init(struct pci_dev *dev); > diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig > index b12e28b3d8f9..089b9f559d88 100644 > --- a/drivers/pci/pcie/Kconfig > +++ b/drivers/pci/pcie/Kconfig > @@ -46,14 +46,6 @@ config PCIEASPM > > When in doubt, say Y. > > -config PCIEASPM_DEBUG > - bool "Debug PCI Express ASPM" > - depends on PCIEASPM > - default n > - help > - This enables PCI Express ASPM debug support. It will add per-device > - interface to control ASPM. > - > choice > prompt "Default ASPM policy" > default PCIEASPM_DEFAULT > diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c > index c687c817b47d..8ffc13d42baa 100644 > --- a/drivers/pci/pcie/aspm.c > +++ b/drivers/pci/pcie/aspm.c > @@ -1161,7 +1161,6 @@ static int pcie_aspm_get_policy(char *buffer, > const struct kernel_param *kp) > module_param_call(policy, pcie_aspm_set_policy, pcie_aspm_get_policy, > NULL, 0644); > > -#ifdef CONFIG_PCIEASPM_DEBUG > static ssize_t link_state_show(struct device *dev, > struct device_attribute *attr, > char *buf) > @@ -1264,7 +1263,6 @@ void pcie_aspm_remove_sysfs_dev_files(struct > pci_dev *pdev) > sysfs_remove_file_from_group(&pdev->dev.kobj, > &dev_attr_clk_ctl.attr, power_group); > } > -#endif > > static int __init pcie_aspm_disable(char *str) > {