Received: by 10.192.165.148 with SMTP id m20csp5218829imm; Wed, 9 May 2018 01:08:47 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpKep04utXRUODNeVO5t/fYQknIya+iX7+xYC5PTBpBs/Hv63jwAYTMkwJtT1PsQi56CSIV X-Received: by 2002:a65:4784:: with SMTP id e4-v6mr34596982pgs.196.1525853327893; Wed, 09 May 2018 01:08:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525853327; cv=none; d=google.com; s=arc-20160816; b=TnPVFWbOokPGk/46fMRwQdB/8LolD67zm1hbW35VQGhYTW8ed/goS3EnY85xaruYow uWtlm3/aqjInqkBxHKLGILParWGF7twqXbxCVSfbgOQmx7F5+BnM+F//lLGH+uX0xmI8 Ep/sCWqXem21oVNhrO35ORjaMA17CltxLTdfbR7ZhPB4Vdo5TpvdvntgmCPGq7zQM3MI 4zYVOdsrjwnfx4qw7VMdL0k5rMy4Pn6WfooA/a/Xfv5aRWka+MZR83ipb9Y54Q/iZsKq 80CVW2nBjj8FWMVjgIkbDOwA8bD3veNFtYxtY68XlG5Bk9Zm2EcMaSghgJjtmhDQYLom iNjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=0S6fLQ1V3lm4RQHbtTa0ml0qPWHAqL5UNpD1HyrLvI4=; b=mBHkmSJZ9wXOOh27lgbO9oLwrP7XLlt3QFVtbOZaStIzwEOAeLeYJxhudB9sQY48P/ M9w6Ox9t2jHEp/lX1jJXlFh3+XEiH63sihyykaGYWrW1yiYba53yYOTwWGkyAg24xWYG L/ODcCSIKzUlcJmcCMz4hfvbCn4TPZYuGkOGowGFPS3oyANYs2Mo+OD9KoTR0blkQUjj vUGzOrc1GCVGDz0lnFraryfWvrgROQsYzJTBEA8jCatgkm8D53BV8gB2Tg+eTGyLcUBx NEP+/FgpG9zRhH3DheHTlqWwoNxMUURztP4qiaZjUZYvVxJV0QI0lunHuXeKYB9rk3Nx KESA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=U1iGkOC7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r15-v6si21204265pgs.292.2018.05.09.01.08.33; Wed, 09 May 2018 01:08:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=U1iGkOC7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756217AbeEIIIH (ORCPT + 99 others); Wed, 9 May 2018 04:08:07 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:36758 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753339AbeEIIIE (ORCPT ); Wed, 9 May 2018 04:08:04 -0400 Received: by mail-wm0-f48.google.com with SMTP id n10-v6so25849185wmc.1 for ; Wed, 09 May 2018 01:08:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0S6fLQ1V3lm4RQHbtTa0ml0qPWHAqL5UNpD1HyrLvI4=; b=U1iGkOC7QKBVXXvcHtT7f0W3tgiojyBjw2vL7OHMz0j0ED+kqQHr3NWJ23AZt7hjvr nYo8vxk+cw5xvrKe4spl0ThWUxvD9jParRbdCsXa6W4lJ+Hgl3K9WT79XEDFscu5oprA 4poh+wvjPpM0FSDSAqm2lG9V+XLE7JPk3Hewo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0S6fLQ1V3lm4RQHbtTa0ml0qPWHAqL5UNpD1HyrLvI4=; b=ZBYmCeAXxuPZILoQqhTi7RV4mWq0/iH67AQNsqLsHHKIkFzNQ8SM1hlbaYDbUtO78q qrACtcFdiQ+V0W5I2Y1h8gKy9suJLRS5dCa+5pCaDcZq47kH92e3yzMUqZnCi6dQeNJH +UNwYlZ4AJKPysSC9zBB75Ow33A5p3vc63TcnboGXxTkfbJD7G2CGGO5FWoEbln7GbKG AZVTYIonPbpGcFqKS79nREhMhB2jLCq0rhCMHuv8kzxC2V57BEWVZVbQQZBHo8W/7GS/ RypePwsDfPhL0nfipEeV8Z41MTSby4k0P3hAlQ4fARHteFcqxWU+BJvDHSZXgrmNr3UT adAg== X-Gm-Message-State: ALQs6tBHmWbt+Ov2kEJUntjFMulyK0lOvg7ce7xg9WK7l55PDeitme+K 5uw8AZCKE2L6i9+HqA9Rh0gdLg== X-Received: by 2002:aa7:d656:: with SMTP id v22-v6mr16759186edr.116.1525853283080; Wed, 09 May 2018 01:08:03 -0700 (PDT) Received: from [192.168.0.18] (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.googlemail.com with ESMTPSA id j17-v6sm17005629ede.1.2018.05.09.01.08.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 May 2018 01:08:02 -0700 (PDT) Subject: Re: [PATCH v7 13/24] ASoC: qdsp6: q6adm: Add q6adm driver To: Banajit Goswami , andy.gross@linaro.org, broonie@kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, robh+dt@kernel.org Cc: gregkh@linuxfoundation.org, david.brown@linaro.org, mark.rutland@arm.com, lgirdwood@gmail.com, plai@codeaurora.org, tiwai@suse.com, perex@perex.cz, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, rohkumar@qti.qualcomm.com, spatakok@qti.qualcomm.com References: <20180501120820.11016-1-srinivas.kandagatla@linaro.org> <20180501120820.11016-14-srinivas.kandagatla@linaro.org> From: Srinivas Kandagatla Message-ID: Date: Wed, 9 May 2018 09:08:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/05/18 08:55, Banajit Goswami wrote: >> + */ >> +int q6adm_close(struct device *dev, int port_id, int perf_mode, int >> copp_idx) > perf_mode unused param. Remove for now. Can be added back when needed. > > Otherwise LGTM. Yep, will do that thanks. --srini > Once fixed above, add acked-by > Acked-by: Banajit Goswami