Received: by 10.192.165.148 with SMTP id m20csp5229507imm; Wed, 9 May 2018 01:22:53 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrKfCywqWT3r55TB1WjCkeGUxHABur6JTTlmG3leumPwNa3VhMKgXLpC0bjqhCeks2OxeYd X-Received: by 10.98.72.29 with SMTP id v29mr37355467pfa.57.1525854173300; Wed, 09 May 2018 01:22:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525854173; cv=none; d=google.com; s=arc-20160816; b=PbRUDpXfsl4nyIwOUIn0T4WJOFQSeFBwSg4d9U2yOXESoZ8Jte444uthWKBzKhq5dy O3VrJg7fQnbd9fF9aoS5e6Bk7B5Al4q70xEdn1cmlDEt0QPNB9fSNYd7x3Qg15inp+Jz 50ZB5oDgaFSSLO69ZHiJxq1xN/WAyWdnRXNKZxhbfaJV6Y+b8ZwTr7SuSQPCvbpBoIE2 8n+0WMVbNHnxLUJyKmPspgLEgGsJNLcyOY8rrXluDe+OHN9E5hQYWdZ6mssTAMJNN+Ry urPMuYSr8Oy+4NRB0QjR8T1z6ySnoLsl6lr7lq+XeIMii6Fc0mkRDBroL2KrTRM1r5J8 ArSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=dFaqiLjyVZYThPUgnVEUou904YO9uz/cz90BD3543wA=; b=G7evAyvHR9QHII2I1g5jnKHwza6bb0kd+LLY5pfdkEyUdMwPlWikYJJ9BCgyV3Aqy0 sLWpM1ZnhCZIhpjNqaGi5n75yMb27ilKOEr23wly7bWvGBMnW0wfmj9wp5Ysn2kqVHnK H726fQOvTSipvLhK0BccU83rCWgKrm59ULndmIcLC7Zsm+Br4sXoqiC9YvbXy1DcqLmy Orm8DP5WKV9h9Zrh+9VZDKHX36Wh5/KkbM7dfLbuWtktgG9rDHujEQbr4kL8OJqw85Vr w5z8KHOKN4vgFN1Imaq3kouPw7jDUJiprFBNKv92GSc1uLgA0BusEnE0gid71iQ0rJfL O5Kw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=ktbnaGys; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c9-v6si21480782pgw.657.2018.05.09.01.22.39; Wed, 09 May 2018 01:22:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=ktbnaGys; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934074AbeEIIVv (ORCPT + 99 others); Wed, 9 May 2018 04:21:51 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:37878 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933805AbeEIIVs (ORCPT ); Wed, 9 May 2018 04:21:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=dFaqiLjyVZYThPUgnVEUou904YO9uz/cz90BD3543wA=; b=ktbnaGysR2EgcJoGSrS6yDADj vY0413VVug4sHhigI1xuCULfxAjksHgq6Y8ET+Syi8zYcK6vqxASIzzSOQT96GmcJDJ3i03J4Oanw qR2qKt5IzyqSf8x7SnTpeEyBW0fxAW1lQA8bLhaC4PnzrlwwWKut6xcVEwBrKt7WJDzHw=; Received: from [2001:268:c0d0:8b7f:9590:ade9:80e5:b26d] (helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fGKLe-0007eA-Vk; Wed, 09 May 2018 08:21:19 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id B7E2D44007A; Wed, 9 May 2018 09:21:14 +0100 (BST) Date: Wed, 9 May 2018 17:21:14 +0900 From: Mark Brown To: changbin.du@intel.com Cc: yamada.masahiro@socionext.com, michal.lkml@markovi.net, tglx@linutronix.de, mingo@redhat.com, akpm@linux-foundation.org, rostedt@goodmis.org, rdunlap@infradead.org, x86@kernel.org, lgirdwood@gmail.com, arnd@arndb.de, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH v3 2/5] regulator: add dummy function of_find_regulator_by_node Message-ID: <20180509082114.GQ13402@sirena.org.uk> References: <1525566016-30172-1-git-send-email-changbin.du@intel.com> <1525566016-30172-3-git-send-email-changbin.du@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EkxpYdHiqGHPYbUt" Content-Disposition: inline In-Reply-To: <1525566016-30172-3-git-send-email-changbin.du@intel.com> X-Cookie: Advancement in position. User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --EkxpYdHiqGHPYbUt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 06, 2018 at 08:20:13AM +0800, changbin.du@intel.com wrote: > From: Changbin Du >=20 > If device tree is not enabled, of_find_regulator_by_node() should have > a dummy function since the function call is still there. Please do not submit new versions of already applied patches, please submit incremental updates to the existing code. Modifying existing commits creates problems for other users building on top of those commits so it's best practice to only change pubished git commits if absolutely essential. --EkxpYdHiqGHPYbUt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlryr3kACgkQJNaLcl1U h9Cf1Qf/VZXV2l+LOlO9wC/dYLfOubi56ydHPoYZE4BS7u5oWeD5QkXCJHO2HBYd hdPcuUgmVFyhllxpd6b44kSgYP70DoyxZ0ijsXZ4bEgg76pGKz9Fl8vhJ2EGmoeW 3LCZ6ESiYwFPoDs3dtIpiOpzVxghMHSqUvQeFEwzLvP08r5fzTmDTUUhXUrY/9f+ 5bG/l+YkEXqo05FKp85vs+EA4ck1GPqZWT+eNQUHqNuARGUNvvG1OHQIYk9BewC0 vXPe8+U98hjHjRpQWWIZJr0rrh17am9+y4H+HHxjUHlh/KxVjeDuz2g6w6k3Chrw r0j4nYeUdcc/WoCxu+jv5Jerhn2TBQ== =MKwt -----END PGP SIGNATURE----- --EkxpYdHiqGHPYbUt--