Received: by 10.192.165.148 with SMTP id m20csp5246584imm; Wed, 9 May 2018 01:44:32 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqWsn+qMNPOkoG7mFQ6Cp3hCATb+f7DHtSRUF/D4xiDgJ0qMQ8802ie1nSwFzhXWXDSgpkX X-Received: by 2002:a17:902:9886:: with SMTP id s6-v6mr44243961plp.380.1525855472868; Wed, 09 May 2018 01:44:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525855472; cv=none; d=google.com; s=arc-20160816; b=xIO5PeR/gLCVuX0a3gMhfw+A26B778tbHvR/2eH9UdKoTLlkAESENYSHM3uA0Y+RJn hXGTnin7jLG8zwL2ZN73xxH4LrYRdufgety/SF7veVo+1bZoQfPt7oL6c94S9fbTu9Cw Cic6CQRN0eZwWpq/LkA87r/4OVyJHFg/P7eXeNFpkUCoTIDHxNo5HBxJlEH98DfetPzp wpFKqhd0KlXwNYeuIC6JWT8EawjeiCzVQueHnckuBdY67CCLBRoUEho5UCeJunV3sVOc omo/SrqIPDmNV30fs/fzFXxnaXmPFJEnFEidZog9XD7PwlRs2D6PfG2O7MHgyxfHBrVq tYGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=xOa/yQzWR92S+f+CpDz3OvEzSHSOWXpKpi56JJiIcV8=; b=d8KAf092bwxFVcRLKmihpenb+lS8sZEtkC1Mdxr43fO1qME6LzxMxh5hdHDicmNBlq 0Jodr9fK6r4OGoI9vk2IUsIN6Vpb/dtd2gAsmUf/ijaVLJipf1N/LpS/AiahofneoQ6K HBK3hJH59BEMhoiz0Y1A71H7vumw2AcLTKXmbP22DTdBEwgcGsYl8BqreGU/5N7pyk3G 6hkVZVTmeNsD2KQ9a64P9/dGd/jRfvSQmIaXMwG3O9C/oP7vbJYx2JAticvN9DrWahn9 reCJPRHQ9Fg9FoVaAula6RXe8GulaC7J/qw2ejluPU40Za1SaMZWj1D/DofRJxskC7Cg w+JQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=PyMAWYxV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k3-v6si26205729pld.9.2018.05.09.01.44.18; Wed, 09 May 2018 01:44:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=PyMAWYxV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934380AbeEIIlc (ORCPT + 99 others); Wed, 9 May 2018 04:41:32 -0400 Received: from merlin.infradead.org ([205.233.59.134]:50406 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934244AbeEIIl3 (ORCPT ); Wed, 9 May 2018 04:41:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=xOa/yQzWR92S+f+CpDz3OvEzSHSOWXpKpi56JJiIcV8=; b=PyMAWYxVb2YrEkWuxE9Tk4jZ/ pqNNMIgduu2tFTpFzVSvrBxke84XLSHtddczPO/BOe1lYUWF5+1yHTGxEl+GsWbsUrHehrxCZJDK6 CYv4x7UMSeThHxN4/S+Q1AZ5F+BpZZiUcSnYSlgctwTJMkHCB+9q4edb+V9cL+lxBe96hPS5gu3gI yR6cn+n4SAPgvZTLcUsOkr47U7rSHrBN7LvizqQOAvHtHEMR/S4oDPEWPqm4OxK8FB40BNfCVol4R kTjwQ7R4rFTsCIB+cFdkvq2VTKa/2Ep/mxHd3c82vRDvWbkPXHtfbWaG0IWSBrGVpExRKwz0MC0I+ /o3sPaW1A==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fGKf4-0006gO-MC; Wed, 09 May 2018 08:41:22 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 432ED2029FA13; Wed, 9 May 2018 10:41:20 +0200 (CEST) Date: Wed, 9 May 2018 10:41:20 +0200 From: Peter Zijlstra To: Mauro Carvalho Chehab Cc: Linux Doc Mailing List , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, Jonathan Corbet , Ingo Molnar Subject: Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings Message-ID: <20180509084120.GF12217@hirez.programming.kicks-ass.net> References: <6b9b3184cbfabab1ad89c974ddf1c61631e8f1bf.1525684985.git.mchehab+samsung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6b9b3184cbfabab1ad89c974ddf1c61631e8f1bf.1525684985.git.mchehab+samsung@kernel.org> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 07, 2018 at 06:35:49AM -0300, Mauro Carvalho Chehab wrote: > The flow diagram should be inside a code-block to avoid those > warnings: > ./include/linux/wait.h:110: WARNING: Block quote ends without a blank line; unexpected unindent. > ./include/linux/wait.h:113: WARNING: Unexpected indentation. > ./include/linux/wait.h:115: WARNING: Block quote ends without a blank line; unexpected unindent. > > This is easily done by using "::" instead of just ":". And I'll voice my objection once again. This makes a regular comment worse. This rst stuff is utter shit for making normal text files less readable in your favourite text editor. If this gets merged, I'll simply remove that spurious ':' the next time I'm near that comment. > Signed-off-by: Mauro Carvalho Chehab > --- > include/linux/wait.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/wait.h b/include/linux/wait.h > index d9f131ecf708..d907ed761a7f 100644 > --- a/include/linux/wait.h > +++ b/include/linux/wait.h > @@ -101,7 +101,7 @@ init_waitqueue_func_entry(struct wait_queue_entry *wq_entry, wait_queue_func_t f > * lead to sporadic and non-obvious failure. > * > * Use either while holding wait_queue_head::lock or when used for wakeups > - * with an extra smp_mb() like: > + * with an extra smp_mb() like:: > * > * CPU0 - waker CPU1 - waiter > * > -- > 2.17.0 >