Received: by 10.192.165.148 with SMTP id m20csp5266271imm; Wed, 9 May 2018 02:06:05 -0700 (PDT) X-Google-Smtp-Source: AB8JxZof/g8u3FViYAIpt5joF8eMwjGrkrO8EkpY343hvBCKP9fNosSCuS0n4k2DlTi+l2uvM3Ti X-Received: by 2002:a65:5c06:: with SMTP id u6-v6mr12675279pgr.316.1525856765123; Wed, 09 May 2018 02:06:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525856765; cv=none; d=google.com; s=arc-20160816; b=UqgO9+GErCSKRZM4QSW81iwDYWw3sLD2rFDtI5w1gu2XTSKEF4IJx64T08t/tToL8A 0gMJICtuD3KG0TF/twJgvMw53pFp6+Ar2/+zbvgOxWErMcOpFeP5Y0zoSlVu1XB/VeDd 8AWTHAxK11b01IAasKh3U3uvK4uulOT4+5OyNHrKwRc6DUQ0NQZwLVngvowtqe3VJx5D vWZXQ0UNRUWpYIlg1ooYYpq5VCF0/p/IWOgVdIlqMxFOyP+e+LIS1pAW6b5Ad/ROUlEL FewbtbNNqLEmO1SNki3fma2oL4swsfnoajYQzsib2eTrwYQLJYVu8cS9B33ibgedDEuO saYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date:from :references:cc:to:subject:arc-authentication-results; bh=BoGyPckh1GHwAhf13G3bQDHwn/Me+021aleFbgNuZ+o=; b=WE40QlIr/pCNvIzgW556ZV+FNvKmNrnmU6NNM1AnAHpjBSc1RT8mqP20HaP37LqtOb 95CZg4x0zkmmtAOHXa8vVjhOggeLySuHUzqiweKKNvSptaYb7pZFe5KHkO1r+fePkG+h ZgRlIZNwkhbbxvpJejnlVVT4exyr5QcCJljDOl3DO94kz7luwwcj3ZZou5JZ+lYqDjsL XekpHvCd5A2h+sBqADXqGbSl/KcjSlbGsESUFNtuz51tZv6f3hbxFFYJog8mcfAWOi78 XnDIWPw+vVMKmRmmgw92lvyPxWdd+v/4sz5YFqVMyfEGq2RNKJlj4doJ2K5SHfTaZSVE H0sg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ba12-v6si21017524plb.384.2018.05.09.02.05.50; Wed, 09 May 2018 02:06:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934583AbeEIJFO convert rfc822-to-8bit (ORCPT + 99 others); Wed, 9 May 2018 05:05:14 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:47162 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934094AbeEIJFL (ORCPT ); Wed, 9 May 2018 05:05:11 -0400 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w4993Baf010803 for ; Wed, 9 May 2018 05:05:11 -0400 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0a-001b2d01.pphosted.com with ESMTP id 2huv4fwbyb-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 09 May 2018 05:05:10 -0400 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 9 May 2018 10:05:08 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 9 May 2018 10:05:04 +0100 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w499536U64422090; Wed, 9 May 2018 09:05:03 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C4CD942047; Wed, 9 May 2018 09:56:05 +0100 (BST) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 495E54204B; Wed, 9 May 2018 09:56:05 +0100 (BST) Received: from oc2481388365.ibm.com (unknown [9.152.212.222]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 9 May 2018 09:56:05 +0100 (BST) Subject: Re: [PATCH 0/3] scsi: arcmsr: Add driver parameter cmd_timeout for scsi command timeout setting To: Ching Huang , "Martin K. Petersen" Cc: James.Bottomley@HansenPartnership.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, dan.carpenter@oracle.com, hch@infradead.org, colin.king@canonical.com References: <1525675401.8876.9.camel@Centos6.3-64> <1525761166.4261.8.camel@Centos6.3-64> <1525761818.4261.12.camel@Centos6.3-64> From: Steffen Maier Date: Wed, 9 May 2018 11:05:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1525761818.4261.12.camel@Centos6.3-64> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8BIT X-TM-AS-GCONF: 00 x-cbid: 18050909-0012-0000-0000-000005D4529B X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18050909-0013-0000-0000-0000195167F3 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-05-09_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1805090088 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/08/2018 08:43 AM, Ching Huang wrote: > On Tue, 2018-05-08 at 14:32 +0800, Ching Huang wrote: >> On Tue, 2018-05-08 at 01:41 -0400, Martin K. Petersen wrote: >>> Hello Ching, >>> >>>> 1. Add driver parameter cmd_timeout, default value is ARCMSR_DEFAULT_TIMEOUT. >>>> 2. Add slave_configure callback function to set device command timeout value. >>>> 3. Update driver version to v1.40.00.06-20180504. >>> >>> I am not so keen on arcmsr overriding the timeout set by the admin or >>> application. >>> >>> Also, instead of introducing this module parameter, why not simply ask >>> the user to change rq_timeout? >>> >> This timeout setting only after device has been inquiry successfully. >> Of course, user can set timeout value to /sys/block/sdX/device/timeout. >> But user does not like to set this value once command timeout occurred. >> They rather like timeout never happen. >> > This timeout setting apply to all devices, its better than user has to > set one bye one for each device. Udev rules? Something roughly like bottom of: https://www.ibm.com/support/knowledgecenter/ST3FR7_8.1.2/com.ibm.storwize.v7000.812.doc/svc_linux_settings.html or better doing the assignment with udev builtins (fix the syntax error with model): https://www.ibm.com/support/knowledgecenter/ST3FR7_8.1.2/com.ibm.storwize.v7000.812.doc/svc_zs_statechange_3fgeri.html -- Mit freundlichen Grüßen / Kind regards Steffen Maier Linux on z Systems Development IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz Geschaeftsfuehrung: Dirk Wittkopp Sitz der Gesellschaft: Boeblingen Registergericht: Amtsgericht Stuttgart, HRB 243294