Received: by 10.192.165.148 with SMTP id m20csp5273630imm; Wed, 9 May 2018 02:13:05 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqGGwzFKC0OKglnq8rqqqivshGy+EP2R6KBr/bFcAL0SBORQly0miztKoZad4WXaTnpStDd X-Received: by 10.98.35.11 with SMTP id j11mr43060356pfj.177.1525857185370; Wed, 09 May 2018 02:13:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525857185; cv=none; d=google.com; s=arc-20160816; b=YxbwfkBeges2c/HRncOW8xPoGkPupiTzUO+bDHTIBAv3wy0jNDpg9tNtqIhspHXiYI qQqLdKJU1Jw53mrjzdPOmPhQTJQar4ZOA2VqnHnOHwyR2rWMP9W7wfWZmNIkMSJlZw6u qdB4Pl8sKAhsouesp3OCpR7T4UGaLYOLlzDGR8YU7RP0eAZ4bO42SwYyfzad6KI970kX 15mGSHL7M3FaAbSpZ+S5s4Pdwgi+jxEqo1WgRY667z4hGQ3vQ/nKnT+9kOHEpzyvRBA8 FrSh7uqb1292TjREtnliVnWpWgZyMSeF2ukk6wg+TelzfJhMRfhGQDIqzSEgfHqcd2WD do4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature:arc-authentication-results; bh=3GXnPLFkOfhQ+2nlGlppTzKEEOG+kDb7HW0xdKKnTxo=; b=AXlSnXi7e8VD72MZmQ4Yr6ausp1QWiFawGwl2sDc+JF+J2poT7YbTBqtUOweFWYi5g KZYBFmOzq55rRtWr6+VIMgxqAq+tIy0G+HoktXu0Vop3DIM6KZNSlQ4uQaA4E4CELji0 CWNud/Vk4EJjbh5qMQGBegaqeHtHOyBr5Yo+lK1n52c12Yqd61WKneLHVHgrryAwavC+ gzO7d/VPWyN90U4wBna+lwOnk2IxzRQmIzvc6v1BLJRLXfjZYr4MGGB3VhN1BBmlS0q8 IGi3jM08dheXVp1EA6trbNKI6foD24UPHqIITuW50TxsmIAHXQEd8dMaBYAxv+tqF9Vl PCjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=eElCLlq7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y1-v6si20869786plt.316.2018.05.09.02.12.50; Wed, 09 May 2018 02:13:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=eElCLlq7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934428AbeEIJMT (ORCPT + 99 others); Wed, 9 May 2018 05:12:19 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:38068 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934085AbeEIJMS (ORCPT ); Wed, 9 May 2018 05:12:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=3GXnPLFkOfhQ+2nlGlppTzKEEOG+kDb7HW0xdKKnTxo=; b=eElCLlq7Nba1 dpNDupz5I005iSNBVIw5WfR7W29XMYKQMPKTYWbG+4Os+nPhaqUQkU8ZtUpoQX8G8HVr73gHY6gML 2izI/v9Tqpcx5ZkRAeErQX8IZWWdnYo0ebWWnd3s3YTE2uCGTfw5TaNQSgKXmIvx9AdwI59nrY/oz +uAak=; Received: from kd111239173186.au-net.ne.jp ([111.239.173.186] helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fGL8c-0007hi-Df; Wed, 09 May 2018 09:11:55 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id 77D5C44007A; Wed, 9 May 2018 10:11:50 +0100 (BST) From: Mark Brown To: Wei Yongjun Cc: Mark Brown , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Matthias Brugger , Kai Chieh Chuang , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org Subject: Applied "ASoC: fix return value check in mt6351_codec_driver_probe()" to the asoc tree In-Reply-To: <1525657185-73163-1-git-send-email-weiyongjun1@huawei.com> Message-Id: <20180509091150.77D5C44007A@finisterre.ee.mobilebroadband> Date: Wed, 9 May 2018 10:11:50 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch ASoC: fix return value check in mt6351_codec_driver_probe() has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From aaa730ca3f88f535dc12e2f0ff575f70f516841b Mon Sep 17 00:00:00 2001 From: Wei Yongjun Date: Mon, 7 May 2018 01:39:45 +0000 Subject: [PATCH] ASoC: fix return value check in mt6351_codec_driver_probe() In case of error, the function dev_get_regmap() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Signed-off-by: Wei Yongjun Signed-off-by: Mark Brown --- sound/soc/codecs/mt6351.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/mt6351.c b/sound/soc/codecs/mt6351.c index e739f078fec5..f73dcd753584 100644 --- a/sound/soc/codecs/mt6351.c +++ b/sound/soc/codecs/mt6351.c @@ -1472,8 +1472,8 @@ static int mt6351_codec_driver_probe(struct platform_device *pdev) priv->dev = &pdev->dev; priv->regmap = dev_get_regmap(pdev->dev.parent, NULL); - if (IS_ERR(priv->regmap)) - return PTR_ERR(priv->regmap); + if (!priv->regmap) + return -ENODEV; dev_dbg(priv->dev, "%s(), dev name %s\n", __func__, dev_name(&pdev->dev)); -- 2.17.0