Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180508162829.7729-1-glider@google.com> <20180508214445.lnqbct6dgrhyxp4a@black.fi.intel.com>
In-Reply-To: <20180508214445.lnqbct6dgrhyxp4a@black.fi.intel.com>
From:   Alexander Potapenko <glider@google.com>
Date:   Wed, 09 May 2018 09:16:03 +0000
Message-ID: <CAG_fn=UrQw4qRofUgHb4A_j4hbuefSwGtFMfCtYS318HWXFSFA@mail.gmail.com>
Subject: Re: [PATCH v2] x86/boot/64/clang: Use fixup_pointer() to access '__supported_pte_mask'
To:     "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc:     dave.hansen@linux.intel.com, Ingo Molnar <mingo@kernel.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Matthias Kaehlcke <mka@chromium.org>,
        Dmitriy Vyukov <dvyukov@google.com>,
        Michael Davidson <md@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, May 8, 2018 at 11:44 PM Kirill A. Shutemov <
kirill.shutemov@linux.intel.com> wrote:

> On Tue, May 08, 2018 at 04:28:29PM +0000, Alexander Potapenko wrote:
> > @@ -196,7 +204,8 @@ unsigned long __head __startup_64(unsigned long
physaddr,
> >
> >       pmd_entry =3D __PAGE_KERNEL_LARGE_EXEC & ~_PAGE_GLOBAL;
> >       /* Filter out unsupported __PAGE_KERNEL_* bits: */
> > -     pmd_entry &=3D __supported_pte_mask;
> > +     mask_ptr =3D (pteval_t *)fixup_pointer(&__supported_pte_mask,
physaddr);

> Do we really need the cast here?
Correct, we do not.

> --
>   Kirill A. Shutemov


--=20
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Stra=C3=9Fe, 33
80636 M=C3=BCnchen

Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg