Received: by 10.192.165.148 with SMTP id m20csp5303686imm; Wed, 9 May 2018 02:49:57 -0700 (PDT) X-Google-Smtp-Source: AB8JxZp5Mr6li0jEcbE83rUALOlguC2Ean2789teC9Qj1d9ljtifUczPl6kqOr5z2y8+mK45jbia X-Received: by 2002:a63:6441:: with SMTP id y62-v6mr36014835pgb.362.1525859397606; Wed, 09 May 2018 02:49:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525859397; cv=none; d=google.com; s=arc-20160816; b=usqX2SCNozZwmB40vWLleYpAQyptsJJbx8fcEm+qCWbg/G1svD5m0/9UjQdkvILsGt /dYM2THieQHyzuSf16POaLAQCiN8KAN5MpdNWQEvSA3TWyh3kZUn54M6Qyo2MnmTTQJK zVEnwBsc2K9uAEOHsTV5PTnncUyPm9U7V6BcmNihLj/+fPkW78n4fwjQL7wL9IuxZakG G56q1LsXnYKKc5R1Rs7U0I1Mta2hEV0BBl8UZL4sifMLTSxprdEzrvP1A28GdJduvvCC l5L+vS5DaiREhLf09Lyl1WXr25S0V2cAZzLBzV8qdJXhM5GCLEr07FxzM3IG73o0Q7+P WWZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature:arc-authentication-results; bh=3GXnPLFkOfhQ+2nlGlppTzKEEOG+kDb7HW0xdKKnTxo=; b=C4vwzp5SviQG0F9hFcTkySyLPN85/8Nuchz2ibU1+6GV75ppp4t+dz4y4SYzAAtril 3SZNhvk40r2CIwXaY0vXlx4kxUeQI5QFSPuWd52ijesMhgr/Rhv0S0//a09+1XvpDq7v 10VtQY4CPCD5lOQpqLWjCn77npHcXlUy6E2FrmkEeJsCDPnZIvHrKyTo5FxiTubta6y6 4WUqrPSa7I7vRL655gpRjIb03oO1RvxudU+aHqoMmFHrpF4MFDP3nyxHtgvCbPXQCqdq qf/a1OO6/fPmb4dHc2KnNYAKnuyKNZGbGIMOOcab2h070Rg9PQJ5PUJxG9LOBpbv3iI6 qdsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=N+f3MdCq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h33-v6si25926807plh.483.2018.05.09.02.49.43; Wed, 09 May 2018 02:49:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=N+f3MdCq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934437AbeEIJtT (ORCPT + 99 others); Wed, 9 May 2018 05:49:19 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:44132 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934133AbeEIJtR (ORCPT ); Wed, 9 May 2018 05:49:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=3GXnPLFkOfhQ+2nlGlppTzKEEOG+kDb7HW0xdKKnTxo=; b=N+f3MdCqQTgM jc7x32n+F8Cx3cEkFZdCGoeXFDDZJWwkn/0yQOwoVr7DeeRwbb3PW7xCffNppDhMmeIvH9ZN9SgNH x0A49DD6i/EZ/zc4EBLN0JKHBCPk3GA82jcDNumtb3XBMBEgGfMYLgw9IiXuIsBvkE6gHRU+sOgNL CVLA8=; Received: from [2001:268:c0d0:8b7f:9590:ade9:80e5:b26d] (helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fGLha-0007rC-EP; Wed, 09 May 2018 09:48:03 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id E29A044007A; Wed, 9 May 2018 10:47:58 +0100 (BST) From: Mark Brown To: Wei Yongjun Cc: Mark Brown , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Matthias Brugger , Kai Chieh Chuang , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org Subject: Applied "ASoC: fix return value check in mt6351_codec_driver_probe()" to the asoc tree In-Reply-To: <1525657185-73163-1-git-send-email-weiyongjun1@huawei.com> Message-Id: <20180509094758.E29A044007A@finisterre.ee.mobilebroadband> Date: Wed, 9 May 2018 10:47:58 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch ASoC: fix return value check in mt6351_codec_driver_probe() has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From aaa730ca3f88f535dc12e2f0ff575f70f516841b Mon Sep 17 00:00:00 2001 From: Wei Yongjun Date: Mon, 7 May 2018 01:39:45 +0000 Subject: [PATCH] ASoC: fix return value check in mt6351_codec_driver_probe() In case of error, the function dev_get_regmap() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Signed-off-by: Wei Yongjun Signed-off-by: Mark Brown --- sound/soc/codecs/mt6351.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/mt6351.c b/sound/soc/codecs/mt6351.c index e739f078fec5..f73dcd753584 100644 --- a/sound/soc/codecs/mt6351.c +++ b/sound/soc/codecs/mt6351.c @@ -1472,8 +1472,8 @@ static int mt6351_codec_driver_probe(struct platform_device *pdev) priv->dev = &pdev->dev; priv->regmap = dev_get_regmap(pdev->dev.parent, NULL); - if (IS_ERR(priv->regmap)) - return PTR_ERR(priv->regmap); + if (!priv->regmap) + return -ENODEV; dev_dbg(priv->dev, "%s(), dev name %s\n", __func__, dev_name(&pdev->dev)); -- 2.17.0