Received: by 10.192.165.148 with SMTP id m20csp5318671imm; Wed, 9 May 2018 03:07:01 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrDfHLaNYtzyTS8ox195Hb2nmKB0Z9LaPLa87Br0qyS4KB9U8RN1I7Gd4nLlVK96vdQj9cj X-Received: by 10.98.99.4 with SMTP id x4mr32991644pfb.94.1525860421350; Wed, 09 May 2018 03:07:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525860421; cv=none; d=google.com; s=arc-20160816; b=e05taTAVBoJ4rl9hIKh3it2Tg2+uug9RNBwF/9EFhcRq3A4SBTCgscQuzaPyau7uaS qHomdOsBo+vl5bPt1ZOGSBvKQeng3T6mWG4b5EQaXVtbqdfsJ7r/u0WhGt4+63U6wsP/ LwkNtvZFeNXfNXkKsi/tUdIRJyB5uwdCu/8Wh/kWdOrR/WkqfEKl8bcBiMUhe6zKJYCk Xy0RBMfyndejtXmZjC8wxgxeRXY/qHwNIG17GJSt+td3cLhf+fIqjr8Fc04/b3sqCJxU K3fX4YorGLoa6PH8fGrljxieY7OQeP2Gma8q4JV2ALTdQioyGGGPZ97SWhoDZ6UdMjLI Vh0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=STaWK4Mzm+EngNJGYDAB3IhvQYYqDDq33lph42W7BQ0=; b=vdahTcfOg4ASzT1++0Q/et0xbENP1LIkawtMAQC/KgZdYawdkXo2ruTtVLveFIBFP/ wD0sqGB1H5uRsBf41/maJDpEPSlJKUoCarc+x4Bqzer0OnetoDqiNNxKT1PXhPMy9iqf ONIW3E3AYOFRmpZQR1AaXlG3nPkmHeROCNTSsEJuQGueKV2BNYKbvBh5inEefeTJU+d0 57LnE6N9e67RyMrdldOH10cwChzySZSmcGX2r+nz7MO3acn3RwbBBt0sFBNySWmObykq NyL+PgLZW0PmT7V80iFXjmTVWBhVnrHLn9kTx1M5d5SssAdzOjEdC8Dz/zVavQIHfQYP PEeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=lsTjblK7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c24-v6si24585636plo.489.2018.05.09.03.06.46; Wed, 09 May 2018 03:07:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=lsTjblK7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934383AbeEIKGQ (ORCPT + 99 others); Wed, 9 May 2018 06:06:16 -0400 Received: from merlin.infradead.org ([205.233.59.134]:51618 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932215AbeEIKGN (ORCPT ); Wed, 9 May 2018 06:06:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=STaWK4Mzm+EngNJGYDAB3IhvQYYqDDq33lph42W7BQ0=; b=lsTjblK7/H7ro6++rn2SYFMEX rwf5yUvb7kwiJn0gjpYvH51iGR5PH+Iliw8yTPTCmEunP47BR+N+QH9TjLlMQhNJBka9+BK7CdzFR sg1RskCx+VGQKhvGpybARjSfMN8emWckQN4fYeOEWrBzlKSV9u/HcoVaEFWyhjvJyiLK/uKgzJ9UG D4ACVNv2tMhnxKUw5sq4eVijX9wDg9U0kFiAgujoiHVnaD+9b94r1bYd7AbK45MKusVYJoSvoK0oP FOtpuT62vG+uDTqHkLpwAA5UbyLEzEprmOI5qWc2XLApPey3vcdmcoblkJGHbytsftT9ceO9E2RI8 W9in/ASxw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fGLyr-00078E-Sb; Wed, 09 May 2018 10:05:54 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 6AE172029FA13; Wed, 9 May 2018 12:05:51 +0200 (CEST) Date: Wed, 9 May 2018 12:05:51 +0200 From: Peter Zijlstra To: Johannes Weiner Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, cgroups@vger.kernel.org, Ingo Molnar , Andrew Morton , Tejun Heo , Balbir Singh , Mike Galbraith , Oliver Yang , Shakeel Butt , xxx xxx , Taras Kondratiuk , Daniel Walker , Vinayak Menon , Ruslan Ruslichenko , kernel-team@fb.com Subject: Re: [PATCH 6/7] psi: pressure stall information for CPU, memory, and IO Message-ID: <20180509100551.GL12217@hirez.programming.kicks-ass.net> References: <20180507210135.1823-1-hannes@cmpxchg.org> <20180507210135.1823-7-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180507210135.1823-7-hannes@cmpxchg.org> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 07, 2018 at 05:01:34PM -0400, Johannes Weiner wrote: > + u64 some[NR_PSI_RESOURCES] = { 0, }; > + u64 full[NR_PSI_RESOURCES] = { 0, }; > + some[r] /= max(nonidle_total, 1UL); > + full[r] /= max(nonidle_total, 1UL); That's a bare 64bit divide.. that typically failed to build on 32bit archs.