Received: by 10.192.165.148 with SMTP id m20csp5429087imm; Wed, 9 May 2018 05:04:13 -0700 (PDT) X-Google-Smtp-Source: AB8JxZo5L6esKCwVbkLnxE559afS0gyB1UiZpKzc01FHWQnBOEJsGj9FPHpz7HfrHECXPgIJrOSp X-Received: by 10.167.131.5 with SMTP id t5mr14922524pfm.198.1525867453324; Wed, 09 May 2018 05:04:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525867453; cv=none; d=google.com; s=arc-20160816; b=cUlD+5p7cOwyVSVR+yE/sre469W128kWjpUGngQ8Xsv0XVP4O1ZNuWbwioOOh2+nGq f1Zj+wwXIx1G1a57DgJ1rRZ1Rc9gqBrCn6gx6d55iGqDmoxWDJZqAAWly0kwdAyybn9F ZY2KbPh59Rxz0iGkoI31tEGiA27p18vLO6nmtRlU4pWyUq6HLZwZpEdLjsiNE6ozjl5k 87IOnkdntoGIBih61jA5Rp3kpBJFTMzLM9xBq2I/SIfgAw9Fn3957hGNRJM21hyCiCwT Qe6a9gPh0C4ZH+Y3xbYcoHYKOgtqRO9c0oEuk4CAHht/rEu5PlZi0qjAP/9vx1n+/qrd VaJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=p0sz2wGPBkcbY2jFbuWpDjOtlcU9TZR72VGZqRy5SHU=; b=ow0xRT2LytURw8ULOdQqVghVy32maadJ9yRjsaPiUZjQ859foBwtVZXLuuK5P6QYTL qzszP/rpqaoo7cirT0GEB55r00yHuPno8ZTYv3x4VY/ay+6yFIRIq/9YSRkecbaNbY6Y Lw25ly12VOgt7UxP/PVhwOTtnXZur6UIJ8k29m59oOrufZHFBJzPsjqE8uP2XM5KY/Gt Rp5tccZiC1TULnlgPcdxJaPniu+Y3DtpqFvpcFiPFpHz+eUHf8DM7UYiWJurIbPfaMwa 1DgEV49UsolmCZg11Yd00FXmSHD4zOKKvVmMmZo6DMGNZ+4XLp5ukcvuksQ0vi3TjFWc 5zqg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a15-v6si13005668pgd.531.2018.05.09.05.03.58; Wed, 09 May 2018 05:04:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934878AbeEIMCl (ORCPT + 99 others); Wed, 9 May 2018 08:02:41 -0400 Received: from mail.bootlin.com ([62.4.15.54]:54898 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934721AbeEIMCi (ORCPT ); Wed, 9 May 2018 08:02:38 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 404472072B; Wed, 9 May 2018 14:02:36 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.0 Received: from bbrezillon (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr [90.63.216.87]) by mail.bootlin.com (Postfix) with ESMTPSA id DF59620376; Wed, 9 May 2018 14:02:35 +0200 (CEST) Date: Wed, 9 May 2018 14:02:36 +0200 From: Boris Brezillon To: Mauro Carvalho Chehab Cc: Linux Doc Mailing List , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, Jonathan Corbet , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , linux-mtd@lists.infradead.org Subject: Re: [PATCH 16/18] mtd: rawnand.h: use nested union kernel-doc markups Message-ID: <20180509140236.17d437f8@bbrezillon> In-Reply-To: <20180507083232.5a084ba7@vento.lan> References: <39d8d4f0e0ff5a06be0303f7f4f2eac5fb45b9ca.1525684985.git.mchehab+samsung@kernel.org> <20180507114650.171edcc2@bbrezillon> <20180507083232.5a084ba7@vento.lan> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 May 2018 08:32:32 -0300 Mauro Carvalho Chehab wrote: > Hi Boris, > > Em Mon, 7 May 2018 11:46:50 +0200 > Boris Brezillon escreveu: > > > Hi Mauro, > > > > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h > > > index 5dad59b31244..b986f94906df 100644 > > > --- a/include/linux/mtd/rawnand.h > > > +++ b/include/linux/mtd/rawnand.h > > > @@ -740,8 +740,9 @@ enum nand_data_interface_type { > > > > > > /** > > > * struct nand_data_interface - NAND interface timing > > > - * @type: type of the timing > > > - * @timings: The timing, type according to @type > > > + * @type: type of the timing > > > + * @timings: The timing, type according to @type > > > + * @timings.sdr: Use it when @type is %NAND_SDR_IFACE. > > > > Hm, really feels weird to do that. I mean, either we describe > > timings.sdr or timings, but not both. I this case, I agree that > > describing timings.sdr would make more sense than generically > > describing any possible entries in the timings union. > > This struct is funny, as the union has just one item. I assume > that the original intend is to be ready to have more timing > types (or you had it in the past). By the time you have a > second value there, describing the union would make more > sense. > > > Is there a simple > > way we can get rid of the warning we have when not describing timings > > but all of its fields? > > There's no direct way. It won't be hard to add a way to do it, > like applying the enclosed patch with ends by declaring timings as: > > * @timings: -- undescribed -- > > IMHO, this is uglier. Yep, don't like it either. I'll just take your initial patch. Thanks, Boris