Received: by 10.192.165.148 with SMTP id m20csp5465572imm; Wed, 9 May 2018 05:39:00 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqy5HRQkzlXEWP6iHucM2SZwzgoOLsqzMbDuL7GZT2UWitocQr8Bsx2NMKIgTSTCkwKsCBF X-Received: by 2002:a17:902:3f83:: with SMTP id a3-v6mr45579767pld.279.1525869540513; Wed, 09 May 2018 05:39:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525869540; cv=none; d=google.com; s=arc-20160816; b=eGpfPfJ/gPUnKrOPegvL7Y5CtoTgNYxrtjUk6Us0xnRcDOvnXJ9skstURmUJJcQdp3 n1AKpk3oPut4K60BbzSUwz4gbr5CYoaXL05+jsqBh1o6mZh91XlpQcnpdntNJ80l79B3 cyk6j+gejvH7S2dGT2bPPD1dB7hzxDbtBDK2CtnGH15MG6ZGxhgS1SqGtTXOHWYR5WfE 1bOv7E1EhepqT3FvdAV4dX5B7w7KnCeVh7GTEFZD9827dO9cBrXaUnjmbq7+bdAGQhQx 4pmXDxkqAJCkFJSCFmClscUKrEJGSSf4eFnUumCjrXLuBiHHYMkvnX1nsboGO5xrkFeC k1Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=2Zco5wP0GfWFi8VBlqXU+k5NYJtu7ul37QQM1Pfk5qc=; b=inBZZpwIxi3tJDYTqDF8AwkarDb+t+YpG4VtDNVWdVzTj9l187Gx+rlPtAXmQ3CxHJ opaWJ3gxumzeXNEGcGZMo/kbWV5bohjGUJjxnXkIw0wOp9uPIeoQA2P+uvDgoZCTQsym ggQYIwimlA5a6k2FdrUeG18kpIX8sVvDCcPwIGMHqHCvi7tFgjghqD4btDCWD/Abge7o qYfiTCfD2VElnqR3ndoPp2BPM1JasilekktyC0PTWup5Xrp2Efi5uaApz/asxWMUq1Sq 7kq9MzEIhfLviGIpTaYG9t38+Lv2ioAVte0gkimz+DttNpGAi7NcT7Zz/HcPcovBym2V qexw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d2-v6si25840681plh.387.2018.05.09.05.38.45; Wed, 09 May 2018 05:39:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934684AbeEIMiT (ORCPT + 99 others); Wed, 9 May 2018 08:38:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:37956 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932875AbeEIMiR (ORCPT ); Wed, 9 May 2018 08:38:17 -0400 Received: from gandalf.local.home (cpe-66-24-56-78.stny.res.rr.com [66.24.56.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9D1D1217B4; Wed, 9 May 2018 12:38:16 +0000 (UTC) Date: Wed, 9 May 2018 08:38:14 -0400 From: Steven Rostedt To: Thomas Tai Cc: bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, mr.nuke.me@gmail.com Subject: Re: [PATCH V3 1/1] PCI/AER: add pcie TLP header information in the tracepoint Message-ID: <20180509083814.149e8d8f@gandalf.local.home> In-Reply-To: <1525820696-31967-2-git-send-email-thomas.tai@oracle.com> References: <1525820696-31967-1-git-send-email-thomas.tai@oracle.com> <1525820696-31967-2-git-send-email-thomas.tai@oracle.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 May 2018 19:04:56 -0400 Thomas Tai wrote: > When a PCIe AER occurs, the TLP header information is > printed in the kernel message but it is missing from > the tracepoint. A userspace program can use this information > in the tracepoint to better analyze problems. > > To enable the tracepoint: > echo 1 > /sys/kernel/debug/tracing/events/ras/aer_event/enable > > Example tracepoint output: > cat /sys/kernel/debug/tracing/trace > aer_event: 0000:01:00.0 > PCIe Bus Error: severity=Uncorrected, non-fatal, Completer Abort > TLP Header={0x0,0x1,0x2,0x3} > > Signed-off-by: Thomas Tai > --- Reviewed-by: Steven Rostedt (VMware) -- Steve