Received: by 10.192.165.148 with SMTP id m20csp91603imm; Wed, 9 May 2018 09:15:59 -0700 (PDT) X-Google-Smtp-Source: AB8JxZr+UCA2CIRVyKdxS3l5PQ63uxspF67d7hU2wreQvHUmwn/Bp5OkRNfNVlRNlisVfqsrK1S/ X-Received: by 2002:a63:744a:: with SMTP id e10-v6mr32309533pgn.275.1525882559156; Wed, 09 May 2018 09:15:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525882559; cv=none; d=google.com; s=arc-20160816; b=YPKMVg5pitcZq3zBGCyBuTQ8JJ0GIrIywDnpF9UoiVo2480yxjFzxiS9HRz/yTiRs/ S/iEvz0wQ1AC3fhsEvY1rzzHzjh0Tc/ALEPez6FeRGz/8ZLoWc8PE5YA0xMRKacRiZOl Zc47jKj1reAqS1+nniXlsSNMyxQpPWpXE3sDzubzGQVQnmnQIt7JWO9QMstI+/Ewc6R8 oZoEKEKWvCcmJ+gBGvsyXtTTOtlqdRsZVH/DMftTWS8ZefSajQHryAPBeaz8eySycjji +DHk+LcBhETcMcX778fKpGK2k3hB8ioVpElO6Oxq/1Ctj2Y0wJBVqBaJ0xfrnh/Xmu9l U/8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=3wkoB0CsfTZ4QNISXPF5HSt8dWmsfp6L5d0BS35meeg=; b=NMeFGa6uZ6exdGxQ1CURWCDtJiGEuHxND/fpI0QS9ZaLNn45r8WeWrnBuss3lc2x54 tvKOFFYjvD8hQc0/v9ATu+fXNV4S80J7OKUXamrgB0nL2cLWnID+OXYZp3ILM6K15bZG 3z86BF/u1kMVQYCzbNhlLhVrUehS0wEcoj+aJ4Kk7cxbsnj6xMcR6E/raqpGrAQkpb6F sfwCSzEp6vUzpODwe1iORj/gY2srTe6ZDak5h8hnnUBG1JQu400O1SxUx2gF+w9Wj1Hz gQWyQH+p+j0xjKulsHFMsMT+7UXyFPjW0pZYwz4Wj6OdAaadasnUfzjJVRKk9bpuyCS5 e7sw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z30si3590924pfg.266.2018.05.09.09.15.44; Wed, 09 May 2018 09:15:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965434AbeEIQNn (ORCPT + 99 others); Wed, 9 May 2018 12:13:43 -0400 Received: from www62.your-server.de ([213.133.104.62]:56607 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965421AbeEIQNl (ORCPT ); Wed, 9 May 2018 12:13:41 -0400 Received: from [188.63.75.139] (helo=linux.home) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-SHA:256) (Exim 4.85_2) (envelope-from ) id 1fGRig-00064Q-ED; Wed, 09 May 2018 18:13:34 +0200 Subject: Re: [PATCH bpf-next] xsk: fix 64-bit division To: Randy Dunlap , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , ast@fb.com, netdev@vger.kernel.org Cc: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Stephen Rothwell , magnus.karlsson@intel.com, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180507174350.3534-1-bjorn.topel@gmail.com> From: Daniel Borkmann Message-ID: <17967788-2811-892b-0126-1bc49a5b9929@iogearbox.net> Date: Wed, 9 May 2018 18:13:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.99.3/24554/Wed May 9 14:30:12 2018) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/07/2018 08:25 PM, Randy Dunlap wrote: > On 05/07/2018 10:43 AM, Björn Töpel wrote: >> From: Björn Töpel >> >> i386 builds report: >> net/xdp/xdp_umem.o: In function `xdp_umem_reg': >> xdp_umem.c:(.text+0x47e): undefined reference to `__udivdi3' >> >> This fix uses div_u64 instead of the GCC built-in. >> >> Fixes: c0c77d8fb787 ("xsk: add user memory registration support sockopt") >> Signed-off-by: Björn Töpel > > I don't know why the subject says xsk (instead of xdp), but anyway: > > Reported-by: Randy Dunlap > Tested-by: Randy Dunlap Applied to bpf-next, thanks everyone!