Received: by 10.192.165.148 with SMTP id m20csp106177imm; Wed, 9 May 2018 09:30:16 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrUVoDZ67aSr4LemIZUo00U6SSofu1EChmSl70fTmf0MCnLoVk08K9XP41ViyIP8EJwwdw2 X-Received: by 2002:a63:9401:: with SMTP id m1-v6mr36524008pge.140.1525883416230; Wed, 09 May 2018 09:30:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525883415; cv=none; d=google.com; s=arc-20160816; b=I/z2T1SXbKPtnQhC45gRB6uaiJAduEyYpI3jgTl+vUwrBHcoFnFLU5nHVNXwxW06xm qUJywqatUErwjgatuhAaklOG2tFMQqQl4wAp5RzIH5WhRT/Y3MOjdRo7fik3Z85RsxGL aYstTc8xguMowNeyEmNee+ElLFFDZurtzoWjjHkUuTLXX8jS3oadtyDNDhiMqgqGu7LT /nM4o9qjJljSpCATJlWf8M/Z8EUOKEipOZj7Ca3Ud8HVACnpb1TwZJQNwO3bXYVlSjDr A8jwa6woo2DEyWkkEu/Ww48Myo8l1yEMilaXENFsEg41YhJUbBhhQJXvPoZ5nzNpUaqL 8c6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=7+TmyPJlOXd19AuoZ+zP1Ss5EmAc6bRE4ZZMMeYSbPU=; b=zBkIGhIsCEUqG4KUhNAtXrv8U+B0FKpX7ooEmhc4YiXr1NeWVCU4WLVy8UgLmu7rFe CQWcjeNXXAY6WGhKSJrbFfYa5TNyp7PxqVwfg1hEXq/gXP3cm4K97mrmjXCBP46kcVOL Onl/FVgn+wFrER1d2CUc5R6njC9D77bMVj19ik22K2qclLtfkWkvFWn4bwGU68ygwzpL TBZUewysJW4KJXYS4xP/ed8JBIDzqz7Ss5MDD0ChoDVCtyeGodzBoS1qmzeWmSgKVWSr Dcf3ozWhVf24PHX4/W442HGyIM+EvyJ7wlUP/J49dqil6kI+F9sBLXQ4cScIEUee2eYQ p5KQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a34-v6si19057514pld.281.2018.05.09.09.29.58; Wed, 09 May 2018 09:30:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965512AbeEIQ3n (ORCPT + 99 others); Wed, 9 May 2018 12:29:43 -0400 Received: from bues.ch ([80.190.117.144]:37986 "EHLO bues.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934914AbeEIQ3l (ORCPT ); Wed, 9 May 2018 12:29:41 -0400 Received: by bues.ch with esmtpsa (Exim 4.89) (envelope-from ) id 1fGRy8-00071W-HS; Wed, 09 May 2018 18:29:32 +0200 Date: Wed, 9 May 2018 18:27:56 +0200 From: Michael =?UTF-8?B?QsO8c2No?= To: Matt Redfearn Cc: Larry Finger , =?UTF-8?B?UmFmYcWCIE1pxYJl?= =?UTF-8?B?Y2tp?= , Kalle Valo , linux-wireless , LKML Subject: Re: Regression caused by commit 882164a4a928 Message-ID: <20180509182756.6f36cc05@wiggum> In-Reply-To: <372d149c-c34c-56a0-4e1a-5ab2c1e16e73@mips.com> References: <7bbc067a-c412-3d2e-174a-abc31b46e246@lwfinger.net> <372d149c-c34c-56a0-4e1a-5ab2c1e16e73@mips.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/J1WK1fb.oUu4_Zwymfp9gqq"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/J1WK1fb.oUu4_Zwymfp9gqq Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 9 May 2018 13:55:43 +0100 Matt Redfearn wrote: > Hi Larry >=20 > On 07/05/18 16:44, Larry Finger wrote: > > Matt, > >=20 > > Although commit 882164a4a928 ("ssb: Prevent build of PCI host features= =20 > > in module") appeared to be harmless, it leads to complete failure of=20 > > drivers b43. and b43legacy, and likely affects b44 as well. The problem= =20 > > is that CONFIG_SSB_PCIHOST is undefined, which prevents the compilation= =20 > > of the code that controls the PCI cores of the device. See=20 > > https://bugzilla.redhat.com/show_bug.cgi?id=3D1572349 for details. =20 >=20 > Sorry for the breakage :-/ >=20 > >=20 > > As the underlying errors ("pcibios_enable_device" undefined, and=20 > > "register_pci_controller" undefined) do not appear on the architectures= =20 > > that I have tested (x86_64, x86, and ppc), I suspect something in the=20 > > arch-specific code for your setup (MIPS?). As I have no idea on how to= =20 > > fix that problem, would the following patch work for you? > >=20 > > diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig > > index 9371651d8017..3743533c8057 100644 > > --- a/drivers/ssb/Kconfig > > +++ b/drivers/ssb/Kconfig > > @@ -117,7 +117,7 @@ config SSB_SERIAL > >=20 > > =C2=A0config SSB_DRIVER_PCICORE_POSSIBLE > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bool > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 depends on SSB_PCIHOST && SSB =3D= y > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 depends on SSB_PCIHOST && (SSB = =3D y || !MIPS) > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 default y > >=20 > > =C2=A0config SSB_DRIVER_PCICORE =20 >=20 > I believe that the problem stems from these drivers being used for some=20 > wireless AP functionality built into some MIPS based SoCs. The Kconfig=20 > rules sort out building this additional functionality when configured=20 > for MIPS (in a round about sort of way), but it allowed it even when SSB= =20 > is a module, leading to build failures. My patch was intended to prevent= =20 > that. >=20 > There was a similar issue in the same Kconfig file, introduced by=20 > c5611df96804 and fixed by a9e6d44ddecc. It was fixed the same way as you= =20 > suggest. I've tested the above patch and it does work for MIPS=20 > (preventing the PCICORE being built into the module). >=20 > Tested-by: Matt Redfearn Could you please try this? config SSB_DRIVER_PCICORE_POSSIBLE depends on SSB_PCIHOST config SSB_PCICORE_HOSTMODE depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS && (SSB =3D y) && PCI_DRI= VERS_LEGACY The affected API pcibios_enable_device() and register_pci_controller() is only used in HOSTMODE. So I think it makes sense to make HOSTMODE depend on SSB=3Dy and PCI_DRIVERS_LEGACY. PCICore itself does not use the API, if hostmode is disabled. --=20 Michael --Sig_/J1WK1fb.oUu4_Zwymfp9gqq Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEihRzkKVZOnT2ipsS9TK+HZCNiw4FAlrzIYwACgkQ9TK+HZCN iw6zzRAAgYc6Piwo4UWmkEWzoAMnu/5X3HX1DoYkSAIvMnGokm/Gi27JkFRap9HW syIze0IFGCOTTb9Z0LIiZfrpn4m4vjSrCaNCmBBXdexfhLIDWfjy5sDv76rhAffj h6orCkbOWBoJ2Bpz/tnSYAhD+HO2kDLV9UmgHdhaUnZRGl8ciPcsJggpyNQa7+rd gsupykZvm459wdx380Dptmu3fdKlu7HAXEwWUNGOOzg4U9+Er3Zyb29+GyPkO1uI ueN3T2NlB77LgfziPiGyFw+0EqzUaWlvS1gAXapZVsx8S9FgO1WDhHe3bBJHE30F eoJNAJxJFKOyTjWNxppAJICEePxXr889jogTKWkxBJYxn/mRINCV1mNJ/dZS3AQm yIg1gfegntvV9vhw9uLAc0+tX/FDTs5ibkCm8S+PJcRd/s153qfA5eaqccChFpOO +d2dbbyxTG5TnxO3wdM0v3LsoaZYai0vbRaKApoLADeqpkoSlCYEbaLcEY2W+kKr 6xzGis2FjeXzSuSjdExvezkBsTKdDmQlpLGLNTpRoDFJIboPrP0WXTMVnO1ZXQUu KrsAFyda5Xzld8dz1J4pDzYksu4vPTetuJeyvcMtReq2U+3CMjoRHR1k49qetQeG 6ITHKhpQXynmVmlDAwLN2PbQfDHhkP/Zif50rl2K75nc2TNO/Ks= =tofR -----END PGP SIGNATURE----- --Sig_/J1WK1fb.oUu4_Zwymfp9gqq--