Received: by 10.192.165.148 with SMTP id m20csp225502imm; Wed, 9 May 2018 11:33:39 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrtaMy1pM5Gtw3L/PB0wL58r+bztbd2L/rBq3WwP6jcjRpTsZQ6wC2lgiMjqSaYiihNWq+Y X-Received: by 10.98.248.12 with SMTP id d12mr1471234pfh.159.1525890819187; Wed, 09 May 2018 11:33:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525890819; cv=none; d=google.com; s=arc-20160816; b=mGllPSPIwsuhgoNzQkPmUo5dDdR6o7FMC22q6g4OLLeYca4gv4mEKbItATTT5yi27Z Ynrx63nIAi5/VIPEhqJB/rBN96oiSTkwWrW4m2d8RsStAzePgwMF5vcoaaJhXLKnWpZP FTOHD+hPDYW1NHVWaoWrmeDyoOpaH0JTawp/K/AsnJs95yVvZ+kILm9DKZGnSQbk2u33 U391nO6tQ2XW7LrSsocz8hEbVSgJZx8HVy9uQYaaQDU3KqiSq5pCreHTNE0uXzZxV3qa CMIlDnyLUS571jz5/92UNSrnU/EclYsjftvlNvrOSYU0CnPzJYK9E5X8q8pVWznWDc4X 6YZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=qhRbP9PA/+dvImDlYlCg2Y8o8TQ7KrSMsyr6UDoASOo=; b=Y96Qo6nRSJ4WDzh73dvncsdT7+XCpzArAuH9Zk8i8m5rpYW2Ny6ojtbXQloR2tcmyO DoRFj133IR9+hRB0wLVEp7wYp0aE/z9PMk1CwSKAVYIq/T7fli5bhvszt298H6xIlYWE /SCy84wDaAsfxnambBM/Znw/rLq8ht3qVOi14gpJmV/Gy4YxUI31iVoGuKr8aRZg/KtF U5mtRm0jr9EbsCOpH30swZvGPDi9cHPLveYBKi49ZlIhEZwTi9AGLnE8UXRn8FGBKP4K q0UE5JFf9F88n+9Z/DE1cxvmaKVogFbLJINOifvLeDv986sOgT/1qd2kGBUSdu8AeVUc iqnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=temperror (no key for signature) header.i=@micronovasrl.com header.s=dkim header.b=TbcIC7KS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 82si13965992pfs.40.2018.05.09.11.33.24; Wed, 09 May 2018 11:33:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=temperror (no key for signature) header.i=@micronovasrl.com header.s=dkim header.b=TbcIC7KS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935595AbeEISco (ORCPT + 99 others); Wed, 9 May 2018 14:32:44 -0400 Received: from mail.micronovasrl.com ([212.103.203.10]:59946 "EHLO mail.micronovasrl.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935581AbeEIScm (ORCPT ); Wed, 9 May 2018 14:32:42 -0400 Received: from mail.micronovasrl.com (mail.micronovasrl.com [127.0.0.1]) by mail.micronovasrl.com (Postfix) with ESMTP id 0DA96B0038A for ; Wed, 9 May 2018 20:32:41 +0200 (CEST) Authentication-Results: mail.micronovasrl.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=micronovasrl.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=micronovasrl.com; h=content-transfer-encoding:content-language:content-type :content-type:in-reply-to:mime-version:user-agent:date:date :message-id:from:from:references:to:subject:subject; s=dkim; t= 1525890759; x=1526754760; bh=D31PYvpN3/vTDTNP5RME2lu5Tk7PJ3xb0SU kVL1XtYY=; b=TbcIC7KSBafzBucarIqd/QZxZpaouMk36nqPiV+85FssfqP43BE tJBKRqQYAtho+8J9s3QbZZTX1sMzs2LSmi6eW6pm2cTCd6oMGnLnIuo1vaHbhGmq nXulOCPbbRjh8AEptLzrOtMnFL2xYGFKgUn67YjnOYpF23XK1ve8wlr4= X-Virus-Scanned: Debian amavisd-new at mail.micronovasrl.com X-Spam-Flag: NO X-Spam-Score: -2.9 X-Spam-Level: X-Spam-Status: No, score=-2.9 tagged_above=-10 required=4.5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9] autolearn=unavailable autolearn_force=no Received: from mail.micronovasrl.com ([127.0.0.1]) by mail.micronovasrl.com (mail.micronovasrl.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 4gf6u8QW3UCq for ; Wed, 9 May 2018 20:32:39 +0200 (CEST) Received: from [192.168.2.71] (62-11-51-166.dialup.tiscali.it [62.11.51.166]) by mail.micronovasrl.com (Postfix) with ESMTPSA id F0EEAB000D8; Wed, 9 May 2018 20:32:38 +0200 (CEST) Subject: Re: [PATCH 4/4] rtc: ds1307: add frequency-test property to check calibration on m41txx To: Rob Herring Cc: Alessandro Zummo , Alexandre Belloni , Mark Rutland , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" References: <20180508145611.49072-1-giulio.benetti@micronovasrl.com> <20180508145611.49072-4-giulio.benetti@micronovasrl.com> From: Giulio Benetti Message-ID: <05eb5e80-a38a-1988-bec8-54ba7c6f38df@micronovasrl.com> Date: Wed, 9 May 2018 20:32:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: it Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, Il 08/05/2018 19:44, Rob Herring ha scritto: > On Tue, May 8, 2018 at 9:56 AM, Giulio Benetti > wrote: >> On m41txx you can enable open-drain OUT pin to check if calibration is ok. >> Enabling OUT pin with frequency-test bool property, OUT pin will tick >> 512 times faster than 1s tick base. >> >> Enable FT bit on CONTROL register if calibration is active. > > A DT is (or should be) a pretty static thing, so I don't think this > belongs. A kernel command line option (via module params) or a > sysfs/debugfs file would make more sense IMO. Totally right, it's very useful having it accessible via sysfs. Already changed and just submitted V2 patchset. Thanks -- Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale € 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642