Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <a16db020-045d-a5ba-9106-5f4b4e4920a4@linaro.org>
References: <20180509173819.8017-1-ahiliation@yahoo.co.in> <a16db020-045d-a5ba-9106-5f4b4e4920a4@linaro.org>
From:   Jeffrin Thalakkottoor <jeffrin@rajagiritech.edu.in>
Date:   Thu, 10 May 2018 00:14:40 +0530
Message-ID: <CAG=yYwnZdkJWeA=XhH4q-kfq3+QXrV+BNqgHtS0b9Td=W8fpiA@mail.gmail.com>
Subject: Re: [PATCH] selftests: intel_pstate: Fix a condition which does not
 notify user that root permission is useful
To:     =?UTF-8?B?RGFuaWVsIETDrWF6?= <daniel.diaz@linaro.org>
Cc:     Jeffrin Jose T <ahiliation@yahoo.co.in>,
        Shuah Khan <shuah@kernel.org>,
        Kate Stewart <kstewart@linuxfoundation.org>,
        Philippe Ombredanne <pombredanne@nexb.com>,
        gregkh@linuxfoundation.org, thomas@m3y3r.de,
        linux-kselftest@vger.kernel.org,
        lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

thanks. i will work on...

On Wed, May 9, 2018 at 11:54 PM, Daniel D=C3=ADaz <daniel.diaz@linaro.org> =
wrote:
> Hello!
>
>
> On 05/09/2018 12:38 PM, Jeffrin Jose T wrote:
>> aperf program uses /dev/cpu which is normally a root only
>> access area. so in that case to successfully run thet test,
>> root permissions are required.This patch is in the file run.sh.
>>
>> Signed-off-by: Jeffrin Jose T <jeffrin@rajagiritech.edu.in>
>> ---
>>  tools/testing/selftests/intel_pstate/run.sh | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/tools/testing/selftests/intel_pstate/run.sh b/tools/testing=
/selftests/intel_pstate/run.sh
>> index 23a2e4e9880e..05d35392dcfd 100755
>> --- a/tools/testing/selftests/intel_pstate/run.sh
>> +++ b/tools/testing/selftests/intel_pstate/run.sh
>> @@ -31,6 +31,14 @@
>>
>>  EVALUATE_ONLY=3D0
>>
>> +uid=3D$(id -u)
>> +if [ $uid -ne 0 ]; then
>> +    echo     "-----------------------"
>> +    echo $msg please run this as root >&2
>> +    echo     "-----------------------"
>> +    exit 0
>> +fi
>> +
>
> Other tests simply use $UID. See:
>   cpufreq/main.sh
>   cpu-hotplug/cpu-on-off-test.sh
>   efivarfs/efivarfs.sh
>   gpio/gpio-mockup.sh
>   memory-hotplug/mem-on-off-test.sh
>
> This doesn't take into account the conditions for EVALUATE_ONLY: When
> it's set non-zero, neither aperf nor cpupower run at all.
>
> While this is under review, you might want to base your change on
> Shuah's patch for skipping:
>
> https://lists.linaro.org/pipermail/linux-kselftest-mirror/2018-May/001074=
.html
>
>
>>  if ! uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ | grep -q x86; then
>>       echo "$0 # Skipped: Test can only run on x86 architectures."
>>       exit 0
>
> I'd leave this check at the forefront, as this "hurdle" is
> insurmountable in other architectures, whereas becoming root is attainabl=
e.
>
> Thanks and greetings!
>
> Daniel D=C3=ADaz
> daniel.diaz@linaro.org


--=20
software engineer
rajagiri school of engineering and technology