Received: by 10.192.165.148 with SMTP id m20csp291897imm; Wed, 9 May 2018 12:47:44 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrvRZrhpSV0kPyUPdQIVxKpQCkzh+2e2klGpSk6gGh1PE53XB2q+5FpOjDth+INY18gHBCb X-Received: by 10.98.198.21 with SMTP id m21mr40460738pfg.232.1525895264433; Wed, 09 May 2018 12:47:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525895264; cv=none; d=google.com; s=arc-20160816; b=TzvPUperJazMtVHhT3HWm5GGhRaeZ90FTI9ZpB5c3O0DQG73mN9u3PFodZNaYAILJP oqIkUOCyoNCUxl/58jb1YNW67SgcuoJf6zE530X/ZcILa9ijKJUYYHDEx5iJ6uVZaCC1 09K9GQ+lWH//DaD2/FJZ5HrCI8i/o+nnv9fwLkFUXVUCQ9/hMrRaM6KixzAEmQX4dWOL N79keJQCI1GJsZ5Q48eFTQXHrREvCpQoEV4nlX1lwTg6Yu/YFb7hKX9SeeZPR/fNEkdd grCOZGoP3mUYQo3e/xG//TTEHhAcbqqqyqnCpHhfrzxVMv3DsPpOxlb8jpEpVNFJM1nZ KozA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=la3m9DKTXyHnD2gHVC46pOI2AvnTFCSQEZzqZEWzWu8=; b=vMv06uxTxhM3ly4y2ZZzOshpKUo9i60qgZ+j1N3jKAsww0jog0AUKSzPPgKU3J3HS3 ndYljO4DAvGRXjPYndt+kTy8EJcWAGn0IHI06ew73mWV67YPfd6za/Mmy79GIKN9V3PC mE9wPRj7pRssLI+seCyW9sxQsX9u9BerA4MkOreckFWXe5+3bairKb9TMUn+FYXSYK2g Z+t8ja+816LFsQiuBdhHxEvV3YdeW6taWOUP+tH3EiUIWJ9sULutEHjDXZBDHGFWuc7o f6XN5Z2BfzETh6WHC2r5fByPrX3jXeqqwsBwIMQxvlvGoNiVnJ1G9ZB6suRnA/RYMuyT jumg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d19-v6si22547162pgn.379.2018.05.09.12.47.29; Wed, 09 May 2018 12:47:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965862AbeEITrC (ORCPT + 99 others); Wed, 9 May 2018 15:47:02 -0400 Received: from g9t1613g.houston.hpe.com ([15.241.32.99]:44907 "EHLO g9t1613g.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965181AbeEITq7 (ORCPT ); Wed, 9 May 2018 15:46:59 -0400 Received: from g9t5008.houston.hpe.com (g9t5008.houston.hpe.com [15.241.48.72]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by g9t1613g.houston.hpe.com (Postfix) with ESMTPS id EF28B61696 for ; Wed, 9 May 2018 19:46:58 +0000 (UTC) Received: from g4t3433.houston.hpecorp.net (g4t3433.houston.hpecorp.net [16.208.49.245]) by g9t5008.houston.hpe.com (Postfix) with ESMTP id F109E59; Wed, 9 May 2018 19:46:57 +0000 (UTC) Received: from hpe.com (teo-eag.americas.hpqcorp.net [10.33.152.10]) by g4t3433.houston.hpecorp.net (Postfix) with ESMTP id 7493AAD9; Wed, 9 May 2018 19:46:57 +0000 (UTC) Date: Wed, 9 May 2018 14:46:57 -0500 From: Dimitri Sivanich To: Souptick Joarder Cc: sivanich@sgi.com, arnd@arndb.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] misc: sgi-gru: Change return type to vm_fault_t Message-ID: <20180509194657.GA7219@hpe.com> References: <20180425045044.GA21558@jordon-HP-15-Notebook-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180425045044.GA21558@jordon-HP-15-Notebook-PC> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked-by: Dimitri Sivanich On Wed, Apr 25, 2018 at 10:20:44AM +0530, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler. For > now, this is just documenting that the function returns > a VM_FAULT value rather than an errno. Once all instances > are converted, vm_fault_t will become a distinct type. > > Commit 1c8f422059ae ("mm: change return type to vm_fault_t") > > Signed-off-by: Souptick Joarder > Reviewed-by: Matthew Wilcox > --- > v2: Updated the change log > > drivers/misc/sgi-gru/grumain.c | 2 +- > drivers/misc/sgi-gru/grutables.h | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c > index 3641f13..ab174f28 100644 > --- a/drivers/misc/sgi-gru/grumain.c > +++ b/drivers/misc/sgi-gru/grumain.c > @@ -926,7 +926,7 @@ struct gru_state *gru_assign_gru_context(struct gru_thread_state *gts) > * > * Note: gru segments alway mmaped on GRU_GSEG_PAGESIZE boundaries. > */ > -int gru_fault(struct vm_fault *vmf) > +vm_fault_t gru_fault(struct vm_fault *vmf) > { > struct vm_area_struct *vma = vmf->vma; > struct gru_thread_state *gts; > diff --git a/drivers/misc/sgi-gru/grutables.h b/drivers/misc/sgi-gru/grutables.h > index b5e308b..3e041b6 100644 > --- a/drivers/misc/sgi-gru/grutables.h > +++ b/drivers/misc/sgi-gru/grutables.h > @@ -147,6 +147,7 @@ > #include > #include > #include > +#include > #include "gru.h" > #include "grulib.h" > #include "gruhandles.h" > @@ -665,7 +666,7 @@ extern unsigned long gru_reserve_cb_resources(struct gru_state *gru, > int cbr_au_count, char *cbmap); > extern unsigned long gru_reserve_ds_resources(struct gru_state *gru, > int dsr_au_count, char *dsmap); > -extern int gru_fault(struct vm_fault *vmf); > +extern vm_fault_t gru_fault(struct vm_fault *vmf); > extern struct gru_mm_struct *gru_register_mmu_notifier(void); > extern void gru_drop_mmu_notifier(struct gru_mm_struct *gms); > > -- > 1.9.1 >