Received: by 10.192.165.148 with SMTP id m20csp787055imm; Thu, 10 May 2018 00:05:03 -0700 (PDT) X-Google-Smtp-Source: AB8JxZq5k6KP6dHEFXYQsTEeOIuVCSgj/KweKtrDebPwKkfXMqUMTefuRz8pvrXZGUDjRUNhFmcR X-Received: by 2002:a62:3a1c:: with SMTP id h28-v6mr222908pfa.209.1525935903412; Thu, 10 May 2018 00:05:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525935903; cv=none; d=google.com; s=arc-20160816; b=R87Em3RdO9APlqsJDAF96VUZxPJGCpFDhAz1FPJy4yLxI2QRZG7mTjrzkGadXrPb1n L6V0ENLYK3pmySrPtxVyT5q5PQ22ZQFseSmybrS8fDZwjhePE8m4jYd3p9mR8TN8V1JE PEl7MY2/j9+PWwlCQKlQEFYoCef9jCJg4EGvopcbgYdWDTfgEwQJRur/6pUDmugXTe21 aODzcKY5eEktzebmYSIAfkAf3la6LixksKaVL1UP9uqUogo5jDhVwS82lvscZlNdG3l7 pCbYjKwXFHe2NVkCaJkKX08DTqLMhOZ3d2u35ygqC6fG6eDgkVsv7b/BdonnsuUbbGqD Jb5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=u/fimI4Ptp/Pe5hIptgJgOOLVv8h7VIVb0gEAdGQGrU=; b=AdO1fjjshg7rrLEDMDjEIE9SjU5S49w1ZlMt7fQzLzWq1C7SS177kK/FtSKkJWQRS+ aVzBraYHEw1HmJA4JUTFJOPjTlQ6sDCaw/GuAQgWD/SMZrAsgkRYaySwxgCpwKDl1QCw gXXxMYCtS/teZAdaittHO7hyKWV6UTu5IFC1rNUQbP612SEAqKev5chshGO7U3jJyyzB jhops6ON5kZCHmNUcf04AGvcS9yakj3waWTJUTbehQFsbZ2Qo+U3mSCrQAGcdS7DKMnV IDlWEIVRoWChu3ei/n8lxS52yjXGXnMvm2JGlRYzuM2XfFjWLS9chWxkJ8eO/0fwHKKU EkKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=cLJrlrjM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g7-v6si148941plo.95.2018.05.10.00.04.49; Thu, 10 May 2018 00:05:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=cLJrlrjM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934278AbeEJHET (ORCPT + 99 others); Thu, 10 May 2018 03:04:19 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:60612 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933810AbeEJHER (ORCPT ); Thu, 10 May 2018 03:04:17 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w4A6pHRG109980; Thu, 10 May 2018 07:00:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2017-10-26; bh=u/fimI4Ptp/Pe5hIptgJgOOLVv8h7VIVb0gEAdGQGrU=; b=cLJrlrjMHFOcMt57R0Mn/qm5G9r3kwtGWoiLO+zNMdlAprz67ZJekUG0kyQaiR7jg0TB TWytqNkq4797V9/Mzxe1DRQLGWQApXb/ZesoYl+wwUY+vpPlFeGm8GSlvOxaXO39vBkH ydv29VgW6wKhDz082gSrkhaDe+EwZpTh3bbDxU5ZG3XzRFgL+B90WoOIXvOqYdIvG9PC JXN6VgjK9kSq5bPBbcTXF1fKym3xbzoV/VpEFt7t0Gtjz95uJAYElajdcDCAO9K9nyfM 876XvpnLiO3SEhLUJC9YDXRUOtCq6mFQxyyI6UkvvNC3GHF8c9TERIZKjdu9eQFzxCsH zA== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2120.oracle.com with ESMTP id 2hv6kp24h0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 May 2018 07:00:03 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w4A703nK015853 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 May 2018 07:00:03 GMT Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w4A70034030532; Thu, 10 May 2018 07:00:01 GMT Received: from mwanda (/197.254.35.146) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 09 May 2018 23:59:59 -0700 Date: Thu, 10 May 2018 09:59:51 +0300 From: Dan Carpenter To: Paul Burton Cc: Colin King , Michael Turquette , Stephen Boyd , linux-mips@linux-mips.org, linux-clk@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: boston: fix memory leak of 'onecell' on error return paths Message-ID: <20180510065951.fiojonx5f776z5jm@mwanda> References: <20180509134031.11611-1-colin.king@canonical.com> <20180509140135.4dndt3baomtxups5@mwanda> <20180509163311.alvyibwwuwkumyxf@pburton-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180509163311.alvyibwwuwkumyxf@pburton-laptop> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8888 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=680 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1805100070 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It would be nice to make things static check clean. One idea would be that the static checker could ignore resource leaks in __init functions. regards, dan carpenter