Received: by 10.192.165.148 with SMTP id m20csp1149347imm; Thu, 10 May 2018 06:27:44 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrMEfKi4fvh8tAO1LAPPsGOgo/5Vo9ZuGkx0zND6+Hdzwj5GVFw8NfB90eaRYOYFNeNMj+b X-Received: by 2002:a17:902:b78a:: with SMTP id e10-v6mr1449677pls.260.1525958864788; Thu, 10 May 2018 06:27:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525958864; cv=none; d=google.com; s=arc-20160816; b=jaXcQKGxqpYQOIVLkbx+He86RHnypEVeXtp6VF2Axw+G/w+eCHMxS0Zx+eoLLvTj8b Iu/1N5rLFKaUGlVXbQrdxVzSeWxrKlccZtPS5X6ttTVp8xpOIXX7spmXhaKtjgd9iHUl guYJnYtba1K47cGsE1HcNqTOYLv6mekUDlo8ekQgMmjyKnyRpWpSNmjADQvxYuO5KBKS t89Yfh+VhHyehVzu7faxif84L6/NXihSwuQpbFzaXul5CBexhV9MYFMixQ3lQOmbvWPo wN6MWI4fGH+3sdx5cH4/CaqNZNnniz5lXbriP3yy4yypLTGedlJbqkrDO/4LqtY4WDFO Ke4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=xXLckK4L5qa5cLKjC/fhHtVEjy0yoa+o3lbmWle2N50=; b=VgxXoPO+ze5RvxSwBhyjdojds7dImf05Ce+H/JQBebeLpRbpX8RpBAfRrkU0fgAQcy +JgEsLxBicxY45kW9yydS0sEw1WtwV+7ZevokPmMhhBvbdmoxNpsEvPXxZff1Mnx7D9x raaixdw2T0lvmKnaegr89em3TfSF8UEqGeYx3t0hdf2WFH7ZUOcvMp12bTuSSPZk73X/ mOAlpC2ZB0rvq7FZ+J2/LtiORhkxZMZFb0EBTaZY77P1/Y5ORMaKSEuJTepoZV0zL/S5 sChHVcUMISHe662Qfo8NrMfZITop+WwzyB5CG2mkH7p2VB3g+XSuvta7t3GkFMYKuPLr eVsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xBwUWn6h; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 31-v6si793540plz.364.2018.05.10.06.27.29; Thu, 10 May 2018 06:27:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xBwUWn6h; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757320AbeEJN0G (ORCPT + 99 others); Thu, 10 May 2018 09:26:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:51930 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756998AbeEJN0E (ORCPT ); Thu, 10 May 2018 09:26:04 -0400 Received: from localhost (50-81-62-164.client.mchsi.com [50.81.62.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3C4392173C; Thu, 10 May 2018 13:26:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1525958764; bh=rwng0EaYQ2hNzlAK0zFzRtvbM/Z8FPObb/YP2rELnZk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xBwUWn6hGUlTV364uaw2bWm5A101qzwkeE2DwjQ7NAmtkIFCijIeQFKs6m3fqY/tK 7gImsJJkbNqorivHRAGASYxYcWpG3gJYV5m3LBqFWWhOIQAKgpqVCopC9Z0NH4cyKI N2d8aW7dIRxBzhK+wpMSSJOdh1c5CSdntoP29I3c= Date: Thu, 10 May 2018 08:26:02 -0500 From: Bjorn Helgaas To: Oza Pawandeep Cc: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Sinan Kaya , Timur Tabi Subject: Re: [PATCH v15 9/9] PCI/DPC: Disable ERR_NONFATAL and enable ERR_FATAL for DPC Message-ID: <20180510132602.GF173327@bhelgaas-glaptop.roam.corp.google.com> References: <1525323838-1735-1-git-send-email-poza@codeaurora.org> <1525323838-1735-10-git-send-email-poza@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1525323838-1735-10-git-send-email-poza@codeaurora.org> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 03, 2018 at 01:03:58AM -0400, Oza Pawandeep wrote: > This patch disables ERR_NONFATAL trigger for DPC, so now DPC > handles only ERR_FATAL. > ... > diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h > index 103ba79..86f1cc2 100644 > --- a/include/uapi/linux/pci_regs.h > +++ b/include/uapi/linux/pci_regs.h > @@ -981,6 +981,7 @@ > #define PCI_EXP_DPC_CAP_DL_ACTIVE 0x1000 /* ERR_COR signal on DL_Active supported */ > > #define PCI_EXP_DPC_CTL 6 /* DPC control */ > +#define PCI_EXP_DPC_CTL_EN_FATAL 0x0001 /* Enable trigger on ERR_FATAL message */ There's a tab instead of a space after the #define. The other #defines use a space. Looks the same in the end, but makes the patch look funny. > #define PCI_EXP_DPC_CTL_EN_NONFATAL 0x0002 /* Enable trigger on ERR_NONFATAL message */ > #define PCI_EXP_DPC_CTL_INT_EN 0x0008 /* DPC Interrupt Enable */ > > -- > 2.7.4 >