Received: by 10.192.165.148 with SMTP id m20csp1215141imm; Thu, 10 May 2018 07:22:28 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpTYos+f1ls2qHxoxL/mcVqO4ORrCsiZfelEpBth5t1v2Xwg06L0ys74iyvufJPetAojFd0 X-Received: by 2002:a62:a096:: with SMTP id p22-v6mr1608957pfl.9.1525962148034; Thu, 10 May 2018 07:22:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525962148; cv=none; d=google.com; s=arc-20160816; b=IlYyBjW/jDtdZ5huYNkYDt5ryYWh8mW/ncMEylvQkV+LMLOseJM9HurCGpOznRaLAW vIyYHKC3RzwmFr8as3YzO41T+Ujkaejtii4zHpXiQusTFSSRGpgJKJ5l7reEKSVUkpGm S8PEBv47zC6QYgwpjiqd5vf/z++TVZCR3akYSdJkx5wB1Ksu418ujSoINx+cBuxoIetV dR/O3GghE4JyKlewU3oqBY5TLGbbzlbKkhr7YlweIHBd6qYbxPlODdbLpaNOfQMmv+qc 2WTz4/YggtrO/cG1YKBr5CwfsJgws5ABKuP+pdalB7j72PxRxSTcj4OCtEcdhH+UEg0m IQ4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=lyxKSSnY3RFOMFp8xoslFTWh8HZA4btMnFAzpFct/Ko=; b=piIW4BpeV0l8Y3guI4hmZOUvqDQTKRuOxONbOR9ZsO3Al9dljleSVzPk0p7kaGFluy mQeelI1oOZVIsiOoz2WZt6atEYWBUFsF6Fou1AZCxTi52UZZF8YzSHkGuR/VKJsVDXre FM1DtJB6uzpq/wlk1MaXhofUxQFgjRxi7Cxa0PbexIYMX7DTA8v1vv697HWgbvcrr3JS 1HZoAOHpzuabGojfuvvv54amDnzNX6gG+ssPWr4UAftSzrWAb7Y4bbZbGxOgKAA6vbDZ 1wxxc+zMnkXqbE4/f2gC4fyb3JJcxxlvMKvARhg1WNkVTsKfCv2b4hB23MJN20yBFTz4 HB+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=r/5bgJka; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f3-v6si919708plf.446.2018.05.10.07.22.13; Thu, 10 May 2018 07:22:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=r/5bgJka; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965844AbeEJOVk (ORCPT + 99 others); Thu, 10 May 2018 10:21:40 -0400 Received: from mail-io0-f175.google.com ([209.85.223.175]:39322 "EHLO mail-io0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935628AbeEJOVh (ORCPT ); Thu, 10 May 2018 10:21:37 -0400 Received: by mail-io0-f175.google.com with SMTP id r9-v6so3207060iod.6 for ; Thu, 10 May 2018 07:21:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lyxKSSnY3RFOMFp8xoslFTWh8HZA4btMnFAzpFct/Ko=; b=r/5bgJkaDXwdmFYM5qSJIlHPW1n7Tnz1Exi6fCO+rUxLFqbRtuWLs3x2gdcuZy+FZy m80W9kSugoERLkDnJyU0JVkAXxnoEdkMNJJJVhblab+AvetU3/NsotJPlf9OawEEZkUd fFP8fS9UVNRKPOx4LKwLsD4WofvAUfRmdVO5b006mWAFS+Ogfk6zOJ5+5JgaTamGOhR8 faMp5q+YDWn3G1Qz35/ONtLm2YC/mYxWRjW+JhKAtlAzfLZphADXuKE2QUuSuAMDfgo1 JTPsl/TQI9K0HIiPAAV5kntJH1PvQSoW+ns5LfNdlLZdj+Y52O/gmY1u3BJh6wVo6dC+ TAbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lyxKSSnY3RFOMFp8xoslFTWh8HZA4btMnFAzpFct/Ko=; b=lL5Hb5Lrf4qMoEP7w3rZi+S1Av6lCMd2M/vpwf8kiVcwpyyxnt7PPJbTh2WymmW72N Rjt8zQt7OLILshTfrGVdYTEXKw91CRpy8SqciipI4izpaDk24xvlAFtRU7jKAlwOT9B7 BdtE5gyRMjSSj3X4X4f8jrYq5IaOSxIO4wjWfcbIP4od3XmRBc4DCcf8v4G1PoHzbzPQ ZujiHVpKrMlWrCavovI8EdHNLSn6AT/ejbPrApgFwlD38flLE7/lZZUobDfxRkVS8DFp 8MI4fYNv5AAmzn+p4AUcMbMDgMu4ETUaLW3W57y88Y027tIUiEqDcF69v1aX9K3mNSpG Swmg== X-Gm-Message-State: ALKqPwcuGHS+Bnrhxh/xbrGOei/apOKD0j/HL8SSYqHVoKwVamdZla4f WToSQCqGG6aYnAEJX4vkSHbXKA== X-Received: by 2002:a6b:ba46:: with SMTP id k67-v6mr1662243iof.289.1525962096992; Thu, 10 May 2018 07:21:36 -0700 (PDT) Received: from [192.168.1.167] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id h197-v6sm516177itb.27.2018.05.10.07.21.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 May 2018 07:21:35 -0700 (PDT) Subject: Re: [PATCH] mtip32xx: Fix an error handling path in 'mtip_pci_probe()' To: Christophe JAILLET , ming.lei@redhat.com, martin.petersen@oracle.com, sagi@grimberg.me, chris.gekas@gmail.com, bart.vanassche@wdc.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20180510072731.19956-1-christophe.jaillet@wanadoo.fr> From: Jens Axboe Message-ID: <1c91e861-9f38-4c77-d7ac-1a1499932c1a@kernel.dk> Date: Thu, 10 May 2018 08:21:33 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180510072731.19956-1-christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/10/18 1:27 AM, Christophe JAILLET wrote: > Branch to the right label in the error handling path in order to keep it > logical. Looks good, applied. -- Jens Axboe