Received: by 10.192.165.148 with SMTP id m20csp1236162imm; Thu, 10 May 2018 07:40:34 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrx/B3x82xs86mW29Oh/VswLOQXMuj6ckYc7N9jzfE2NH8QZ087Sad6YXy8gpEaksYE4wUb X-Received: by 2002:a63:6b43:: with SMTP id g64-v6mr1360084pgc.337.1525963234781; Thu, 10 May 2018 07:40:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525963234; cv=none; d=google.com; s=arc-20160816; b=sujsytdsWfKmTRvQ0zk7xSkgCOwkHyI7x0iM7UEp67hLlGeeg8b4igDD/LKx6hn2ZF 3Li4fAzsGU+30SjsyUZUkBLKToF9ldKvaHt/AtUi44WEBl+ouoiNElxEQN9vuOGV8pOa Z2zSX6Q+JSTmH3J+ZwnepJm/j1X4TAACy/KcGK/tZEEH4tnqo5RRoAJ9hiPurhVwouHh z446c+SHnW0erHxbWHq8bKDrrmLmejgh8A+kUXBalWpGqYbbE9imY/UkBUR84bTLY29S 9wQ97B2NbsgKEBt+U/6295RunXVJGu/NfTlYfztsbUia6WNUGhwTlox74WhDFjyhc+S+ wQJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:newsgroups:cc:to:subject :arc-authentication-results; bh=2agxC29ZyBekg39E0Cksz/AHfz5AhjmvyG10uHyPZOE=; b=lsVHLivztPK+/Bg8PaPjJDu9+l4EV2Z1BJuo5/BCwIubcA+E1t1zzVUurhs7sZGCMP 1KR0wnm4fRSPdMSMLqMMzaTIRw6amJ0Dcoq2qUe6x8T5fWkcUzr4bIX+iLX8tIzZC6MW yIh6TdRGX+a1K9cR5wfw8DyAuG9UKsTxTB6EWPPg1SltxUJPrMzk5K3s9qV3wYCp8z5j fzlr4xZObT8tr/OaCDC7R6/VfHQBnbjkKfKUsKLqmvi5tePuNepMyCEhiukyME0lXYRN CV/V6eAF8VdA/2cQF8mSrtyXBv/2recXxcq29bnEIti9rTr/iNKhPXFVnQjJKRihHtTz Ti3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t190-v6si752040pgb.623.2018.05.10.07.40.10; Thu, 10 May 2018 07:40:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966157AbeEJOig (ORCPT + 99 others); Thu, 10 May 2018 10:38:36 -0400 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:18680 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935679AbeEJOid (ORCPT ); Thu, 10 May 2018 10:38:33 -0400 Received: from [192.168.1.12] ([86.244.116.1]) by mwinf5d24 with ME id keeU1x00901t9Ri03eeUbG; Thu, 10 May 2018 16:38:32 +0200 X-ME-Helo: [192.168.1.12] X-ME-Date: Thu, 10 May 2018 16:38:32 +0200 X-ME-IP: 86.244.116.1 Subject: Re: [PATCH] net: aquantia: Fix an error handling path in 'aq_pci_probe()' To: Igor Russkikh , davem@davemloft.net, pavel.belous@aquantia.com, weiyongjun1@huawei.com, dan.carpenter@oracle.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Newsgroups: gmane.linux.kernel,gmane.linux.network,gmane.linux.kernel.janitors References: <20180508063947.11317-1-christophe.jaillet@wanadoo.fr> From: Christophe JAILLET Message-ID: <2369a016-547d-65e1-9ba7-9a6d16cda41a@wanadoo.fr> Date: Thu, 10 May 2018 16:38:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 08/05/2018 à 09:19, Igor Russkikh a écrit : > > This was just submitted yesterday and is already accepted in netdev by David: > > http://patchwork.ozlabs.org/patch/909746/ > > Thanks! > > BR, Igor > Patch timing is sometimes surprising! Not sure at all if it can be an issue, but I also noted that the order of 'pci_release_regions()' and 'free_netdev()' is in reverse order in the 'aq_pci_remove()' function. I don't know if done on purpose and/or needed, so I've left it as-is. CJ