Received: by 10.192.165.148 with SMTP id m20csp1351666imm; Thu, 10 May 2018 09:21:18 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrkyrlO2zkMkJBG4iE+Brc26aCK0Xm/Jif1FtmHlE5qCH5c/RYuRg77MksoVFSlvV6kyfPJ X-Received: by 2002:a17:902:3225:: with SMTP id y34-v6mr2041211plb.180.1525969278094; Thu, 10 May 2018 09:21:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525969278; cv=none; d=google.com; s=arc-20160816; b=y3lLHdEZ/plK9PeSWzdk1eSUKjUtcCG9OT1vQIggfmEA5qTwbYET7+3JL/KqWrZr4P 57aAr/3ruF9AIyIx1zOE0h+NmY59KohhNrkkBFyzZ+iBFa36wNMwkc931tW+ZhPEtqRF h0ijtyvvHHn9ZiADIcIM8VbeJNvkqDc5n57Ze2YnBftd4A9r79R9USONsmcvFJDhdLZv Mm8tzkbqNhJfARjmu81Qaes1WnpyTESnLynT+Zd/U+liSDok1j50m5UVY+7St87Wrv8/ Il/QG5RcnMkSN7+OpNBj+aHn4trHvD1Wi9xzMSARQK3kgUMhmvWEQiaT81mJaJwyXBQ7 5HVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=Ex34gkVX+TssW0vbvhAAeYNQqVvCMP+y84Bqc3wWlE4=; b=PziP9uJuJ7IKuEVDvddqDpeSZhq7I4550ZUzrtudxXnYD/Wa11Hi27jAvvdF2WF/Oh D46RKWbzJxgmJ1M6297m/J+qB/YDNgomPxTknAfmuYuXzspVO6Gu91m3R3LZx6HjW9ht Zvuxb9cagUU9osabg7qD5BR/uBnJuukQjK573m3pdjP9k8mHZn4OHufDYG4NQF/lsDa8 s5VwcalDhi5YsXR/kvBbT22I2VjZOqy9vCQfhoK4Hge9SrvkRNXWQgAkhHqQxM3zM6HA fooXE47ca+ltneExEjFS2C689QHx2R80s84gNJioLUHyMBtD/O9Y7BqOgL+NpXa8X7yh TIVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u14-v6si1126199pfa.84.2018.05.10.09.21.03; Thu, 10 May 2018 09:21:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966277AbeEJQUw (ORCPT + 99 others); Thu, 10 May 2018 12:20:52 -0400 Received: from mail.skyhub.de ([5.9.137.197]:34234 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935410AbeEJQUv (ORCPT ); Thu, 10 May 2018 12:20:51 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Oj9H3yJvxF-d; Thu, 10 May 2018 18:20:34 +0200 (CEST) Received: from pd.tnic (p200300EC2BC8BE00CCA7BC9076439171.dip0.t-ipconnect.de [IPv6:2003:ec:2bc8:be00:cca7:bc90:7643:9171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 3D57A1EC0333; Thu, 10 May 2018 18:20:34 +0200 (CEST) Date: Thu, 10 May 2018 18:20:28 +0200 From: Borislav Petkov To: Alexei Starovoitov Cc: Peter Zijlstra , Yonghong Song , mingo@kernel.org, torvalds@linux-foundation.org, ast@fb.com, daniel@iogearbox.net, linux-kernel@vger.kernel.org, x86@kernel.org, netdev@vger.kernel.org, kernel-team@fb.com, Thomas Gleixner Subject: Re: [PATCH bpf v3] x86/cpufeature: bpf hack for clang not supporting asm goto Message-ID: <20180510162028.GB16130@pd.tnic> References: <20180504033119.2130788-1-yhs@fb.com> <20180510100634.GZ12217@hirez.programming.kicks-ass.net> <20180510155240.5s2fpgm2fwal3jlj@ast-mbp.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180510155240.5s2fpgm2fwal3jlj@ast-mbp.dhcp.thefacebook.com> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 10, 2018 at 08:52:42AM -0700, Alexei Starovoitov wrote: > That makes me wonder what happened with "we do not break user space" rule? As someone already pointed out on IRC, arch/x86/include/asm/cpufeature.h is solely a kernel header so nothing but kernel should include it. So forget the userspace breakage "argument". -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.