Received: by 10.192.165.148 with SMTP id m20csp1508263imm; Thu, 10 May 2018 11:49:17 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrNkisjbwTUsZximPUJP6rYt7wGhOdDd7ZCanRjXj3+Uh3JMgt8GhgExYYwxtGQBeFdgNCB X-Received: by 2002:a17:902:b087:: with SMTP id p7-v6mr2390410plr.227.1525978157121; Thu, 10 May 2018 11:49:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525978157; cv=none; d=google.com; s=arc-20160816; b=OUKhUgdDOmrUyZqprxsX0HhvdKTg8vLpeIvmh9z6rjvfdIgyrWEsE5TyD2cmMlpWrw tEeDQBHnKN1FBOXjNezLnOAxh4o4WuZJpsiRQUd3oj3Pp0DJLLO29GH4AiPYAHOnmA2z P47K+Yy0gPlCdZLSjkqMXoUgmROvqBTGmvju6VM2LEzODLaxqoLF40Pwf2osHMTf4Q4i KrKsKfqoMUW4aH0Bi2jDb6xxoogMmqUbLOGAEthFx+wLGZcXN4EdCq29Hw3j+W3OYcVM LBwNW71o/eThmJmE6+TjgdkpZ/vAtyDoRV7TwTw+N/9hHc8C+/bmqE0jtIrCajDuQIdr yllA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=cho6jdLmU1bygSxSTOFRHZE2MnT+tIBVQx8REcN8NuQ=; b=YS17ef0mjQIXEnW6WvdieqmZ3nXpHXxbXNpHE141HyuKYx9BRx3AKuMyRsJR27nRcT N8ktlB3TtyIIl/S6waGAWmBfuNmgNwCU5QSemm/He2ZLO64hNWzJ9PbqfPDMepHSHKB4 diC0aJ7pmDh+OhVfuqJzfOnqm5iQ19POObAOlK1rlZdVDGURjXCiwza+4mer3hwYNszp 6sPFjxhpjicSrN0y09heBEGZQmInCFcgoOdgYyR8ibjOO68HaFhi2ZEePIezDosFrOv0 5rCHWEtv/GBx68c/372c1J++O7kM9R8o5jQvXGmoY6j+WYN7+RTlcT0MkIlwqHEVMsRf 74bQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=QQlqA2L1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x63-v6si1309929pfi.162.2018.05.10.11.49.01; Thu, 10 May 2018 11:49:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=QQlqA2L1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752002AbeEJSsk (ORCPT + 99 others); Thu, 10 May 2018 14:48:40 -0400 Received: from outils.crapouillou.net ([89.234.176.41]:56608 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750972AbeEJSsh (ORCPT ); Thu, 10 May 2018 14:48:37 -0400 From: Paul Cercueil To: Guenter Roeck , Rob Herring , Mark Rutland , Ralf Baechle , James Hogan Cc: Wim Van Sebroeck , Mathieu Malaterre , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Paul Cercueil Subject: [PATCH v3 6/8] MIPS: jz4780: dts: Fix watchdog node Date: Thu, 10 May 2018 20:47:49 +0200 Message-Id: <20180510184751.13416-6-paul@crapouillou.net> In-Reply-To: <20180510184751.13416-1-paul@crapouillou.net> References: <20180510184751.13416-1-paul@crapouillou.net> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1525978115; bh=cho6jdLmU1bygSxSTOFRHZE2MnT+tIBVQx8REcN8NuQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=QQlqA2L1oVOBrQjgDFa7Xah1W1Ne4QuMy6fHbuUHyrNrZTpSSzvnomOmajRP9lcDVYDKBZ5rSIIs6qJ16rMGKJ3oJjVJ3TjUgF1ZVFMg7ngJK09PUXfwXHV26Ex7Acs7XUkp+wnWECCzEnrEC0vnzlEo8K36Xhl24u0kirXTBuw= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org - The previous node requested a memory area of 0x100 bytes, while the driver only manipulates four registers present in the first 0x10 bytes. - The driver requests for the "rtc" clock, but the previous node did not provide any. Signed-off-by: Paul Cercueil Reviewed-by: Mathieu Malaterre Acked-by: James Hogan --- Documentation/devicetree/bindings/watchdog/ingenic,jz4740-wdt.txt | 7 ++++++- arch/mips/boot/dts/ingenic/jz4780.dtsi | 5 ++++- 2 files changed, 10 insertions(+), 2 deletions(-) v2: No change v3: Also fix documentation diff --git a/Documentation/devicetree/bindings/watchdog/ingenic,jz4740-wdt.txt b/Documentation/devicetree/bindings/watchdog/ingenic,jz4740-wdt.txt index cb44918f01a8..ce1cb72d5345 100644 --- a/Documentation/devicetree/bindings/watchdog/ingenic,jz4740-wdt.txt +++ b/Documentation/devicetree/bindings/watchdog/ingenic,jz4740-wdt.txt @@ -3,10 +3,15 @@ Ingenic Watchdog Timer (WDT) Controller for JZ4740 & JZ4780 Required properties: compatible: "ingenic,jz4740-watchdog" or "ingenic,jz4780-watchdog" reg: Register address and length for watchdog registers +clocks: phandle to the RTC clock +clock-names: should be "rtc" Example: watchdog: jz4740-watchdog@10002000 { compatible = "ingenic,jz4740-watchdog"; - reg = <0x10002000 0x100>; + reg = <0x10002000 0x10>; + + clocks = <&cgu JZ4740_CLK_RTC>; + clock-names = "rtc"; }; diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi index 9b5794667aee..a52f59bf58c7 100644 --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi @@ -221,7 +221,10 @@ watchdog: watchdog@10002000 { compatible = "ingenic,jz4780-watchdog"; - reg = <0x10002000 0x100>; + reg = <0x10002000 0x10>; + + clocks = <&cgu JZ4780_CLK_RTCLK>; + clock-names = "rtc"; }; nemc: nemc@13410000 { -- 2.11.0