Received: by 10.192.165.148 with SMTP id m20csp1548182imm; Thu, 10 May 2018 12:27:51 -0700 (PDT) X-Google-Smtp-Source: AB8JxZp3jMipG6zKB67uv0VcHxP+E/Z+XjwFRpR+sl8u4qkbsMfJD9AWYG/iqlx4wV4AG/ouW7n2 X-Received: by 2002:a17:902:bd46:: with SMTP id b6-v6mr2534220plx.170.1525980471234; Thu, 10 May 2018 12:27:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525980471; cv=none; d=google.com; s=arc-20160816; b=gUvy5Izmpcn+/5XRAbxXJa27WdrN/Tk9hQ2ZnJDsDDjd027HqmbNdYirAKE3MCh6g0 rX26nPRxW+4HWgsVjYMm+yVTrua+8NbRF92PGL1xGh+68TvuBvdpnanpxFdTzVkC5C7F RPL9TSLtG6YaDwxglTutdohfcXSBKnCdatKMKgbO2kmVALPXb0mmdzzVoejSG0CICyPK w0COvUsTXrl8ZJNKm44RyaUcumDmZaflGmEzhKaKlqKp6Ne9CTUT9gllNxHG0VGIAsc+ qesfWis6gFn11f0lLQZJq8+VfqmEAOXoYO4WriNECZvb+XUKpAg+zV8LXNyIaxvoch2l CCxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=dqqUzs6kNjPQhtC91oPS8f4Ybbg6qEcy6OM1Lzrd38w=; b=veLIWXnet3waqEvwXF3tBTRKIAKjH1S/jXax7Jvyn3q7m6J6FrhUwQExriiJ4kJbQV 7me2mY11WtRqq1UihFe2V6zOAQ4/Vv2nDZS3sm16iGaNXqSA4mFhHEehs21gTF1kkT7Z YQMsRsoX63YrhyOo+KaQYJ7j4UyyIpp61BMBzQA30qDGWPLlEbk1zVD8bdPioo+w0CBK l+YXhCDcX2PgBGgBRkvFG2qt5IAMx5+x8GLaYbzB/3eoAUA7OidF8bs3RuZ88X911h7j FdYQwDoCFx1KkiYvkoHeRmACgCuuYTw4xGsH4hPSb/vNXraI92bls0sJ7HxTI0p9f2Go GBgA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p11-v6si1437132pfj.294.2018.05.10.12.27.36; Thu, 10 May 2018 12:27:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751880AbeEJT1Y (ORCPT + 99 others); Thu, 10 May 2018 15:27:24 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:36008 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751096AbeEJT1W (ORCPT ); Thu, 10 May 2018 15:27:22 -0400 Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B5990133E8162; Thu, 10 May 2018 12:27:20 -0700 (PDT) Date: Thu, 10 May 2018 15:27:19 -0400 (EDT) Message-Id: <20180510.152719.500625126905254406.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, petrm@mellanox.com, jiri@mellanox.com, idosch@mellanox.com, ivecera@redhat.com, stephen@networkplumber.org, andrew@lunn.ch, f.fainelli@gmail.com, nikolay@cumulusnetworks.com, bridge@lists.linux-foundation.org Subject: Re: [PATCH net-next] net: dsa: fix added_by_user switchdev notification From: David Miller In-Reply-To: <20180509030312.29548-1-vivien.didelot@savoirfairelinux.com> References: <20180509030312.29548-1-vivien.didelot@savoirfairelinux.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 10 May 2018 12:27:21 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vivien Didelot Date: Tue, 8 May 2018 23:03:12 -0400 > Commit 161d82de1ff8 ("net: bridge: Notify about !added_by_user FDB > entries") causes the below oops when bringing up a slave interface, > because dsa_port_fdb_add is still scheduled, but with a NULL address. > > To fix this, keep the dsa_slave_switchdev_event function agnostic of the > notified info structure and handle the added_by_user flag in the > specific dsa_slave_switchdev_event_work function. ... > Fixes: 816a3bed9549 ("switchdev: Add fdb.added_by_user to switchdev notifications") > Signed-off-by: Vivien Didelot Applied, thanks Vivien.