Received: by 10.192.165.148 with SMTP id m20csp1558295imm; Thu, 10 May 2018 12:38:02 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoNqDUd7/tsIWnTQIza1hR1F/wjm0RmSAvmiAzfgO4mmlu59HEOW0/787RlCCmzGIKZWfZP X-Received: by 2002:a62:14c3:: with SMTP id 186-v6mr2571543pfu.92.1525981081961; Thu, 10 May 2018 12:38:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525981081; cv=none; d=google.com; s=arc-20160816; b=b5s5yFONxy6TxheGbR1Hwr0l//qS8Vp8vWmOejjmt6S0vUm53dFwCIBlN5v20MnSH1 0+Ff75Qg8X8jxAK4em2pExzei7kqg25bKqcM6XEbH+QmYjh56Ykxiy7xTa7gfTihVIZu Cz4/XACacnVuyrkLye4xwjWL0SnarLMjoHGFQL+ZdBE7i4NS3aRFNH9FgMaFLTU6ycNJ JdF6wffXcz0LRPpOQQktAEBzxdM/mbRNqB1+QRG8ntACGTApjuOvKkYKc8MckWB4bf3I SyjkD319GLTKwquXEogwva8d6rJF08jJZxWGuQk5Vx7uJqr42IHF7rvg3qnS96ZH1Amr eUfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=gtJXp5w3zXR3U1F9o1oefDpFuK7AZR0hsAzk8cvR55Y=; b=EliWlqDi83yqjjNb4X/e8lZ6r/I7GJiTvzuCH1o7QH6aKWz9svOy8ytQK+RKugjp80 ry5vgXo03yL12p3lYhnRfkEddbTD7F5WqrlPhh1rDZP29aCsJ2IAi2bAUnVhcmrnJOV/ lHi57P3Ki5oen4Vepj01ZwOx4IIKU95H/fzFwRPZCGrVS6gq3fYwUgDgPUq36WISV4CA tn33GLiM+g63+TASrktz32TVHRMOa3pFABQH3AKvTnkZ6Mm0dw/06f/WjnxdS+2v+5Fn ZRKRANSA4PbqFr4WDyJoG6oekZdrMbn6WgB4iSTkIh48iEdMcF6tFzVb2DbAse4Xf8ny 3kGg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k28-v6si1240390pgn.129.2018.05.10.12.37.44; Thu, 10 May 2018 12:38:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751660AbeEJThd (ORCPT + 99 others); Thu, 10 May 2018 15:37:33 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:36144 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750747AbeEJThc (ORCPT ); Thu, 10 May 2018 15:37:32 -0400 Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 38319133E8162; Thu, 10 May 2018 12:37:31 -0700 (PDT) Date: Thu, 10 May 2018 15:37:30 -0400 (EDT) Message-Id: <20180510.153730.348233195080672901.davem@davemloft.net> To: mgamal@redhat.com Cc: netdev@vger.kernel.org, sthemmin@microsoft.com, kys@microsoft.com, haiyangz@microsoft.com, devel@linuxdriverproject.org, vkuznets@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] hv_netvsc: Fix net device attach on older Windows hosts From: David Miller In-Reply-To: <1525853854-8277-1-git-send-email-mgamal@redhat.com> References: <1525853854-8277-1-git-send-email-mgamal@redhat.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 10 May 2018 12:37:31 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mohammed Gamal Date: Wed, 9 May 2018 10:17:34 +0200 > On older windows hosts the net_device instance is returned to > the caller of rndis_filter_device_add() without having the presence > bit set first. This would cause any subsequent calls to network device > operations (e.g. MTU change, channel change) to fail after the device > is detached once, returning -ENODEV. > > Instead of returning the device instabce, we take the exit path where > we call netif_device_attach() > > Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic") > > Signed-off-by: Mohammed Gamal Applied.