Received: by 10.192.165.148 with SMTP id m20csp1595241imm; Thu, 10 May 2018 13:15:06 -0700 (PDT) X-Google-Smtp-Source: AB8JxZomFzSs60ATtw9zO8mb3+X60/wgdC+hyQy9hswMCu9LCTujJP1925fQr/a3WbbwU2F7LH0B X-Received: by 2002:a17:902:264:: with SMTP id 91-v6mr2632233plc.341.1525983306119; Thu, 10 May 2018 13:15:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525983306; cv=none; d=google.com; s=arc-20160816; b=rDjzIxO/B0kKQmvuCenjt9PgV7Ts2Kfr46dkQuZwQGSJ9HBbLYBVgPAn7nXnqdxBGu zf+6Jmv5x60MbF9g950IQ2Pt7bVfVu+S96/0E1+Bc1U93DXcOJ76AfDbUwQPvYPE///Y ubPyGSLJO3ToIpTo/Ra+OQRUhrZmn2UAcNIIn2T9WqV+QhOu7YKEsLR1BP37ZocS1vYJ TJ0CfAalisVfB5HzN5aNTRwmRSMIpDGnUKpkr4/A5ZZZ9j8lac9+68UmAfn2GMz5xMZU zCFTpeRe4SITdzmWnZMzQ5WINlsX4pAmWelCRl3CQxdj7zM4foiOL4zRpSciMiUVqvsk 16fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=l9mJbANzdO4iATx1U2p15LNuKjQ4QV+YlbelbxTy+K8=; b=iof2Z2Xg/InuGFSkMczuH5kD7JNY7RZLLiPEZY7EhrDlN0MiZTKX8lJdq5p2FUM8fp fZVNtD0FjTbSSDToiU+qzes/0Y/LuEraLpGG4WasnbxWtwF4ARNhdV5pSKm6vBhfCljn jc2RsPQyp5cGelNkW6Pag0/12muR/es/Y6RrbbMkAAI8G/HgtlZMe8X6pkfDaSNnBXY/ h0IoL6SeIWjo+Lz931uEwds8Ur7hJUVQXBABQ0gmy6BetkuAJg8R21QQGwlcSpVlLet1 6jheZMGV2ov9qh02dPPJyyTV5nMnwvoAlbNrQnqJooCmuGT5EiOE+Ygye1H7W8CUuOA+ 2OkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x2-v6si1444367plv.388.2018.05.10.13.14.51; Thu, 10 May 2018 13:15:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752620AbeEJUNP (ORCPT + 99 others); Thu, 10 May 2018 16:13:15 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:36730 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752101AbeEJUNM (ORCPT ); Thu, 10 May 2018 16:13:12 -0400 Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 944D4133E8163; Thu, 10 May 2018 13:13:11 -0700 (PDT) Date: Thu, 10 May 2018 16:13:10 -0400 (EDT) Message-Id: <20180510.161310.1711109503750888571.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, andrew@lunn.ch, f.fainelli@gmail.com Subject: Re: [PATCH net-next 0/3] net: dsa: mv88e6xxx: cleanup Global Control 2 register From: David Miller In-Reply-To: <20180509153851.10207-1-vivien.didelot@savoirfairelinux.com> References: <20180509153851.10207-1-vivien.didelot@savoirfairelinux.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 10 May 2018 13:13:12 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vivien Didelot Date: Wed, 9 May 2018 11:38:48 -0400 > The mv88e6xxx driver still writes arbitrary values in the Global 1 > Control 2 register at setup, which layout differs a lot between chips. > This results in an inconsistent configuration, for example with the > Remote Management Unit (RMU). > > The first patch adds an operation for the Cascade Port bits, the second > patch sets the device number in the device mapping function and the > third patch adds an operation to correctly disable the RMU. Series applied.