Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp26251imm; Thu, 10 May 2018 14:48:16 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpfysoQYy5RZIBIpbgvtU5kYgp4w1eZRqb3udRhtPl0BW6odQNo8LoalW+k3jNFwEWxaKCK X-Received: by 2002:a62:1f03:: with SMTP id f3-v6mr2898118pff.213.1525988896633; Thu, 10 May 2018 14:48:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525988896; cv=none; d=google.com; s=arc-20160816; b=BSi9iKOaFTELQQrcy217ytTOiyYFPuPoTTKIr1h1sFYuOpmTiqnpxbYBSJPHgpcATu eJUAII00gByUMZu/9LIBXh4FWXKRotufvRdoRLT/d5LuwpzgIO5CK/17cI34tUbup1qv ZScxBfYd3z6kHD8HkrzM09yFY9VO2nYpKAFudFWjnx61tZrYRZGwclI4mpApS/ejtLoG loNLir1gMfJ/bTsKfswYhVtfhT9h/u+uIQ4TwViyKv3vzUcso0i9Bfl/EATkrx8P4tMU WIRC1MWwtSnKBDYiR5E5tG0vPWvnQCY69Q1EE1JxsVP0YB8TzLhYMrh9OeI30UYAHhVx n6PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=jKyI6GMJkf/hKui2+Hn7WN3dZsg2L/2gJlaJHsOo+BE=; b=lWl+MxPjwXNHXRWsau1My4BMR0reNaYZoFHaEI96CXcb64EcWNXJkWxm7JN2SShMRC ePqSZPRIsTfC2mis8Ca8wDL768IzJGMxQP5UXX+twW/12Uy5a8ieTCK4DtpVO6Nj3U// e7VOccjU9FjN+S9wLb+XwSHDT0xGybzNQK46b+nlmCtTUvY7I2RfUYrXI20URlI765w9 LdzogKBErA/xkyFXbIIkku6ALnUyruPT8tiSIngwvMaZiDh7lfF9QskwJ1WLGuTHmX8N oCgm7dSUuIZZUF80C8Y+4MeuD/E81kLYOxAMRvbgYJ7mXBRg/ww1Nr5bnXIkoJI/Gfy6 sS6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k5-v6si1422582pgo.0.2018.05.10.14.48.01; Thu, 10 May 2018 14:48:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752638AbeEJVrt (ORCPT + 99 others); Thu, 10 May 2018 17:47:49 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:37774 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752298AbeEJVrs (ORCPT ); Thu, 10 May 2018 17:47:48 -0400 Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 59FA3133E8164; Thu, 10 May 2018 14:47:47 -0700 (PDT) Date: Thu, 10 May 2018 17:47:46 -0400 (EDT) Message-Id: <20180510.174746.56190527987284941.davem@davemloft.net> To: christophe.jaillet@wanadoo.fr Cc: tariqt@mellanox.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v2] net/mlx4_en: Fix an error handling path in 'mlx4_en_init_netdev()' From: David Miller In-Reply-To: <20180510070604.19635-1-christophe.jaillet@wanadoo.fr> References: <20180510070604.19635-1-christophe.jaillet@wanadoo.fr> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 10 May 2018 14:47:47 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET Date: Thu, 10 May 2018 09:06:04 +0200 > If an error occurs, 'mlx4_en_destroy_netdev()' is called. > It then calls 'mlx4_en_free_resources()' which does the needed resources > cleanup. > > So, doing some explicit kfree in the error handling path would lead to > some double kfree. > > Simplify code to avoid such a case. > > Fixes: 67f8b1dcb9ee ("net/mlx4_en: Refactor the XDP forwarding rings scheme") > Signed-off-by: Christophe JAILLET Applied and queued up for -stable, thanks.