Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp77380imm; Thu, 10 May 2018 15:51:59 -0700 (PDT) X-Google-Smtp-Source: AB8JxZp2TpkYkcmcZgbbd1Bm3NrBnGQn6w904rh4kMd1Rs1qjx5/zjOCjZqZPiyVW/JVRt0NFZup X-Received: by 2002:a17:902:1c7:: with SMTP id b65-v6mr3027130plb.298.1525992718960; Thu, 10 May 2018 15:51:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525992718; cv=none; d=google.com; s=arc-20160816; b=y2Qu3dpqase08N9xijZPr7KEoT4CYU7hZM/5g9zG1TKMXbpnTqbh35rn1k/HAANypJ KYxtl6qr07rBDalmw9kwKhsjm8hGsOD9MOKWMraDZfsOBVl3hTStKHd3wgKrflz10AR3 TvhWcsk2kbUrX3gqirk6eP999z3gjIeJf1M7TFPqTW1HPAPtNqzeY4oGb95qhdRWb/FV rdrZ40qbwrMqgXn7asffv6JRFSAbNsC6fEVHrWQ2duNtSUOR6OoXIQU3FJk9qTdegeES ypX7tZqS7Vww/JlKcr7AOcP0v3A2y3DvP16nGNIkDR4jCcK/SePmactnFNMHxBgK2Buq 7l0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=DZQToXTiFykeIGQUwrssQYXiNpU35jRhIqK+lS4TcXU=; b=XcaX0zLvVIaI+DypIKb2tPhrO130ijI5iWjl8wD+PiMgfaWO55oEhqjeTYSHP8i/cL a94ZgzHOA0e312xaVl9rWZ2VDHZz9VWpCogrdMDxH4fOqHnpTAYUEW2m05H5X6AnoNx/ eeOvMJBMg5a2SRl7V5ApxEjgOgTC/cDtXEQ7gCJXFGT8kqzhmt13Ou7C+sI+ks7Quacz RMiawLeIxIWbiwk1s8VwY7dRue0DZ+wAmRiVCjj/sSyb5rGeiE1JwkYX9Pn7uGF5oXJY 7Qel4AOPtQLd1SkxzTM447YzF8kWm0CKNdfAYWTaFr/uP50WwnYZA+QE4vbfsetR10kg 6APw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2EGrhc9u; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k10-v6si1369253pgo.23.2018.05.10.15.51.43; Thu, 10 May 2018 15:51:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2EGrhc9u; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750855AbeEJWvf (ORCPT + 99 others); Thu, 10 May 2018 18:51:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:55136 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750711AbeEJWve (ORCPT ); Thu, 10 May 2018 18:51:34 -0400 Received: from localhost (221.sub-174-234-128.myvzw.com [174.234.128.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9BB372173C; Thu, 10 May 2018 22:51:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1525992693; bh=5Ozp1ByypeKjtCcd/nX5INV57/rk6Rodtbr0VG7o+Ws=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2EGrhc9u1JPIfxrmMaENE8IPyuS5n0avLV5cc3BHfCHojyj8yi0Zk+dQW3cKyx5ov E9nRw24rgAQg3M63Qn+Hv5XfrVLmB/Gm5O5JBDC0y4BIFexYSOlzwBF0Ppox8NFHbg LzJ05YoU0fGstfdlJQslTigBMPlubxvSk0K8MHvk= Date: Thu, 10 May 2018 17:51:32 -0500 From: Bjorn Helgaas To: Jan Kiszka Cc: Bjorn Helgaas , Linux Kernel Mailing List , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jingoo Han , Joao Pinto , Lorenzo Pieralisi , Will Deacon Subject: Re: [PATCH v2 00/10] PCI: leak fixes, removable generic PCI host, assorted stuff Message-ID: <20180510225132.GD190385@bhelgaas-glaptop.roam.corp.google.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 30, 2018 at 07:48:34AM +0200, Jan Kiszka wrote: > Changes in v2: > - patch 1: commit message reworking as suggested by Lorenzo > - patch 3-6: split-up as suggested by Bjorn > - patch 8: new > - patch 10: select PCI_DOMAINS from PCI_HOST_GENERIC, rather than > allowing manual choice, as suggested by Lorenzo > > This primarily enables to unbind the generic PCI host controller without > leaving lots of memory leaks behind. A previous proposal patch 5 was > rejected because of those issues [1]. > > The fixes have been validated in the Jailhouse setup, where we add and > remove a virtual PCI host controller on hypervisor activation/ > deactivation, with the help of kmemleak. > > Besides that, there is tiny PCI API cleanup at the beginning and > support for manually enabled PCI domains at the end that enables the > Jailhouse scenario. > > Jan > > [1] http://lkml.iu.edu/hypermail/linux/kernel/1606.3/00072.html > > > CC: Jingoo Han > CC: Joao Pinto > CC: Lorenzo Pieralisi > CC: Will Deacon > > Jan Kiszka (10): > PCI: Make pci_get_new_domain_nr() static > PCI: Fix memory leak of devm_pci_alloc_host_bridge() > PCI: Factor out __of_pci_get_host_bridge_resources() > PCI: Add dev parameter to __of_pci_get_host_bridge_resources() > PCI: Replace pr_*() with dev_*() in > __of_pci_get_host_bridge_resources() > PCI: Introduce devm_of_pci_get_host_bridge_resources() > PCI: Convert of_pci_get_host_bridge_resources() users to devm variant > PCI: Deprecate of_pci_get_host_bridge_resources() > PCI: Add support for unbinding the generic PCI host controller > PCI: Enable PCI_DOMAINS along with generic PCI host controller Applied to pci/resource for v4.18, thanks! I added the reviewed-by tags from Vladimir (thank you!) and replaced the "Deprecate" patch by the v3 "Remove" patch. > drivers/pci/dwc/pcie-designware-host.c | 2 +- > drivers/pci/host/Kconfig | 1 + > drivers/pci/host/pci-aardvark.c | 5 +- > drivers/pci/host/pci-ftpci100.c | 4 +- > drivers/pci/host/pci-host-common.c | 13 ++++ > drivers/pci/host/pci-host-generic.c | 1 + > drivers/pci/host/pci-v3-semi.c | 3 +- > drivers/pci/host/pci-versatile.c | 3 +- > drivers/pci/host/pci-xgene.c | 3 +- > drivers/pci/host/pcie-altera.c | 5 +- > drivers/pci/host/pcie-iproc-platform.c | 4 +- > drivers/pci/host/pcie-rcar.c | 5 +- > drivers/pci/host/pcie-rockchip.c | 4 +- > drivers/pci/host/pcie-xilinx-nwl.c | 4 +- > drivers/pci/host/pcie-xilinx.c | 4 +- > drivers/pci/of.c | 105 +++++++++++++++++++++------------ > drivers/pci/pci.c | 6 +- > drivers/pci/probe.c | 4 +- > include/linux/of_pci.h | 42 ++++++++++++- > include/linux/pci-ecam.h | 1 + > include/linux/pci.h | 3 - > 21 files changed, 149 insertions(+), 73 deletions(-) > > -- > 2.13.6 >