Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp536966imm; Fri, 11 May 2018 02:21:43 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrMZhjsutBOlLzCbk6HCxMpFRDogLVPgLKCiLvQIKAh47pZylFm4YQCLPxnoN9M4Iphwq2a X-Received: by 2002:a62:d044:: with SMTP id p65-v6mr4781083pfg.64.1526030503449; Fri, 11 May 2018 02:21:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526030503; cv=none; d=google.com; s=arc-20160816; b=d3KN0u6YctXIVIbOMTIL9Xg9PfeS3C/eF/jrCFooyZ9kKh60+gjtEAPj2i3NVD+vba E5898EMl229D1lv4mKXPZKH1kfjU9LsAx+JgPy7mJbJdsydrIObGwuULdRkz/2DJr7B8 qMMVlQVDkCJJR6ScRK2etMTaOOWcQ34JFDeh7+4KaqQRhxwfkXAq/HuI8zT1phBpMfr+ yP2HelriKcD7qtaV5tnlVUys5vnjeKFSc6fvR74o7BH6ILt94g67NT4fLfra7FvbRjf/ Kq5rVCbrk8BoZa0TXywYoQMJY9dUYR/tPwfnZOxNrl541weoWGDUAq8owqdnrd3sbBg7 gtLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:references:in-reply-to:mime-version :dkim-signature:arc-authentication-results; bh=RYhSdrMpLE29M5l1hGs3XiSnjKwPQuzwnQAtS8AYS/Y=; b=GcptKpEPuknjN802ApYQmyZuW+LwhvMPsL2yLNDJa5R1mT9kWmaXodFHlyjgTYgDU3 bnfsTzoOLpFVZrmVYhJfY7tsW5yK4YniZcow/WyPVdvFiorSXjqzTedfb9cl89/iE4y/ u85dcKAD+SBZ0bXWLaf558TZoUkEk1YzOalWt9CEBGUAJ/hFcUmZuDWiu/GVapygkPov HCv+Ig05AAAnA/LwBf8UVeLj/+xCFywadUw1npNQv+cfW8VAMpxb6hARq7vJXBe1OxgR AkZh9M4+NEgEuKUne8TTz5PNxW8lbIc9UrqVti9UW3MZgpGEd4jfRQ8YdyNm3bw/Jrzk kXMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=hM1R4exD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o2-v6si2317164pgn.409.2018.05.11.02.21.29; Fri, 11 May 2018 02:21:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=hM1R4exD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752882AbeEKJVO (ORCPT + 99 others); Fri, 11 May 2018 05:21:14 -0400 Received: from mail-wr0-f172.google.com ([209.85.128.172]:42348 "EHLO mail-wr0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751406AbeEKJVN (ORCPT ); Fri, 11 May 2018 05:21:13 -0400 Received: by mail-wr0-f172.google.com with SMTP id v5-v6so4618386wrf.9; Fri, 11 May 2018 02:21:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=RYhSdrMpLE29M5l1hGs3XiSnjKwPQuzwnQAtS8AYS/Y=; b=hM1R4exD2+Q2wV8ZDhFg3UPUmeLGW9taAjP+7WJhz4Hyn+WAU1i0HtE0Noc/uGT4NK qTbPddi8iRQR6mYBhr6hO8K1e9hLylo1PvJVXMlqlTauvwDVaOIeogDeXDEH2TlGQgpo p63Bd1srwkPO/wC/oAxioNLYlEBxbYvhkFmC+eXiH5BFfaMu0ngjUsb+Xa6Snh4KFswi 9znEBm0ueDvu4LNMh+vCtcGul3FikCm0Qh78VKc2ulx9X6A9NSiXXSoAucCJTbgfyoiz FqlMxinXeAJpmRTF5YAOYCAqZAobnku9ywDnCEuYU1gdYgV8W7zhOG1NRGGUUaQgJu7A epFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=RYhSdrMpLE29M5l1hGs3XiSnjKwPQuzwnQAtS8AYS/Y=; b=DwbfEOOFAW3eVmRCdHEJsZoXruNoyGFMJDc57Yv26/zOZ+b+1FRsDITTUhAEDtEN65 MswXdIRrNHwmdOaZdyccH9R5X27tw52hWYM+TMuZoyFTApmWMIEfEjPV9NWd9WMinmUP TdwC1zRnzVZbV2Wz2jibbQZ4JUBMDHqTRo4eWkLQkpLhaVQGMLxIki0IKndz7bsAFg/n CN4wO4szxVwNOCaA5b1bLMWqQo6TRrtdxkfL4cJsYEcqs9sGebKXOlQ8p3C29Kn/I2t1 XNbj1ycZ6NY0KA7aCf1ZGEYYhxpMLt88aq8KefUQZ6jMRLclunpYNHqFpHsSMi+rTmYp Kr6w== X-Gm-Message-State: ALKqPwd09f+8LuDfeqywALVZDfTVy5kthJWta2AtwWsZabVgtXLBaN8r xW6/AEQscVDL+dIjUuZnmm8HdsTO7v+1tRRI12U= X-Received: by 2002:adf:adf0:: with SMTP id w103-v6mr4091685wrc.101.1526030471682; Fri, 11 May 2018 02:21:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.145.78 with HTTP; Fri, 11 May 2018 02:21:11 -0700 (PDT) In-Reply-To: <20180511091715.1989-1-zajec5@gmail.com> References: <20180511091715.1989-1-zajec5@gmail.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Date: Fri, 11 May 2018 11:21:11 +0200 Message-ID: Subject: Re: [PATCH V2 1/2] Revert "ssb: Prevent build of PCI host features in module" To: Kalle Valo , =?UTF-8?Q?Michael_B=C3=BCsch?= , Larry Finger , Matt Redfearn Cc: "linux-wireless@vger.kernel.org" , Hauke Mehrtens , LKML , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11 May 2018 at 11:17, Rafa=C5=82 Mi=C5=82ecki wrote: > From: Rafa=C5=82 Mi=C5=82ecki > > This reverts commit 882164a4a928bcaa53280940436ca476e6b1db8e. > > Above commit added "SSB =3D y" dependency to the wrong symbol > SSB_DRIVER_PCICORE_POSSIBLE and prevented SSB_DRIVER_PCICORE from being > selected when needed. PCI core driver for core running in clienthost > mode is important for bus initialization. It's perfectly valid scenario > to have ssb built as module and use it with buses on PCI cards. > > This fixes regression that affected all *module* users with PCI cards. > > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=3D1572349 > Signed-off-by: Rafa=C5=82 Mi=C5=82ecki As these patches fix regression/build error, I believe both should get into 4.17.