Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp590912imm; Fri, 11 May 2018 03:23:40 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqjAAn4498qvJiApiSkS7s+bUNtn40K0Za4kUP2aA9KBtaIXeAjToLwUSDRnk4UR7Z3jdhn X-Received: by 2002:a17:902:ab93:: with SMTP id f19-v6mr5021340plr.392.1526034220880; Fri, 11 May 2018 03:23:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526034220; cv=none; d=google.com; s=arc-20160816; b=WuQ2JQO+IiUCTjPkCgxsD59xsB/goLW397azH4j2j19xLfajwr2vsWBw9v/jVIgLdX J1zIUZDKBLCDDPa+RGQAHdJYAUdWAXmynBe/UHI4uCk1N/7xk3t5X6hkWRu4h71WB1XC 3smsmNz41iB1kAt5cZ540An+zoj8PI4bzlJYfS3lTzjjdpDky5/2a4aRAqLWuoIpTk3S CEjuR/CFTCKk8vvvIIjfqGiRluAMrb+HwUNU8ubizTbrTwBiX5KwRIKAZVdM/4PfjRZS fXqCScyxj7baimByMjxazu0Pszvuzx8WoQ8WtqfcEA/+J/HnxWEQQFi8SqjBqwMp8WJO x5OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=cBg5NrHV+SoAru56a+JFr8gBl283hIINxbQmaBHJfMU=; b=xfluzVB55eabW3fTIHErx9cbcVBI4IU85l/OgN0zt0sV650555g6J1ObgSjXcad6/P cmKq/+2l/SBGuby60YeJSlgOc9RMuVtoLNFVK5iZcdAVS+eTKwFqrK2wmY3zkg0jin4N 3NP3sTBApyFdNGEH2NN9frkTfFdCp223VeN1yO3uw8W/9p+rLvaa3g7ZFxuhbYPhp5FN 2hVrkQjopDdwNZFBDWiDDGvwZ92N96Tny7HrFh7744HVIXM5T6+NVWHJhW/uUnCgAOp2 /sxU+DlA+ZhnZHso2XxUHB+BErzbMylpAGTZNHIZz02q3/QsuWJ9R6eBJkkfTaGxTGfG y6Yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ege5Fvm0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b3-v6si205485pgt.629.2018.05.11.03.23.26; Fri, 11 May 2018 03:23:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ege5Fvm0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752874AbeEKKUc (ORCPT + 99 others); Fri, 11 May 2018 06:20:32 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:52609 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750852AbeEKKUb (ORCPT ); Fri, 11 May 2018 06:20:31 -0400 Received: by mail-wm0-f67.google.com with SMTP id w194-v6so1909599wmf.2; Fri, 11 May 2018 03:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=cBg5NrHV+SoAru56a+JFr8gBl283hIINxbQmaBHJfMU=; b=ege5Fvm0lLhzt1Z5JueggcGuZ2bIpuue+BJZSZ5IiBn7NqzxccQO4HdtSsgWqmjLWg 9A75o7HwAZv+7X0ciLqipk3FLKEtcbJb5mQfAcJHOp6oQgGRXdEIuMom0U7hC8hs1idt Kx0HXOudd5h6opblk1ZorSf0zLzALV4iArnF/VjvKt1MJESY7l6JjEC35djHKFsjPlHC 3FeMWbM+z/4yPWG/Mz7EYZVj2NROCzFOglP0HI4lqxbI6oOCwbygzSzbAaUtwOk8ozTd y3wqcS0eHYrpzIy9aVRfKkuQWGJlETHXhYn2Xxo66silewsmFxk/AlPrmDhJhsyOlJca j45g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=cBg5NrHV+SoAru56a+JFr8gBl283hIINxbQmaBHJfMU=; b=hFzZ6VkyXjo98mWtOhnueTPF0t04gfGWugNoRXnMNxreot/TYv47zsIbb93MXEVRHH ZevQ3clKKYNgCTDC+PwRUcMurH4w717RkDEsDbhe8GAoYfX3OTAKNAb/nASi0oYGI67z +Iuo2Isaa3KFvjjzsXcu9xbDCVJE/Cnyy84f9nBk/fnaSLQMCXdCCPySnc20RHHfJIOe R3JwpWsaFPnlfySgvIOUIFQYJXNaDWYB5QqbL9JVBWwpL0gLc6M1s05daLKkd5Vx8FAi qjOR+dUsP+JX+r4NZsgalASnw2eEJOAIJbRxjAJtg9C2AWFw3QpQiaAsrToJsUJ+5Fer FZbw== X-Gm-Message-State: ALKqPwcXWfELKjsRQibEyjBmokTPGecoId7EVzKrkmRQjLFmDkk4V4uh IqMvcCrO60PkW8GUmEQzDsU= X-Received: by 2002:a1c:9c2:: with SMTP id 185-v6mr1538613wmj.53.1526034029889; Fri, 11 May 2018 03:20:29 -0700 (PDT) Received: from localhost.localdomain (ram94-11-88-187-113-157.fbx.proxad.net. [88.187.113.157]) by smtp.gmail.com with ESMTPSA id 33-v6sm3036418wrs.5.2018.05.11.03.20.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 May 2018 03:20:29 -0700 (PDT) From: Romain Izard To: Nicolas Ferre , Felipe Balbi , Greg Kroah-Hartman , Alexandre Belloni , Ludovic Desroches Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, Romain Izard Subject: [PATCH v2 0/3] Fix an Atmel USBA UDC issue introducted in 4.17-rc1 Date: Fri, 11 May 2018 12:19:53 +0200 Message-Id: <20180511101956.11782-1-romain.izard.pro@gmail.com> X-Mailer: git-send-email 2.14.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The use of GPIO descriptors takes care of inversion flags declared in the device tree. The conversion of the Atmel USBA UDC driver introduced in 4.17-rc1 missed it, and as a result the inversion will not work. In addition, cleanup the code to remove an include left behind after the suppression of the support of platform_data to declare USBA controllers. These changes have not been tested on any hardware, as I do not have a board that needs to use inverted GPIOs. -- Changes in v2: - Use the correct format for the "Fixes:" tag - Collect "Acked-by:" tags Romain Izard (3): usb: gadget: udc: atmel: GPIO inversion is handled by gpiod usb: gadget: udc: atmel: Remove obsolete include usb: gadget: udc: atmel: Fix indenting drivers/usb/gadget/udc/atmel_usba_udc.c | 22 ++++++++++------------ drivers/usb/gadget/udc/atmel_usba_udc.h | 1 - include/linux/usb/atmel_usba_udc.h | 24 ------------------------ 3 files changed, 10 insertions(+), 37 deletions(-) delete mode 100644 include/linux/usb/atmel_usba_udc.h -- 2.14.1