Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp713532imm; Fri, 11 May 2018 05:21:20 -0700 (PDT) X-Google-Smtp-Source: AB8JxZq56Kxi3kkvr1Nd7Gz+yysftYBMCdHM+fB1r8cIR/1I5vPW2Vrkstk1XmbfQJKZUAm7I59N X-Received: by 2002:a62:3745:: with SMTP id e66-v6mr5312833pfa.43.1526041280456; Fri, 11 May 2018 05:21:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526041280; cv=none; d=google.com; s=arc-20160816; b=zBKzAUXql8IeM63wAbLeSC+caWooZgndr+/cYh70IX7xjB5vpkJCYWIyFM8TyQgoUw XF6B4r70qHv4zeJLBfdIwxehVmmoUxyE3KBYTglYarzyfxpK8ViEqu2NCM+129GTfoDd QXVRXGUKCDzxp3zwzBCnpxXnoCwYraYgqVVX6s4TJhhoCN0FMzsbajhdvITuN+hahPOt SfybFoShosieJFitAnyZ11LRDguTRAgg0V7DwpAjBV1YAXEmxTUheDcU1O8BExYs7Bkn egBtS4XLRmcJZrl/an7LdcEEP6/sCQiVysdZx1n+SrkzvOVF401Vb+/92UfgfhMIvDgH LLBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization :arc-authentication-results; bh=S610nACnRDVHsygsEA2Gf2BjtZW7JG4xGMqsn6AanVs=; b=WVZ5WsnD+WySAxDh7S0p1a3pG1FaEC9fyoicQU1utzHd/ScOnjmZIQvqEuylUR0684 ZgyK4JSrlX0lHNopq/nGM1bvEBLFUd0tU5yvWTBliLpd/lOzjryfmeehC8ru4ajuwaxJ T54zduO3YsM0eo+Zn2W/VR1JEprovTRC3wtQDR8L6plHGqpb03yv8TaSEYHjw7RS7nDL sy+ZeslT57cZa0YXpJZU9XP4Nzs2Fzbg4g31fRX1bGjWgCXHlLYB9k2g0V7J6WohsbHh 6g1eP6Cn4ql4CvZyba9q46NPVobxxp7WCe8gg/DShLf6h1N3f3oGD5WzLi4m88HX4AEF lbGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x68-v6si3015631pfc.205.2018.05.11.05.21.05; Fri, 11 May 2018 05:21:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752952AbeEKMUq (ORCPT + 99 others); Fri, 11 May 2018 08:20:46 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:40890 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752857AbeEKMUo (ORCPT ); Fri, 11 May 2018 08:20:44 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6C87DEC018; Fri, 11 May 2018 12:20:43 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-133.rdu2.redhat.com [10.10.120.133]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2F5DF1134CB0; Fri, 11 May 2018 12:20:41 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <4eaa0e19-684c-bef8-5aea-ddb5ef30828e@canonical.com> References: <4eaa0e19-684c-bef8-5aea-ddb5ef30828e@canonical.com> <152414466005.23902.12967974041384198114.stgit@warthog.procyon.org.uk> <152414469709.23902.10439448759049886690.stgit@warthog.procyon.org.uk> To: John Johansen Cc: dhowells@redhat.com, kent.overstreet@gmail.com, viro@zeniv.linux.org.uk, linux-nfs@vger.kernel.org, apparmor@lists.ubuntu.com, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org Subject: Re: [PATCH 05/24] apparmor: Implement security hooks for the new mount API [ver #7] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <21732.1526041240.1@warthog.procyon.org.uk> Date: Fri, 11 May 2018 13:20:40 +0100 Message-ID: <21733.1526041240@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 11 May 2018 12:20:43 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 11 May 2018 12:20:43 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'dhowells@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org John Johansen wrote: > this looks good, and has pasted the testing that I have done so far. I > have started on the work that will allow us to reorder the match but > its not ready yet and shouldn't hold this up. Excellent, thanks! One thing to consider: Kent Overstreet mentioned the possibility of adding support for multiple sources - something that his bcachefs would require. From the userspace PoV this could look something like: fd = fsopen("bcachefs"); write(fd, "d /dev/sda1"); write(fd, "d /dev/sda2"); ... David