Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp832948imm; Fri, 11 May 2018 07:06:21 -0700 (PDT) X-Google-Smtp-Source: AB8JxZp7SZ0680DuhlK3LBf2QOVP8/fh5Lyqfd7jA0migogCxJVeZwt1WIJEgiXPBmMr5/1rEnUj X-Received: by 2002:a17:902:1665:: with SMTP id g92-v6mr5716168plg.195.1526047581337; Fri, 11 May 2018 07:06:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526047581; cv=none; d=google.com; s=arc-20160816; b=E4d4YThEeq91nTd64/eAGj8lj5G9MkhlGIZQcUMC+SquHPnw7OQtxWjKVEzMMt6cFu 1VI79vOdZRKWaO1pIg++UZSTMmrTnKQfj4lx+GjtH61zepNFsMJM9WVQomyy7lj0p5Gn j2vUwhiEST/wfRUFzBdIjtwoWVv99TOO5oR15aHNGrWQr8fI/SeHrMgc0opxPkejyXm1 RXwrQ0Prmjv772t5uV1FV+5WgLPgiCZXqyQJglfVgLTmFTEhr/B5n3gxlQZIIaII7Fej qTu7UorbfEORIPepzwe2wARcXjV4aHPQsO0W9Q1uSVe5DRANURRKyYK48LQhpiKxPPwi 9f6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:cc:references:to :subject:arc-authentication-results; bh=X5JebgvdGdPIMIl8ZMt+V2a3E7c56bTF+T06040cdUs=; b=ZgqauoS7ELovRWpML7AfzyxL4z+1W6jkbAXN86hnyMvFSMYmx/BSilEeYOQyOdtJym ws9doFxGBMD/kT++sDL0JQ+Tf203a+pV5dA2Wqb/tX71epj0UGfcRWOEx0EIQLg/9NBS Hfd8XFLrfOUY6wIYYfsrsmgcZc3UBok9OzvYrX3Z/ntfJRKjP+KfdGeFKJ4VyErSVxAP pQLWUuYiMRf90Yup/Z7UEFaQ13CbgqFeQMMhLGlb0T62ETTylkvJtnJgdQfjwh+7QF/T QzoX5l8EKY9zFbpK9Jm3CvUx5ZzPTczK/MQTHfMjwFGrJq5/b3eOncMaj77KYaI8o28n ct7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w21-v6si2754884pgm.433.2018.05.11.07.06.05; Fri, 11 May 2018 07:06:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753246AbeEKOFt (ORCPT + 99 others); Fri, 11 May 2018 10:05:49 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:59337 "EHLO huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752563AbeEKOFs (ORCPT ); Fri, 11 May 2018 10:05:48 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 13B18D2FF78F3; Fri, 11 May 2018 22:05:45 +0800 (CST) Received: from [127.0.0.1] (10.202.226.45) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.361.1; Fri, 11 May 2018 22:05:36 +0800 Subject: Re: [PATCH 5/5] hisi: Consolidate the Kconfigs for the CLOCK_STUB and the MAILBOX To: Leo Yan , Jassi Brar References: <1522811675-12741-1-git-send-email-leo.yan@linaro.org> <1522811675-12741-6-git-send-email-leo.yan@linaro.org> <20180509040255.GF23540@leoy-ThinkPad-X240s> CC: Arnd Bergmann , Stephen Boyd , "Kaihua Zhong" , Tao Wang , Daniel Lezcano , <", linux-arm-kernel"@lists.infradead.org>, , srv_heupstream , Devicetree List , Linux Kernel Mailing List , Guodong Xu , "Haojian Zhuang" , From: Wei Xu Message-ID: <5AF5A328.7080001@hisilicon.com> Date: Fri, 11 May 2018 15:05:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20180509040255.GF23540@leoy-ThinkPad-X240s> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.226.45] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Leo, On 2018/5/9 5:02, Leo Yan wrote: > On Wed, May 09, 2018 at 09:19:13AM +0530, Jassi Brar wrote: >> On Wed, Apr 4, 2018 at 8:44 AM, Leo Yan wrote: >>> From: Daniel Lezcano >>> >>> The current defconfig is inconsistent as it selects the mailbox and >>> the clock for the hi6220 and the hi3660 without having their Kconfigs >>> making sure the dependencies are correct. It ends up when selecting >>> different versions for the kernel (for example when git bisecting) >>> those options disappear and they don't get back, leading to unexpected >>> behaviors. In our case, the cpufreq driver does no longer work because >>> the clock fails to initialize due to the clock stub and the mailbox >>> missing. >>> >>> In order to have the dependencies correctly set when defaulting, let's >>> do the same as commit 3a49afb84ca074e ("clk: enable hi655x common clk >>> automatically") where we select automatically the driver when the >>> parent driver is selected. With sensible defaults in place, we can leave >>> other choices for EXPERT. >>> >> Acked-by: Jassi Brar > > Thanks Jassi & Stephen. > > Wei, could you pick this patch? Thanks! Series applied into the hisilicon tree. BR, Wei > > Thanks, > Leo Yan > > . >