Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp887570imm; Fri, 11 May 2018 07:53:54 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoYAfHVUgAahKqOD7KdRPpsUigDOlAMyviisUqH237hONCCLsdjpxLwTwc16l0pRNEpHUAD X-Received: by 2002:a63:b007:: with SMTP id h7-v6mr3770150pgf.448.1526050434711; Fri, 11 May 2018 07:53:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526050434; cv=none; d=google.com; s=arc-20160816; b=xN4UAC+MQ0jYwnG6k7VtARJMKD+j9++WvRxxjvakWDPuePDaCUtpABaxzM9GZf92/k PfRjDTCYmy7PrDEXyDcQmMT+MgEF9ZE64MhdCSqVpkMBd7a5ocSw40g7PDfsTLr+ychL F3z+7rBPPeZshpPHxHBuFxUJpIux7CHtXgOlYKgaVy78rpa43qcajEOgU9HbB7dqjZmh BhTguRaTA71bLPSYoPZOn8v2yrsWlI0PL4Z/CNVcvIH4SHgYRb/1U6SILpRI774FYRIw uSknJokhtj7HxMI//CC0utgq+w//VyHsCdl8gGVX+s/PvpHjn8iPlzY8b0HaiFRYxXSR RbVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=ertlMDGWYmMhb35Rx0ahITY6sG/coZsAdontO+7MDzI=; b=tO1rKHEXcxusNCQL9GwS5XIVB2UpiPc9dQq4BgeerMrmWjypySgF3vpIwWoXbzrFtX 4BhDEdXeePwQDNuJCuNm6wXTZkMrq2cj0j4L7ttjwwyLXSyNwpF3Y0z73sw/gpCoWrY5 R8DmDNpEFwGtCubLfDOrvMQPFosRX+bg6avTeUXnx0lDndam/A0iUhAVB+UflRBIGe37 q+5BtlVz2t6RDyReE/cuiBQq+qYyzYrIe1qentO2jsBtg+maepGmsicXnBplPu2IgBy5 Nnt9qdff2JsEKZPDaDV7ptAu+bGsf3Hf1wgt+slbimUXIT1LZ/73Asj5jTeheYHSyTEy sqyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DG6ncGqq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l16-v6si2646304pgc.177.2018.05.11.07.53.38; Fri, 11 May 2018 07:53:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DG6ncGqq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753265AbeEKOwy (ORCPT + 99 others); Fri, 11 May 2018 10:52:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:50924 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752981AbeEKOwx (ORCPT ); Fri, 11 May 2018 10:52:53 -0400 Received: from jamesdev (jahogan.plus.com [212.159.75.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 78DBD21738; Fri, 11 May 2018 14:52:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1526050372; bh=ertlMDGWYmMhb35Rx0ahITY6sG/coZsAdontO+7MDzI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DG6ncGqquscK9VpcD+WKhB4xLVbn6UHe7NmYYFL1Oy3oB/9a0KEg+LM3D4Zx3FPX/ ObLD3bfE/deV92EHu0TcQW+C3lRYgjc5qy2xyB+0vlm3qEljZ5az7CUneEeM3fALdD YO+xwk+w+WEgDd8b44KnPuRz13XbJ3GSsvbCAKUo= Date: Fri, 11 May 2018 15:52:47 +0100 From: James Hogan To: Paul Cercueil Cc: Guenter Roeck , Rob Herring , Mark Rutland , Ralf Baechle , Wim Van Sebroeck , Mathieu Malaterre , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org Subject: Re: [PATCH v3 5/8] MIPS: jz4740: dts: Add bindings for the jz4740-wdt driver Message-ID: <20180511145246.GA12956@jamesdev> References: <20180510184751.13416-1-paul@crapouillou.net> <20180510184751.13416-5-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EeQfGwPcQSOJBaQU" Content-Disposition: inline In-Reply-To: <20180510184751.13416-5-paul@crapouillou.net> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --EeQfGwPcQSOJBaQU Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On Thu, May 10, 2018 at 08:47:48PM +0200, Paul Cercueil wrote: > Also remove the watchdog platform_device from platform.c, since it > wasn't used anywhere anyway. Nit: it'd be slightly nicer IMO if the patch body was a superset of the subject line. It's fine to repeat what the subject says since thats meant to summarise the body. > -struct platform_device jz4740_wdt_device = { There's an extern in arch/mips/include/asm/mach-jz4740/platform.h that should perhaps be removed also? Otherwise Acked-by: James Hogan I'm happy to apply for 4.18 with that change if you want it to go through the MIPS tree. Cheers James --EeQfGwPcQSOJBaQU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQS7lRNBWUYtqfDOVL41zuSGKxAj8gUCWvWuPQAKCRA1zuSGKxAj 8mlfAQCJf5mvfQD9ow7oPKhrS7ZEEtsAokvWC1M/Z2F3mCx3bgD9HQQl05Fya66i Dpd1TlEADWA+H91gd5uKii85SdfeNwo= =IGgX -----END PGP SIGNATURE----- --EeQfGwPcQSOJBaQU--