Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp903813imm; Fri, 11 May 2018 08:07:01 -0700 (PDT) X-Google-Smtp-Source: AB8JxZp9oHuKV1EzXWnHi0UsKPaKedXZI7uI0Uozacv1jGI9aW+586m7yJWgzouRzNfGxYJRA2t1 X-Received: by 2002:a62:3745:: with SMTP id e66-v6mr5868492pfa.43.1526051221786; Fri, 11 May 2018 08:07:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526051221; cv=none; d=google.com; s=arc-20160816; b=Sz1rRTHWRFR43PvX6GyPlFnhTl+IwOxFIX1fuijT9NUssm7xpAqYbAaF2GKGPnGWtj /aHVKdrdnZP8MN+A4T1FJG2pX2UYB2Vtje8S56NJUcbUlEYH2qw5gvhaXOck1z4Y2/uS 8/pq8hf0kBMH8mhtXpX//zvwN6mD1ZjsngfTSEi7bQOacnGCDckHmwIto7BUjk0V57Ff tzt/I5pkjVVrnbPLjmZmzn422lhDU36tUYkof7JQdDoGbI/Q3/ASZuGhe5ucvvN4xXIM Q1Mma/zgliyflX+KWO4vR1lAb/Q3IXdTsu6m+r8s+MxAveLhaX7128utlvWGWfcO8Ek5 e0+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=qir/ifzRAWWOuyq6hnSS6i6KXD7DOUAt8CrNbhC/BZA=; b=p4r8XH/unYIwKvUsAcGAa5hFpKxdGUqBswNusiyHuEJeu+QkevUOPgBm3RtDiFTigw ZVYIVR8MlzGE6buwyDwqu/50HYF+9aqsV2c7Hffbg6haHoQgAjHddR1HgkM5sWEweWQj 6rI1/EvhRRMHgbhustkVLpYSJPipnb9VtbMlVGovhi0+Qh3qvnBS4lrTtY1Ia78OaW1j efwjaFolumT6pJylmrkfVf/Wn5Z+5RyC/cHE6NogCIpIh36JcrdHTNBa5dQNzmtpji1E F9QWOSMpF/GVe08RwPK/gniLZ+7hYDKyuC7g3WY0zVKveTbxhAuX2eEIhWu6jndKDrNU poVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s6-v6si2550712pgp.152.2018.05.11.08.06.46; Fri, 11 May 2018 08:07:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753504AbeEKPGY (ORCPT + 99 others); Fri, 11 May 2018 11:06:24 -0400 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:44836 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753484AbeEKPGW (ORCPT ); Fri, 11 May 2018 11:06:22 -0400 Received: from ubuntu-CJ.home ([86.244.116.1]) by mwinf5d36 with ME id l36B1x00C01t9Ri0336BWe; Fri, 11 May 2018 17:06:20 +0200 X-ME-Helo: ubuntu-CJ.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Fri, 11 May 2018 17:06:20 +0200 X-ME-IP: 86.244.116.1 From: Christophe JAILLET To: alan@linux.intel.com, sakari.ailus@linux.intel.com, mchehab@kernel.org, gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com, chen.chenchacha@foxmail.com, keescook@chromium.org, arvind.yadav.cs@gmail.com Cc: linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH 0/3] media: staging: atomisp: Date: Fri, 11 May 2018 17:06:15 +0200 Message-Id: X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These 3 patches fixes (at least I hope) some issues found in or around 'lm3554_probe()'. Please review them carefully. I've only compile tested the changes and I propose them because they sound logical to me. The first one, return an error code instead of 0 if the call to an initialisation function fails. The 2nd one reorders own some label are reached in order to have a logical flow (first error goes to last label, last error goes to first label) The 3rd one fix the use 'media_entity_cleanup()'. If this one is correct, some other drivers will need to be fixed the same way. Christophe JAILLET (3): media: staging: atomisp: Return an error code in case of error in 'lm3554_probe()' media: staging: atomisp: Fix an error handling path in 'lm3554_probe()' media: staging: atomisp: Fix usage of 'media_entity_cleanup()' .../media/atomisp/i2c/atomisp-lm3554.c | 20 +++++++++---------- 1 file changed, 9 insertions(+), 11 deletions(-) -- 2.17.0