Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1076734imm; Fri, 11 May 2018 10:42:30 -0700 (PDT) X-Google-Smtp-Source: AB8JxZroGRaJyrp+RjNx1ye3MYUlFMtyjaLK1buz8fh64hZCQeEYH3jnfytpcG3du3f07edcTcSz X-Received: by 2002:aa7:8551:: with SMTP id y17-v6mr6355256pfn.163.1526060550521; Fri, 11 May 2018 10:42:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526060550; cv=none; d=google.com; s=arc-20160816; b=jMkNwOqmKV+inOx7NhlJ28yRXqD2ZapsiFqV5tgWItsGvyhiWgs0pbnU7J5HQLOzy3 tEP3VA+j1uF4JYtnHW0g/jg6099aAfPg6gbpMdNvf8MUfii4W3R++g3pvE+uFl6M/BGF thpBoR0p1LuzOVmsZV8casBYW39ha9E0ocmwIKefAvnO7AuY+pnRXOo31a1rSBnpJxXY T3FufuDcX0wuSL4CJ7fNc9Hl8HCBneROsgAecywhXGUMgaEjdcsBAzBgHGrG5x76Ch0t pMoODo/303FrRbCJljB463SEzaWa/ID9VoBNxoIw8bkT2Kw7siH3S7dB++rXkONQxNub BJ/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=VfXv43HPczTcHGzJRNEaR4CRb89onJ/tiP8gcyq5Xgc=; b=DKN0dG5qA3QhQLr2/74TH3K3vemvnxZIgL1/xKd33PubWtZBj90sZesyb5ieb55gYe Ml1MMxo35PB+MYCp4/8CJ11kBUpz7cIxEUuziz3AOD2BhJaxjexZpEwoy3xdrirocKl9 Q+R7yD1LZkEOH3e755W9NAsXZtX/svnPWwqyfl2w5bP9xki45p5A51h9qlQ/ZGz+/XJn yz8gXqJjqkyjqZmC7KdgbdkTSOFKykyzaVJ7WkoCxN5mxUr6lOqQpBy71LqSrjRteeVR ibsnI9laoabA3NBDL6oNGDf1cxJnCSOrQNj7GsfUvUuJhUGbCZFjLBvLutjb/yzXGWj3 i3Yg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y7-v6si3404867plk.473.2018.05.11.10.42.16; Fri, 11 May 2018 10:42:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751856AbeEKRlj (ORCPT + 99 others); Fri, 11 May 2018 13:41:39 -0400 Received: from mail.skyhub.de ([5.9.137.197]:60782 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751388AbeEKRlh (ORCPT ); Fri, 11 May 2018 13:41:37 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id eNqktnax_4vf; Fri, 11 May 2018 19:41:20 +0200 (CEST) Received: from pd.tnic (p200300EC2BCAC2007194A577202112A7.dip0.t-ipconnect.de [IPv6:2003:ec:2bca:c200:7194:a577:2021:12a7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 2B56B1EC0236; Fri, 11 May 2018 19:41:20 +0200 (CEST) Date: Fri, 11 May 2018 19:41:12 +0200 From: Borislav Petkov To: "Alex G." Cc: alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, "Rafael J. Wysocki" , Len Brown , Tony Luck , Mauro Carvalho Chehab , Robert Moore , Erik Schmauss , Tyler Baicar , Will Deacon , James Morse , Shiju Jose , "Jonathan (Zhixiong) Zhang" , Dongjiu Geng , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, devel@acpica.org Subject: Re: [RFC PATCH v4 3/3] acpi: apei: Do not panic() on PCIe errors reported through GHES Message-ID: <20180511174112.GI12705@pd.tnic> References: <20180430212836.7807-1-mr.nuke.me@gmail.com> <20180430213358.8319-1-mr.nuke.me@gmail.com> <20180430213358.8319-3-mr.nuke.me@gmail.com> <20180511154039.GD12705@pd.tnic> <8e3c0cc6-9c5c-85ce-650c-8f498f5907da@gmail.com> <20180511160253.GF12705@pd.tnic> <45b7be09-c9b3-8006-6ea0-36b4ff38607c@gmail.com> <20180511162951.GH12705@pd.tnic> <95bcbc2d-0f8c-e51a-f0fc-08ea8c5fca26@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <95bcbc2d-0f8c-e51a-f0fc-08ea8c5fca26@gmail.com> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 11, 2018 at 12:01:52PM -0500, Alex G. wrote: > I understand your concern with unhandled AER errors evolving into MCE's. > That's extremely rare, but when it happens you still panic due to the > MCE. I don't like leaving holes in the handling of PCIe errors. You need to handle only those errors which are caused by hot-removal and not affect other error types. Or do a comprehensive PCIe errors handling of all errors in the AER driver. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.