Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1212983imm; Fri, 11 May 2018 12:47:25 -0700 (PDT) X-Google-Smtp-Source: AB8JxZr0KNMaFZnY5o704gFG1PWNX7fWHsnzhiogQhx3MGLz+q8NpocvlnLub75MWv017Khkxemn X-Received: by 2002:a63:9b11:: with SMTP id r17-v6mr283327pgd.297.1526068045674; Fri, 11 May 2018 12:47:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526068045; cv=none; d=google.com; s=arc-20160816; b=rmSrAkZW5vNzoUWpae9+vzv/kaN838Jn8JXMH10rwsAldCB83dDaCJa61pB35TqkP6 Lwncj35THFcuPEeqv/Bdra1SLcIt79eauMhhAqV3IV9it5EhpbRDOlZCk4kkzfYQsAtT k/JwNfiicuUQWIJ/uxg5l7x5r1MIYYN9/rmlePsMEByHIdCgIfOCjjPySRTaQ3XG7V5p 0Qtr82FPiGG1CGiSicRjQatr/W0ArG+EQGuf4bdpMiOX+p9VTG32K5ZkAXQI05YJXcGv MsaWIjkicv/N35/TpliGUcrMSqQsgiFKloakDctvsRumXXAdKp1HjDIUdvew9TB9e1lw yMyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=DJCC4U+ccwFrO8Op+o22fanpU/dW57RwE3Y74MPceNg=; b=QBiQjSNZDwquFtYbnL777p9vefqLdZeA+QOnGTMobOh43DtGR0c+2z1ZFXmS2SbvwI Gm2eJ02Llkygcnc+/lP529PYNk1aX253hO3L4k2kbkrLLYZ7OmaxIHF2bzqaVqoWQini KBvNrYW6rnG34tuWvmZiv5FTnxPQOX3bYUCylQsVPgy7JED/yLrkg2tpljrJ0lHUW43s L6JcUw8CqkInuIyugW6Y+zSyWKtJE81thiFvKOuu1BqEd06mOvceMC9oLG/EZ2RhrwjW wggIth/O3NKk65jt9phdN0pusjKscfbUCWD5w8xivl5Iik/o2dmigEv9MKjaSM5p7lcn 2LvQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p10-v6si3095901pgv.598.2018.05.11.12.47.10; Fri, 11 May 2018 12:47:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751664AbeEKTpr (ORCPT + 99 others); Fri, 11 May 2018 15:45:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22935 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751381AbeEKTpp (ORCPT ); Fri, 11 May 2018 15:45:45 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4326730014CD; Fri, 11 May 2018 19:45:45 +0000 (UTC) Received: from w520.home (ovpn-116-135.phx2.redhat.com [10.3.116.135]) by smtp.corp.redhat.com (Postfix) with ESMTP id A710C2015C01; Fri, 11 May 2018 19:45:44 +0000 (UTC) Date: Fri, 11 May 2018 13:45:44 -0600 From: Alex Williamson To: Geert Uytterhoeven Cc: Baptiste Reynal , Philipp Zabel , Rob Herring , Mark Rutland , kvm@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] vfio: platform: Fix reset module leak in error path Message-ID: <20180511134544.72b46acb@w520.home> In-Reply-To: <1523438149-16433-3-git-send-email-geert+renesas@glider.be> References: <1523438149-16433-1-git-send-email-geert+renesas@glider.be> <1523438149-16433-3-git-send-email-geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.25 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Fri, 11 May 2018 19:45:45 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Apr 2018 11:15:48 +0200 Geert Uytterhoeven wrote: > If the IOMMU group setup fails, the reset module is not released. > > Fixes: b5add544d677d363 ("vfio, platform: make reset driver a requirement by default") > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Eric Auger > Reviewed-by: Simon Horman > --- > v3: > - Add Reviewed-by, > > v2: > - Add Reviewed-by. > --- > drivers/vfio/platform/vfio_platform_common.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) Applied to next branch for v4.18 with Eric's ack. Thanks, Alex