Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1299370imm; Fri, 11 May 2018 14:12:29 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoHxRfkmbjY7y1omnHag3KUmMtxZ0CHwn5c8E4P6GQobnd11M89A8kJ2+zrPou+3Tpnr+IP X-Received: by 2002:a63:6016:: with SMTP id u22-v6mr513181pgb.284.1526073149187; Fri, 11 May 2018 14:12:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526073149; cv=none; d=google.com; s=arc-20160816; b=w8dyqQF5gM5PweMMZxtWbTm27OzxLRKJVWN2FT6vlLtTHhjRC6OSwi+ukMqrPxsj+A fTwual2W6qjk1X1nt+bYMBYAQFb7g48y2FexNMfBCZtaMB0Z/yOBrakGRUIT9j1NTUks bja740BM8tKuQA4skFxjnXL+IStuGDsfl6bPe+yoLSlskG/L3WSq9vWqSAcqo1PZJx0X ARAqKTDqEjWcDm3yUlKQuhp7TNHzJWFoz2uhzQaBYTUsd0hfGDEpeRB9x4OZ31RwW/wT nG6u6dWq+8nwx2yBKPdcofzNQZJGIeWFtFJYGDnTjncevsWYUjlkodOXK+kv1xVw27Zd gzPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature :arc-authentication-results; bh=Ho9nGWd0drtdPIx0QLvPRU+Len4aKRHi6VbuafrU+vk=; b=TjYeIFLZqsGefBP3zqMXib9xhoNqU/sTbSkYgzkwHGRzEU2s83wP8QJehNJsEKt1yT 9xBvmPztWxKZQ6FttQ6pOMg0oYOWOd1RK3eB4IW+kuJwJYH2hZkOCiHo/XU4+kGe3EPA cH064PnR3NDeln4OpMHheswkXhvfljpPf2nGa5Qv5Pv7biBIA2V2wEtEBbAOidSlor0v h0CUgf9ubeQfPgIfQ3jAe+lC2mRTqXrK2HWgLQg/HE3bYfa9INuyxMWCKItP7r4WnTzO RbH2g9O8QSA17UwS5cnyAri2j+JuBN+WlMINI6DnlaTAXYqp60IjewJeUtdwx4mtqtI4 Poxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=q2w6DckK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u7-v6si3398328pgq.232.2018.05.11.14.12.01; Fri, 11 May 2018 14:12:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=q2w6DckK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751381AbeEKVLt (ORCPT + 99 others); Fri, 11 May 2018 17:11:49 -0400 Received: from mail-pf0-f172.google.com ([209.85.192.172]:34118 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750798AbeEKVLs (ORCPT ); Fri, 11 May 2018 17:11:48 -0400 Received: by mail-pf0-f172.google.com with SMTP id a14-v6so3267770pfi.1 for ; Fri, 11 May 2018 14:11:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=Ho9nGWd0drtdPIx0QLvPRU+Len4aKRHi6VbuafrU+vk=; b=q2w6DckKT7FhV/nqmKKY3R7s1Lej1iG/hymNRNbtuRzg/4vQPVoaawrQ1N2d0JB7pd O7a2hGHTwXL5a4fhV4IZEgXjKnLUPR8ywUNyrABh1urbU/6s0GdehMWB75JIm1IXaAUy 7WGeBAiS6S8XclpBJSGHuWjvZT10TkX9Tduj8lnPtRDv64Mjy3A8w/FY0xI3kGsGGzgE 27zQ/TTaZ8NHdTguIVT04OQqQIlKGTPVMCknJZP0levpXku3D74ThcXVFxqr/ueLTeAy xGdAYUPHtDKoyYjCOfMn2DF6AEXllXNmq64x/axF9KC9VHnNMUiN/obtUH3ToMTOyQWe IwgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ho9nGWd0drtdPIx0QLvPRU+Len4aKRHi6VbuafrU+vk=; b=C29Por58WByI/Jx8wICPphFQRNlqxTEKscDVLO9k3oKp+PbaZgXKTmmJEQaMrhCkf7 i3MC8g9qB3dD39xjix++3F63nyK2uwD6+gAMaSM4E0krK5ihLC9kAaTDLG+Mk3kMts8l 6KTaHSOiHH11eiEPpzJ0PoYU2pWJLzmHsPb8Fi8RMEYKEFzzAuwK0XbU+gUoSUJGtscw w9uLJT0dn5XEnZX4RfyqKmfgwxKLyCGNkDuw+zTOeAfav+2ggF6ayNZGgIWLFbj431ln nQSY/0IgJQAWWRM4KvzQkNoENmd3F80ZzWuJVgxAk67MeFpRTKcC2yLpoh9q9FaeYJnP V76Q== X-Gm-Message-State: ALKqPwfUBQipxhIEiGRcOAE7p+gOn8eP5TJh4ORLkoFp8hPSF9mAnrtJ JRdOCjg+fH247t7VciU7xgjwYw== X-Received: by 2002:a62:89db:: with SMTP id n88-v6mr366792pfk.11.1526073107818; Fri, 11 May 2018 14:11:47 -0700 (PDT) Received: from [192.168.1.211] (107.191.0.158.static.utbb.net. [107.191.0.158]) by smtp.gmail.com with ESMTPSA id u8-v6sm8264736pgq.7.2018.05.11.14.11.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 May 2018 14:11:46 -0700 (PDT) Subject: Re: [PATCH 01/10] mempool: Add mempool_init()/mempool_exit() To: Kent Overstreet , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, Ingo Molnar , Andrew Morton References: <20180509013358.16399-1-kent.overstreet@gmail.com> <20180509013358.16399-2-kent.overstreet@gmail.com> From: Jens Axboe Message-ID: Date: Fri, 11 May 2018 15:11:45 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180509013358.16399-2-kent.overstreet@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/8/18 7:33 PM, Kent Overstreet wrote: > Allows mempools to be embedded in other structs, getting rid of a > pointer indirection from allocation fastpaths. > > mempool_exit() is safe to call on an uninitialized but zeroed mempool. Looks fine to me. I'd like to carry it through the block branch, as some of the following cleanups depend on it. Kent, can you post a v2 with the destroy -> exit typo fixed up? But would be nice to have someone sign off on it... -- Jens Axboe