Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1836408imm; Sat, 12 May 2018 01:04:42 -0700 (PDT) X-Google-Smtp-Source: AB8JxZp0AYEYuYSA23XR5bD5pcCcrI+Nka/MabP8p/lRWVr54w0YKFnJCCAfK+/h32sm2rUqhp76 X-Received: by 2002:a17:902:8:: with SMTP id 8-v6mr1452165pla.287.1526112282204; Sat, 12 May 2018 01:04:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526112282; cv=none; d=google.com; s=arc-20160816; b=L1EMB2eHNHHiMdZUU62FeMl+9Bd8XN4QjPFc0viiEnrPuzyrKlOOqCvYfvGkuiPnDH SohX+ct+vzn5Od8lL3eRLQulT+31XK8SIofqTgGvZ/XLgpXUE7pe4eVzaEVtfxwGvC21 ojdr4DAjE478qoGVQ4s/pbs7jmuKJ25Tbue712iKJaxvMVHoMUR/MK7rmb9dps2QkVlp DPENAm8o9KWtJd+k34MnKVl45wJuLoDx9wZUsZM/JvZVrd4P8wmNmURK4gZGIq8aAyI0 3w0vkZlyqjkEvInn69TfajADCpv7VmNBAQ2b56mrPP+1wPJr6KLEOiCcy6q1TbLcToNY 9mUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=vwF/Gdolb7M4HLIgt97Q/U7Oh0xH2lqXlxShRan1Kao=; b=KRStqV9zKS1viNxDZjbrM5UV6a88CKS1yDN7K6ywBjljgSoz0jyEmaxYTm2R8qJA5B KbP8xUqKhXB5+6mCs3PfQmEOH0J4itYz9QLawMXOkE2sRiamnlnPoLeSBb7mEte+WaOD ujCcLMRtFOcPih9GNQd0fWhFdHNmDv1z8XcerpD15eWjHcQPC0sIPlyFmRkNrzFwL22J AUZdrYO/bRNSwrlRQaL0AaEbwEhpa54oOJsoCcfLFQcMUW6rWC3crOzHK1Ok5ePQgne8 dSHu63JIgeKFRLRmDOnhqhezWsabz+fZ44+1zkh1XhTKxqKAG8b6oCHW1aXaCEX6W/Ev KNyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=gC+w0cfd; dkim=pass header.i=@codeaurora.org header.s=default header.b=EpVi1YAE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e124-v6si4912692pfe.80.2018.05.12.01.04.27; Sat, 12 May 2018 01:04:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=gC+w0cfd; dkim=pass header.i=@codeaurora.org header.s=default header.b=EpVi1YAE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750905AbeELIEA (ORCPT + 99 others); Sat, 12 May 2018 04:04:00 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:55456 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750722AbeELID7 (ORCPT ); Sat, 12 May 2018 04:03:59 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 878C3609D1; Sat, 12 May 2018 08:03:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1526112238; bh=P0NHaLKIfRdkSdqA3Tq+plXDASKS7QmXwOQeBDkLk9I=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gC+w0cfd2kM0awsQ17j32Ui54Q2kS12/24vryDoSbm0axDAGm3r6/+G0XywhYv/PF 8DKfEUlJxpuCxsssxbCMfFaWFMT4+owUB6mmTyrN2y9WFKUAqvG/hjKPdHYBz3JL/I Cv7SEsRpLJCv6gW4f+Y67RhIIENtY9Hz78yx+iVk= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from x230.qca.qualcomm.com (88-114-240-52.elisa-laajakaista.fi [88.114.240.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0FF09602BA; Sat, 12 May 2018 08:03:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1526112237; bh=P0NHaLKIfRdkSdqA3Tq+plXDASKS7QmXwOQeBDkLk9I=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=EpVi1YAE2jtm9qW6Z5rcCe1IbDs24z2E1iSXd1Q4WybO8WKs8lZmnXn4U8OqYetPt rTcFS8TkFmaIIa76PlGCbHSX54i9M0zxe/W6lBzn82PUHCYmdRmEbhWL1O9RWdA5ui pGrkexunaqLAezpvw68JRqEExkWbghZsQ46dTwtA= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0FF09602BA Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: "Luis R. Rodriguez" Cc: Andres Rodriguez , linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, alexdeucher@gmail.com, christian.koenig@amd.com, arend.vanspriel@broadcom.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, hdegoede@redhat.com, Kees Cook , Mimi Zohar Subject: Re: [PATCH 6/9] firmware: print firmware name on fallback path References: <20180423201205.20533-1-andresx7@gmail.com> <20180423201205.20533-7-andresx7@gmail.com> <20180503234235.GX27853@wotan.suse.de> Date: Sat, 12 May 2018 11:03:52 +0300 In-Reply-To: <20180503234235.GX27853@wotan.suse.de> (Luis R. Rodriguez's message of "Thu, 3 May 2018 23:42:35 +0000") Message-ID: <8736yxb8rb.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (sorry for the delay, this got buried in my inbox) "Luis R. Rodriguez" writes: > On Mon, Apr 23, 2018 at 04:12:02PM -0400, Andres Rodriguez wrote: >> Previously, one could assume the firmware name from the preceding >> message: "Direct firmware load for {name} failed with error %d". >> >> However, with the new firmware_request_nowarn() entrypoint, the message >> outlined above will not always be printed. > > I though the whole point was to not print an error message. What if > we want later to disable this error message? This would prove a bit > pointless. > > Let's discuss the exact semantics desired here. Why would only the > fallback be desirable here? > > Andres, Kalle? So from ath10k point of view we do not want to have any messages printed when calling firmware_request_nowarn(). The warnings get users really confused when ath10k is checking if an optional firmware file is available or not. -- Kalle Valo