Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp2097469imm; Sat, 12 May 2018 05:56:51 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrXqX6fZ9ddLgsIWJ0lb700i+ffYlNcf/RsYoM8wiCmMj6+LpwU96wglsv1k0OmFRBjf9kZ X-Received: by 2002:a65:5807:: with SMTP id g7-v6mr2592430pgr.409.1526129810948; Sat, 12 May 2018 05:56:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526129810; cv=none; d=google.com; s=arc-20160816; b=m0h4wj7PItCLk9gHfJ7vs96vd2yKlga9lL/xx49d130FDP2i7lTl4CjliPbvApoqm2 evYBe12p5ZJWGyxlgzIf066aKEdt73U+ydlm++KGnaKbSoydf/z+15ADHYEgu1d419Df knLmqsi+I/fzoDCoYKBQt+spcjyb9VMQdpzct9BxCFkBfOBlm5oxb4l07JNwoqZ1fJx1 erGcLaP3SLvJkkhFQWSUcyhrohtXVb6rZQ8dFMzg4R/eaL1Ke1AVP1fJwC5GMdjmVIhu mpoYod1FeIgGfnDHS9hcimj6T0c25YjGWes68W5TuLCMZti2C36pMLZ/mZi6JvZNzJ1R 2ADw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:msip_labels :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:to:from:dkim-signature :arc-authentication-results; bh=X+GXw02274dgUKFxLwanmm6q/UzcuTwYov/sio+wdB8=; b=Wo6bBB6Pevd5c1RvRwKSxrc7TbEI8v0BSjHKoAw3DHpU/h1YlUKAudCkFIPy+tf8UF lHlnnBu/MRkedMxq8ga0W41ooaATgYx3H/abXDWmAxJ+Gp9f2m5EMPcG5W6pQlZmN7fO /4ZUbEB3A0YnL4LwUUXcoYn6kji4or1JcUlLLMz/bGQjN+Dj4YQ7T8IgwY3OwdIoLfwO aK/kiKaBc0ot75pU9MYkINsECA0/x87pvMPgtVqrwSjIYLE1gShrlHYjnaTdyqgGexMy 3+ZzD2v3wuuVbgeX4MvL0xN0Tvg8SyTWrOF2+nKZzhgPSHy15G7142rkvPagWYCbhHMJ uhWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=AOFUH2Ma; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g63-v6si4389863pgc.40.2018.05.12.05.56.36; Sat, 12 May 2018 05:56:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=AOFUH2Ma; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751297AbeELMzp (ORCPT + 99 others); Sat, 12 May 2018 08:55:45 -0400 Received: from mail-dm3nam03on0100.outbound.protection.outlook.com ([104.47.41.100]:20576 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750902AbeELMzn (ORCPT ); Sat, 12 May 2018 08:55:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X+GXw02274dgUKFxLwanmm6q/UzcuTwYov/sio+wdB8=; b=AOFUH2Maa5NVrS7JNQ1WXWkf1gQxzzJA1DzOlR57ZRNz6XV1SalkGymfF+Pg4RHTToSNF/U/nXaQJRUREBSNuQTtbrEP/noRVm8F0jQmV5jC85Zn5Q1Vt9vD1Ei71G996gAz2Y/FsphldJy5SyoszdsVvQaSP1mWAF/2Kh4bgzY= Received: from SN6PR2101MB1120.namprd21.prod.outlook.com (52.132.117.161) by SN6PR2101MB1101.namprd21.prod.outlook.com (52.132.115.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.776.3; Sat, 12 May 2018 12:55:41 +0000 Received: from SN6PR2101MB1120.namprd21.prod.outlook.com ([fe80::803d:f236:9e5b:4318]) by SN6PR2101MB1120.namprd21.prod.outlook.com ([fe80::803d:f236:9e5b:4318%4]) with mapi id 15.20.0776.004; Sat, 12 May 2018 12:55:41 +0000 From: "Michael Kelley (EOSG)" To: KY Srinivasan , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "olaf@aepfle.de" , "apw@canonical.com" , "vkuznets@redhat.com" , "jasowang@redhat.com" , "leann.ogasawara@canonical.com" , "marcelo.cerri@canonical.com" , Stephen Hemminger Subject: RE: [PATCH char-misc 1/2] Drivers: hv: vmbus: Remove x86 MSR refs in arch independent code Thread-Topic: [PATCH char-misc 1/2] Drivers: hv: vmbus: Remove x86 MSR refs in arch independent code Thread-Index: AQHT5mTh/2/f9124gEKaSv5+XL+NsKQrzDiAgABFcUA= Date: Sat, 12 May 2018 12:55:41 +0000 Message-ID: References: <1525739851-54919-1-git-send-email-mikelley@microsoft.com> <1525739851-54919-2-git-send-email-mikelley@microsoft.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=mikelley@ntdev.microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2018-05-12T12:55:40.0718670Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General x-originating-ip: [24.22.167.197] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;SN6PR2101MB1101;7:trLhjXtJbvGJVpChQm3Mk3EFWoKLhxCUPhmYgNKKwU/eIB9JxleRWaH4A9Z7d2LgF0gVeEcksWgFpsVq6q9MpP0splC64H4rFjYvmJbm3z9Grp2CnXbVmG75k0zNtSHc/YqUZ37mrisQXygoKSmB2/CT4B8tvslxgRvGJRAP3mmXd5a4b01Sk7Kt0vj9r5D2agTObDwHrTLlSF4A08mmrHUewgMxl6PvpfWWN2mQCN0TH6Xxc9Zh+AWKHfpEdHbv;20:DK0pjL2c2zOrO6ca0zhJtDYoBJ714dvzXyEsK5TOHMJqHAaLfoDWlrzn8FE0HLbeiShHlHQm7Om9xV/wVz43xXCtIKd8/mMo7QPfpP4tT1nO0RSn3qYJjThjeJeFLYrazpB+vN72FSz5b1Carp5w3TzWS17Hfs0t2I0rXJezP0k= x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(48565401081)(2017052603328)(7193020);SRVR:SN6PR2101MB1101; x-ms-traffictypediagnostic: SN6PR2101MB1101: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(3231254)(2018427008)(944501410)(52105095)(10201501046)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:SN6PR2101MB1101;BCL:0;PCL:0;RULEID:;SRVR:SN6PR2101MB1101; x-forefront-prvs: 067071EFC8 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(376002)(366004)(39860400002)(346002)(39380400002)(189003)(199004)(86362001)(22452003)(486006)(66066001)(8990500004)(8936002)(76176011)(2906002)(72206003)(7696005)(5660300001)(99286004)(229853002)(478600001)(33656002)(110136005)(2501003)(2201001)(6636002)(316002)(97736004)(68736007)(6346003)(3660700001)(3846002)(3280700002)(102836004)(6436002)(6116002)(11346002)(74316002)(446003)(2900100001)(55016002)(1511001)(106356001)(26005)(81156014)(86612001)(5250100002)(305945005)(14454004)(53936002)(6246003)(10290500003)(7736002)(8676002)(105586002)(81166006)(10090500001)(9686003)(6506007)(476003)(25786009)(921003)(1121003);DIR:OUT;SFP:1102;SCL:1;SRVR:SN6PR2101MB1101;H:SN6PR2101MB1120.namprd21.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Michael.H.Kelley@microsoft.com; x-microsoft-antispam-message-info: be2A2VUh/NbEeWg6PX0XNTzwJXFjcXN37HRqDJ4NkPwdhCVHZ+jV08QAeiLLvSlRaqDwY1jTTagFA7cBCzezsDFb82ecFFqb7cDqxrjhbVx9OlV7CRF+58LaLrjKGKpKoZ+NvDJ4kM4DrOKFz6Hzph0d7WFylnu9RgbUygs6R13PBh2dPzTpYxKZLp+cbZx1 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: dddbc88b-3e03-4a76-6ea1-08d5b807ab05 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: dddbc88b-3e03-4a76-6ea1-08d5b807ab05 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2018 12:55:41.4773 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR2101MB1101 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > -#define hv_init_timer(timer, tick) wrmsrl(timer, tick) > > -#define hv_init_timer_config(config, val) wrmsrl(config, val) > > +#define hv_init_timer(timer, tick) \ > > + wrmsrl(HV_X64_MSR_STIMER0_COUNT + (2*timer), tick) > > +#define hv_init_timer_config(timer, val) \ > > + wrmsrl(HV_X64_MSR_STIMER0_CONFIG + (2*timer), val) > > Why are we stepping in units of 2? >=20 > K. Y The register addresses for the *_CONFIG and *_COUNT registers are interleaved. From hyperv-tlfs.h: #define HV_X64_MSR_STIMER0_CONFIG 0x400000B0 #define HV_X64_MSR_STIMER0_COUNT 0x400000B1 #define HV_X64_MSR_STIMER1_CONFIG 0x400000B2 #define HV_X64_MSR_STIMER1_COUNT 0x400000B3 #define HV_X64_MSR_STIMER2_CONFIG 0x400000B4 #define HV_X64_MSR_STIMER2_COUNT 0x400000B5 #define HV_X64_MSR_STIMER3_CONFIG 0x400000B6 #define HV_X64_MSR_STIMER3_COUNT 0x400000B7 Michael